[INFO] updating cached repository ftlc/Rust-Toy-Language [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ftlc/Rust-Toy-Language [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ftlc/Rust-Toy-Language" "work/ex/clippy-test-run/sources/stable/gh/ftlc/Rust-Toy-Language"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ftlc/Rust-Toy-Language'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ftlc/Rust-Toy-Language" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ftlc/Rust-Toy-Language"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ftlc/Rust-Toy-Language'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dde5f00cd3a8a7735bd831d0fedc3d7a1489ce1a [INFO] sha for GitHub repo ftlc/Rust-Toy-Language: dde5f00cd3a8a7735bd831d0fedc3d7a1489ce1a [INFO] validating manifest of ftlc/Rust-Toy-Language on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ftlc/Rust-Toy-Language on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ftlc/Rust-Toy-Language [INFO] finished frobbing ftlc/Rust-Toy-Language [INFO] frobbed toml for ftlc/Rust-Toy-Language written to work/ex/clippy-test-run/sources/stable/gh/ftlc/Rust-Toy-Language/Cargo.toml [INFO] started frobbing ftlc/Rust-Toy-Language [INFO] finished frobbing ftlc/Rust-Toy-Language [INFO] frobbed toml for ftlc/Rust-Toy-Language written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ftlc/Rust-Toy-Language/Cargo.toml [INFO] crate ftlc/Rust-Toy-Language has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ftlc/Rust-Toy-Language against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ftlc/Rust-Toy-Language:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] acc46f8ba373b171b9e11e17c8e3fd439f8ea7cf6b9bf70de33f0df65f12211b [INFO] running `"docker" "start" "-a" "acc46f8ba373b171b9e11e17c8e3fd439f8ea7cf6b9bf70de33f0df65f12211b"` [INFO] [stderr] Checking sexp v1.1.4 [INFO] [stderr] Checking pl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | return ExprC::PlusC { l: Box::new(l_c), r: Box::new(r_c) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ExprC::PlusC { l: Box::new(l_c), r: Box::new(r_c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | return ExprC::MultC { l: Box::new(l_c), r: Box::new(r_c) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ExprC::MultC { l: Box::new(l_c), r: Box::new(r_c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / return ExprC::PlusC { [INFO] [stderr] 37 | | l : Box::new(l_c), [INFO] [stderr] 38 | | r : Box::new( [INFO] [stderr] 39 | | ExprC::MultC { [INFO] [stderr] ... | [INFO] [stderr] 42 | | }) [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | ExprC::PlusC { [INFO] [stderr] 37 | l : Box::new(l_c), [INFO] [stderr] 38 | r : Box::new( [INFO] [stderr] 39 | ExprC::MultC { [INFO] [stderr] 40 | l : Box::new(ExprC::NumC(-1)), [INFO] [stderr] 41 | r : Box::new(r_c) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | return num_plus(l_n, r_n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num_plus(l_n, r_n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | return num_mult(l_n, r_n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num_mult(l_n, r_n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | return ExprC::PlusC { l: Box::new(l_c), r: Box::new(r_c) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ExprC::PlusC { l: Box::new(l_c), r: Box::new(r_c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | return ExprC::MultC { l: Box::new(l_c), r: Box::new(r_c) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ExprC::MultC { l: Box::new(l_c), r: Box::new(r_c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / return ExprC::PlusC { [INFO] [stderr] 37 | | l : Box::new(l_c), [INFO] [stderr] 38 | | r : Box::new( [INFO] [stderr] 39 | | ExprC::MultC { [INFO] [stderr] ... | [INFO] [stderr] 42 | | }) [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | ExprC::PlusC { [INFO] [stderr] 37 | l : Box::new(l_c), [INFO] [stderr] 38 | r : Box::new( [INFO] [stderr] 39 | ExprC::MultC { [INFO] [stderr] 40 | l : Box::new(ExprC::NumC(-1)), [INFO] [stderr] 41 | r : Box::new(r_c) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | return num_plus(l_n, r_n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num_plus(l_n, r_n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | return num_mult(l_n, r_n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num_mult(l_n, r_n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | fn fourth(v : &Vec) -> &T { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | fn third(v : &Vec) -> &T { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | fn second(v : &Vec) -> &T { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:86:8 [INFO] [stderr] | [INFO] [stderr] 86 | if tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | fn fourth(v : &Vec) -> &T { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | fn third(v : &Vec) -> &T { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | fn second(v : &Vec) -> &T { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:86:8 [INFO] [stderr] | [INFO] [stderr] 86 | if tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.85s [INFO] running `"docker" "inspect" "acc46f8ba373b171b9e11e17c8e3fd439f8ea7cf6b9bf70de33f0df65f12211b"` [INFO] running `"docker" "rm" "-f" "acc46f8ba373b171b9e11e17c8e3fd439f8ea7cf6b9bf70de33f0df65f12211b"` [INFO] [stdout] acc46f8ba373b171b9e11e17c8e3fd439f8ea7cf6b9bf70de33f0df65f12211b