[INFO] updating cached repository ftilde/linkcheck [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ftilde/linkcheck [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ftilde/linkcheck" "work/ex/clippy-test-run/sources/stable/gh/ftilde/linkcheck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ftilde/linkcheck'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ftilde/linkcheck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ftilde/linkcheck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ftilde/linkcheck'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 24eafd4003a5349cdf8c01f9df52920641aa9114 [INFO] sha for GitHub repo ftilde/linkcheck: 24eafd4003a5349cdf8c01f9df52920641aa9114 [INFO] validating manifest of ftilde/linkcheck on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ftilde/linkcheck on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ftilde/linkcheck [INFO] finished frobbing ftilde/linkcheck [INFO] frobbed toml for ftilde/linkcheck written to work/ex/clippy-test-run/sources/stable/gh/ftilde/linkcheck/Cargo.toml [INFO] started frobbing ftilde/linkcheck [INFO] finished frobbing ftilde/linkcheck [INFO] frobbed toml for ftilde/linkcheck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ftilde/linkcheck/Cargo.toml [INFO] crate ftilde/linkcheck has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ftilde/linkcheck against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ftilde/linkcheck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 09942daf1ef398e5d9f1653b7e6cac53d258f82bca5419c3e96bd5aa9ab64680 [INFO] running `"docker" "start" "-a" "09942daf1ef398e5d9f1653b7e6cac53d258f82bca5419c3e96bd5aa9ab64680"` [INFO] [stderr] Compiling cpp_demangle v0.2.12 [INFO] [stderr] Compiling scroll v0.9.2 [INFO] [stderr] Compiling syn v0.15.12 [INFO] [stderr] Compiling scroll_derive v0.9.5 [INFO] [stderr] Compiling structopt-derive v0.2.12 [INFO] [stderr] Checking structopt v0.2.12 [INFO] [stderr] Checking goblin v0.0.15 [INFO] [stderr] Checking linkcheck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libraries.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libraries.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libraries.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libraries.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/libraries.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | const LD_CONFIG_PREFIX: &'static str = "ldconfig:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/libraries.rs:288:28 [INFO] [stderr] | [INFO] [stderr] 288 | const INCLUDE_PREFIX: &'static str = "include "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/libraries.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | const LD_CONFIG_PREFIX: &'static str = "ldconfig:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/libraries.rs:288:28 [INFO] [stderr] | [INFO] [stderr] 288 | const INCLUDE_PREFIX: &'static str = "include "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/libraries.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / if let &Some(ref dynamic) = &elf.dynamic { [INFO] [stderr] 34 | | let mut dyninfo = DynInfo::new(); [INFO] [stderr] 35 | | for dyn in dynamic.dyns.iter() { [INFO] [stderr] 36 | | match dyn.d_tag { [INFO] [stderr] ... | [INFO] [stderr] 63 | | None [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(ref dynamic) = elf.dynamic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/libraries.rs:42:62 [INFO] [stderr] | [INFO] [stderr] 42 | dyninfo.rpath.extend(rpath_str.split(":")) [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/libraries.rs:49:66 [INFO] [stderr] | [INFO] [stderr] 49 | dyninfo.runpath.extend(runpath_str.split(":")) [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libraries.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | / pub fn get_elf<'a>(&'a self) -> Elf<'a> { [INFO] [stderr] 166 | | Elf::parse(&self.bytes).expect("Invariant: Valid ELF") [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/libraries.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / match self { [INFO] [stderr] 196 | | &LibResolveProblem::Unresolved { [INFO] [stderr] 197 | | ref dependent_lib, [INFO] [stderr] 198 | | ref lib_name, [INFO] [stderr] ... | [INFO] [stderr] 235 | | }, [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 195 | match *self { [INFO] [stderr] 196 | LibResolveProblem::Unresolved { [INFO] [stderr] 197 | ref dependent_lib, [INFO] [stderr] 198 | ref lib_name, [INFO] [stderr] 199 | ref locations, [INFO] [stderr] 200 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/libraries.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / if let &Some(ref dynamic) = &elf.dynamic { [INFO] [stderr] 34 | | let mut dyninfo = DynInfo::new(); [INFO] [stderr] 35 | | for dyn in dynamic.dyns.iter() { [INFO] [stderr] 36 | | match dyn.d_tag { [INFO] [stderr] ... | [INFO] [stderr] 63 | | None [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(ref dynamic) = elf.dynamic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/libraries.rs:42:62 [INFO] [stderr] | [INFO] [stderr] 42 | dyninfo.rpath.extend(rpath_str.split(":")) [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/libraries.rs:49:66 [INFO] [stderr] | [INFO] [stderr] 49 | dyninfo.runpath.extend(runpath_str.split(":")) [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/libraries.rs:292:48 [INFO] [stderr] | [INFO] [stderr] 292 | if line.is_empty() || line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libraries.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | / pub fn get_elf<'a>(&'a self) -> Elf<'a> { [INFO] [stderr] 166 | | Elf::parse(&self.bytes).expect("Invariant: Valid ELF") [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/libraries.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / match self { [INFO] [stderr] 196 | | &LibResolveProblem::Unresolved { [INFO] [stderr] 197 | | ref dependent_lib, [INFO] [stderr] 198 | | ref lib_name, [INFO] [stderr] ... | [INFO] [stderr] 235 | | }, [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 195 | match *self { [INFO] [stderr] 196 | LibResolveProblem::Unresolved { [INFO] [stderr] 197 | ref dependent_lib, [INFO] [stderr] 198 | ref lib_name, [INFO] [stderr] 199 | ref locations, [INFO] [stderr] 200 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/libraries.rs:363:14 [INFO] [stderr] | [INFO] [stderr] 363 | .unwrap_or(Path::new("/")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/libraries.rs:370:13 [INFO] [stderr] | [INFO] [stderr] 370 | / match method { [INFO] [stderr] 371 | | &LibSearchMethod::RPath => { [INFO] [stderr] 372 | | lib_locations.0.extend(dyninfo.rpath.iter().map(|path| { [INFO] [stderr] 373 | | ( [INFO] [stderr] ... | [INFO] [stderr] 402 | | } [INFO] [stderr] 403 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 370 | match *method { [INFO] [stderr] 371 | LibSearchMethod::RPath => { [INFO] [stderr] 372 | lib_locations.0.extend(dyninfo.rpath.iter().map(|path| { [INFO] [stderr] 373 | ( [INFO] [stderr] 374 | PathBuf::from(path.replace("$ORIGIN", origin).to_owned()), [INFO] [stderr] 375 | "rpath", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/libraries.rs:429:21 [INFO] [stderr] | [INFO] [stderr] 429 | / if let &Some(ref dependency_lib_path) = &dependency_lib_path { [INFO] [stderr] 430 | | if dependency_lib_path != resolved_lib_path { [INFO] [stderr] 431 | | problems.push(LibResolveProblem::ResolveConflict { [INFO] [stderr] 432 | | dependent_lib: lib_path.to_path_buf(), [INFO] [stderr] ... | [INFO] [stderr] 449 | | }); [INFO] [stderr] 450 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 429 | if let Some(ref dependency_lib_path) = dependency_lib_path { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/libraries.rs:292:48 [INFO] [stderr] | [INFO] [stderr] 292 | if line.is_empty() || line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/libraries.rs:363:14 [INFO] [stderr] | [INFO] [stderr] 363 | .unwrap_or(Path::new("/")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/libraries.rs:370:13 [INFO] [stderr] | [INFO] [stderr] 370 | / match method { [INFO] [stderr] 371 | | &LibSearchMethod::RPath => { [INFO] [stderr] 372 | | lib_locations.0.extend(dyninfo.rpath.iter().map(|path| { [INFO] [stderr] 373 | | ( [INFO] [stderr] ... | [INFO] [stderr] 402 | | } [INFO] [stderr] 403 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 370 | match *method { [INFO] [stderr] 371 | LibSearchMethod::RPath => { [INFO] [stderr] 372 | lib_locations.0.extend(dyninfo.rpath.iter().map(|path| { [INFO] [stderr] 373 | ( [INFO] [stderr] 374 | PathBuf::from(path.replace("$ORIGIN", origin).to_owned()), [INFO] [stderr] 375 | "rpath", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/libraries.rs:429:21 [INFO] [stderr] | [INFO] [stderr] 429 | / if let &Some(ref dependency_lib_path) = &dependency_lib_path { [INFO] [stderr] 430 | | if dependency_lib_path != resolved_lib_path { [INFO] [stderr] 431 | | problems.push(LibResolveProblem::ResolveConflict { [INFO] [stderr] 432 | | dependent_lib: lib_path.to_path_buf(), [INFO] [stderr] ... | [INFO] [stderr] 449 | | }); [INFO] [stderr] 450 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 429 | if let Some(ref dependency_lib_path) = dependency_lib_path { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbols.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | let elf = libs.opened_libs.get(lib_path).unwrap().get_elf(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&libs.opened_libs[lib_path]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/symbols.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/symbols.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbols.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | let elf = libs.opened_libs.get(lib_path).unwrap().get_elf(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&libs.opened_libs[lib_path]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/symbols.rs:61:30 [INFO] [stderr] | [INFO] [stderr] 61 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/symbols.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/symbols.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/symbols.rs:61:30 [INFO] [stderr] | [INFO] [stderr] 61 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | libs.len() >= 1 && symbol_summary.defined.get(symbol.as_str()).is_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!libs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | libs.len() >= 1 && symbol_summary.defined.get(symbol.as_str()).is_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!libs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.19s [INFO] running `"docker" "inspect" "09942daf1ef398e5d9f1653b7e6cac53d258f82bca5419c3e96bd5aa9ab64680"` [INFO] running `"docker" "rm" "-f" "09942daf1ef398e5d9f1653b7e6cac53d258f82bca5419c3e96bd5aa9ab64680"` [INFO] [stdout] 09942daf1ef398e5d9f1653b7e6cac53d258f82bca5419c3e96bd5aa9ab64680