[INFO] updating cached repository fsommar/adventofcode2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fsommar/adventofcode2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fsommar/adventofcode2018" "work/ex/clippy-test-run/sources/stable/gh/fsommar/adventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fsommar/adventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fsommar/adventofcode2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fsommar/adventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fsommar/adventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 74126122a66c3bedaa4e13bfd66c65a2aa9d002f [INFO] sha for GitHub repo fsommar/adventofcode2018: 74126122a66c3bedaa4e13bfd66c65a2aa9d002f [INFO] validating manifest of fsommar/adventofcode2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fsommar/adventofcode2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fsommar/adventofcode2018 [INFO] finished frobbing fsommar/adventofcode2018 [INFO] frobbed toml for fsommar/adventofcode2018 written to work/ex/clippy-test-run/sources/stable/gh/fsommar/adventofcode2018/Cargo.toml [INFO] started frobbing fsommar/adventofcode2018 [INFO] finished frobbing fsommar/adventofcode2018 [INFO] frobbed toml for fsommar/adventofcode2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fsommar/adventofcode2018/Cargo.toml [INFO] crate fsommar/adventofcode2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fsommar/adventofcode2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fsommar/adventofcode2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2976e45e820b7fc6eee0c92d7b69515ce31299e87b81c73f9291a696cd3faf0c [INFO] running `"docker" "start" "-a" "2976e45e820b7fc6eee0c92d7b69515ce31299e87b81c73f9291a696cd3faf0c"` [INFO] [stderr] Checking adventofcode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/bin/day3-1.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | for i in left_edge..(left_edge + width) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for in table.iter_mut().skip(left_edge).take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/bin/day3-1.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 0..1000 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for in table.iter().take(1000) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/bin/day3-2.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | for i in left_edge..(left_edge + width) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for in table.iter_mut().skip(left_edge).take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/bin/day3-2.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | for i in left_edge..(left_edge + width) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for in table.iter_mut().skip(left_edge).take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bin/day2-1.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | let counts: HashSet<_> = count_chars(line).values().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `count_chars(line).values().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bin/day2-1.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | let counts: HashSet<_> = count_chars(line).values().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `count_chars(line).values().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/bin/day3-1.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | for i in left_edge..(left_edge + width) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for in table.iter_mut().skip(left_edge).take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/bin/day3-1.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 0..1000 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for in table.iter().take(1000) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.01s [INFO] running `"docker" "inspect" "2976e45e820b7fc6eee0c92d7b69515ce31299e87b81c73f9291a696cd3faf0c"` [INFO] running `"docker" "rm" "-f" "2976e45e820b7fc6eee0c92d7b69515ce31299e87b81c73f9291a696cd3faf0c"` [INFO] [stdout] 2976e45e820b7fc6eee0c92d7b69515ce31299e87b81c73f9291a696cd3faf0c