[INFO] updating cached repository fschutt/xlib-programming-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fschutt/xlib-programming-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fschutt/xlib-programming-rust" "work/ex/clippy-test-run/sources/stable/gh/fschutt/xlib-programming-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fschutt/xlib-programming-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fschutt/xlib-programming-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fschutt/xlib-programming-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fschutt/xlib-programming-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a00066f3c7cf137ffb62452c9618c7bb5693c376 [INFO] sha for GitHub repo fschutt/xlib-programming-rust: a00066f3c7cf137ffb62452c9618c7bb5693c376 [INFO] validating manifest of fschutt/xlib-programming-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fschutt/xlib-programming-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fschutt/xlib-programming-rust [INFO] finished frobbing fschutt/xlib-programming-rust [INFO] frobbed toml for fschutt/xlib-programming-rust written to work/ex/clippy-test-run/sources/stable/gh/fschutt/xlib-programming-rust/Cargo.toml [INFO] started frobbing fschutt/xlib-programming-rust [INFO] finished frobbing fschutt/xlib-programming-rust [INFO] frobbed toml for fschutt/xlib-programming-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fschutt/xlib-programming-rust/Cargo.toml [INFO] crate fschutt/xlib-programming-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fschutt/xlib-programming-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fschutt/xlib-programming-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e85cb2cbff8bfedac0482aace8711ad310221977e8c28580878b790de0b6792 [INFO] running `"docker" "start" "-a" "1e85cb2cbff8bfedac0482aace8711ad310221977e8c28580878b790de0b6792"` [INFO] [stderr] Compiling metadeps v1.1.2 [INFO] [stderr] Checking x11-dl v2.14.0 [INFO] [stderr] Compiling dbus v0.5.3 [INFO] [stderr] Checking xlibprogramming v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `CurrentTime`, `GrabModeAsync` [INFO] [stderr] --> src/main.rs:7:33 [INFO] [stderr] | [INFO] [stderr] 7 | use x11_dl::xlib::{True, False, GrabModeAsync, CurrentTime, XEvent}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:14:37 [INFO] [stderr] | [INFO] [stderr] 14 | const GL_COLOR_BUFFER_BIT: GLenum = 0x00004000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `CurrentTime`, `GrabModeAsync` [INFO] [stderr] --> src/main.rs:7:33 [INFO] [stderr] | [INFO] [stderr] 7 | use x11_dl::xlib::{True, False, GrabModeAsync, CurrentTime, XEvent}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:14:37 [INFO] [stderr] | [INFO] [stderr] 14 | const GL_COLOR_BUFFER_BIT: GLenum = 0x00004000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> examples/simple_opengl_window.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let mut display = { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> examples/simple_opengl_window.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | let mut visual_info = { if vi.is_null() { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:179:40 [INFO] [stderr] | [INFO] [stderr] 179 | let cur_match = (*width - hdisplay as i32) * (*width - hdisplay as i32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(hdisplay)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:179:71 [INFO] [stderr] | [INFO] [stderr] 179 | let cur_match = (*width - hdisplay as i32) * (*width - hdisplay as i32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(hdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:40 [INFO] [stderr] | [INFO] [stderr] 180 | (*height - vdisplay as i32) * (*height - vdisplay as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(vdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:70 [INFO] [stderr] | [INFO] [stderr] 180 | (*height - vdisplay as i32) * (*height - vdisplay as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(vdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:189:32 [INFO] [stderr] | [INFO] [stderr] 189 | *width = unsafe { (*modes_slice[best_mode]).hdisplay as i32 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((*modes_slice[best_mode]).hdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:190:32 [INFO] [stderr] | [INFO] [stderr] 190 | *height = unsafe { (*modes_slice[best_mode]).vdisplay as i32 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((*modes_slice[best_mode]).vdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:179:40 [INFO] [stderr] | [INFO] [stderr] 179 | let cur_match = (*width - hdisplay as i32) * (*width - hdisplay as i32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(hdisplay)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:179:71 [INFO] [stderr] | [INFO] [stderr] 179 | let cur_match = (*width - hdisplay as i32) * (*width - hdisplay as i32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(hdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:40 [INFO] [stderr] | [INFO] [stderr] 180 | (*height - vdisplay as i32) * (*height - vdisplay as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(vdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:70 [INFO] [stderr] | [INFO] [stderr] 180 | (*height - vdisplay as i32) * (*height - vdisplay as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(vdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:189:32 [INFO] [stderr] | [INFO] [stderr] 189 | *width = unsafe { (*modes_slice[best_mode]).hdisplay as i32 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((*modes_slice[best_mode]).hdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:190:32 [INFO] [stderr] | [INFO] [stderr] 190 | *height = unsafe { (*modes_slice[best_mode]).vdisplay as i32 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((*modes_slice[best_mode]).vdisplay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.19s [INFO] running `"docker" "inspect" "1e85cb2cbff8bfedac0482aace8711ad310221977e8c28580878b790de0b6792"` [INFO] running `"docker" "rm" "-f" "1e85cb2cbff8bfedac0482aace8711ad310221977e8c28580878b790de0b6792"` [INFO] [stdout] 1e85cb2cbff8bfedac0482aace8711ad310221977e8c28580878b790de0b6792