[INFO] updating cached repository fschutt/static_number_analyzer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fschutt/static_number_analyzer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fschutt/static_number_analyzer" "work/ex/clippy-test-run/sources/stable/gh/fschutt/static_number_analyzer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fschutt/static_number_analyzer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fschutt/static_number_analyzer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fschutt/static_number_analyzer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fschutt/static_number_analyzer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f090234e1e0c2ebd16fe70d80d628565fd9041b9 [INFO] sha for GitHub repo fschutt/static_number_analyzer: f090234e1e0c2ebd16fe70d80d628565fd9041b9 [INFO] validating manifest of fschutt/static_number_analyzer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fschutt/static_number_analyzer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fschutt/static_number_analyzer [INFO] finished frobbing fschutt/static_number_analyzer [INFO] frobbed toml for fschutt/static_number_analyzer written to work/ex/clippy-test-run/sources/stable/gh/fschutt/static_number_analyzer/Cargo.toml [INFO] started frobbing fschutt/static_number_analyzer [INFO] finished frobbing fschutt/static_number_analyzer [INFO] frobbed toml for fschutt/static_number_analyzer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fschutt/static_number_analyzer/Cargo.toml [INFO] crate fschutt/static_number_analyzer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fschutt/static_number_analyzer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fschutt/static_number_analyzer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d547d7ba6bb55c1831f21c5c5cde2ee289716b3a7e33d578829fcf6b55239e4 [INFO] running `"docker" "start" "-a" "5d547d7ba6bb55c1831f21c5c5cde2ee289716b3a7e33d578829fcf6b55239e4"` [INFO] [stderr] Checking proc-macro2 v0.4.6 [INFO] [stderr] Checking quote v0.6.3 [INFO] [stderr] Checking syn v0.14.2 [INFO] [stderr] Checking static_number_analyzer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/main.rs:284:35 [INFO] [stderr] | [INFO] [stderr] 284 | fn test_if_dependency_same_source(a: String, b: String, let_stmts: &HashMap) [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/main.rs:284:46 [INFO] [stderr] | [INFO] [stderr] 284 | fn test_if_dependency_same_source(a: String, b: String, let_stmts: &HashMap) [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `let_stmts` [INFO] [stderr] --> src/main.rs:284:57 [INFO] [stderr] | [INFO] [stderr] 284 | fn test_if_dependency_same_source(a: String, b: String, let_stmts: &HashMap) [INFO] [stderr] | ^^^^^^^^^ help: consider using `_let_stmts` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_if_dependency_same_source` [INFO] [stderr] --> src/main.rs:284:1 [INFO] [stderr] | [INFO] [stderr] 284 | / fn test_if_dependency_same_source(a: String, b: String, let_stmts: &HashMap) [INFO] [stderr] 285 | | -> bool [INFO] [stderr] 286 | | { [INFO] [stderr] 287 | | false [INFO] [stderr] 288 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match item { [INFO] [stderr] 64 | | Item::Fn(f) => { [INFO] [stderr] 65 | | functions.push(f) [INFO] [stderr] 66 | | }, [INFO] [stderr] ... | [INFO] [stderr] 69 | | _ => { }, [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Item::Fn(f) = item { [INFO] [stderr] 64 | functions.push(f) [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match variable_type.as_ref() { [INFO] [stderr] 118 | | "usize" => { variable_sources.insert(variable_name, USIZE_MIN..USIZE_MAX); }, [INFO] [stderr] 119 | | _ => { } // TODO [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "usize" = variable_type.as_ref() { variable_sources.insert(variable_name, USIZE_MIN..USIZE_MAX); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:245:42 [INFO] [stderr] | [INFO] [stderr] 245 | fn warn(func_name: &str, var1: &str, op: &BinOp, var2: &str, always: &str) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `BinOp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:249:23 [INFO] [stderr] | [INFO] [stderr] 249 | fn cond_to_string(op: &BinOp) -> &'static str { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `BinOp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/main.rs:284:35 [INFO] [stderr] | [INFO] [stderr] 284 | fn test_if_dependency_same_source(a: String, b: String, let_stmts: &HashMap) [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/main.rs:284:46 [INFO] [stderr] | [INFO] [stderr] 284 | fn test_if_dependency_same_source(a: String, b: String, let_stmts: &HashMap) [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `let_stmts` [INFO] [stderr] --> src/main.rs:284:57 [INFO] [stderr] | [INFO] [stderr] 284 | fn test_if_dependency_same_source(a: String, b: String, let_stmts: &HashMap) [INFO] [stderr] | ^^^^^^^^^ help: consider using `_let_stmts` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_if_dependency_same_source` [INFO] [stderr] --> src/main.rs:284:1 [INFO] [stderr] | [INFO] [stderr] 284 | / fn test_if_dependency_same_source(a: String, b: String, let_stmts: &HashMap) [INFO] [stderr] 285 | | -> bool [INFO] [stderr] 286 | | { [INFO] [stderr] 287 | | false [INFO] [stderr] 288 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match item { [INFO] [stderr] 64 | | Item::Fn(f) => { [INFO] [stderr] 65 | | functions.push(f) [INFO] [stderr] 66 | | }, [INFO] [stderr] ... | [INFO] [stderr] 69 | | _ => { }, [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Item::Fn(f) = item { [INFO] [stderr] 64 | functions.push(f) [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match variable_type.as_ref() { [INFO] [stderr] 118 | | "usize" => { variable_sources.insert(variable_name, USIZE_MIN..USIZE_MAX); }, [INFO] [stderr] 119 | | _ => { } // TODO [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "usize" = variable_type.as_ref() { variable_sources.insert(variable_name, USIZE_MIN..USIZE_MAX); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:245:42 [INFO] [stderr] | [INFO] [stderr] 245 | fn warn(func_name: &str, var1: &str, op: &BinOp, var2: &str, always: &str) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `BinOp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:249:23 [INFO] [stderr] | [INFO] [stderr] 249 | fn cond_to_string(op: &BinOp) -> &'static str { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `BinOp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.05s [INFO] running `"docker" "inspect" "5d547d7ba6bb55c1831f21c5c5cde2ee289716b3a7e33d578829fcf6b55239e4"` [INFO] running `"docker" "rm" "-f" "5d547d7ba6bb55c1831f21c5c5cde2ee289716b3a7e33d578829fcf6b55239e4"` [INFO] [stdout] 5d547d7ba6bb55c1831f21c5c5cde2ee289716b3a7e33d578829fcf6b55239e4