[INFO] updating cached repository frozenbears/hyperstencil [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/frozenbears/hyperstencil [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/frozenbears/hyperstencil" "work/ex/clippy-test-run/sources/stable/gh/frozenbears/hyperstencil"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/frozenbears/hyperstencil'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/frozenbears/hyperstencil" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frozenbears/hyperstencil"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frozenbears/hyperstencil'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7d8a20448c4a233d1a8ba04daed4c59d80b5769c [INFO] sha for GitHub repo frozenbears/hyperstencil: 7d8a20448c4a233d1a8ba04daed4c59d80b5769c [INFO] validating manifest of frozenbears/hyperstencil on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of frozenbears/hyperstencil on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing frozenbears/hyperstencil [INFO] finished frobbing frozenbears/hyperstencil [INFO] frobbed toml for frozenbears/hyperstencil written to work/ex/clippy-test-run/sources/stable/gh/frozenbears/hyperstencil/Cargo.toml [INFO] started frobbing frozenbears/hyperstencil [INFO] finished frobbing frozenbears/hyperstencil [INFO] frobbed toml for frozenbears/hyperstencil written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frozenbears/hyperstencil/Cargo.toml [INFO] crate frozenbears/hyperstencil has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting frozenbears/hyperstencil against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/frozenbears/hyperstencil:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b3734e0afd10edd9fc06b4a700f2c42a150a08e44c99f460710fdd576e3c686 [INFO] running `"docker" "start" "-a" "1b3734e0afd10edd9fc06b4a700f2c42a150a08e44c99f460710fdd576e3c686"` [INFO] [stderr] Checking adler32 v1.0.1 [INFO] [stderr] Checking deflate v0.7.15 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking hyperstencil v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `index` is used to index `imgbuf` [INFO] [stderr] --> src/main.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | for index in 0..imgbuf.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for (index, ) in imgbuf.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | fn write_buffer(buffer: &Vec, output: &str) -> HsResult { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:107:31 [INFO] [stderr] | [INFO] [stderr] 107 | fn write_image_buffer(imgbuf: &Vec, width: u32, height: u32, output: &str) -> HsResult { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `imgbuf` [INFO] [stderr] --> src/main.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | for index in 0..imgbuf.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for (index, ) in imgbuf.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | fn write_buffer(buffer: &Vec, output: &str) -> HsResult { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:107:31 [INFO] [stderr] | [INFO] [stderr] 107 | fn write_image_buffer(imgbuf: &Vec, width: u32, height: u32, output: &str) -> HsResult { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.91s [INFO] running `"docker" "inspect" "1b3734e0afd10edd9fc06b4a700f2c42a150a08e44c99f460710fdd576e3c686"` [INFO] running `"docker" "rm" "-f" "1b3734e0afd10edd9fc06b4a700f2c42a150a08e44c99f460710fdd576e3c686"` [INFO] [stdout] 1b3734e0afd10edd9fc06b4a700f2c42a150a08e44c99f460710fdd576e3c686