[INFO] updating cached repository fredrb/rust-brainfck
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/fredrb/rust-brainfck
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/fredrb/rust-brainfck" "work/ex/clippy-test-run/sources/stable/gh/fredrb/rust-brainfck"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fredrb/rust-brainfck'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/fredrb/rust-brainfck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fredrb/rust-brainfck"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fredrb/rust-brainfck'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 17a67a15937e411e91933f89d2f429de2983520d
[INFO] sha for GitHub repo fredrb/rust-brainfck: 17a67a15937e411e91933f89d2f429de2983520d
[INFO] validating manifest of fredrb/rust-brainfck on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of fredrb/rust-brainfck on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing fredrb/rust-brainfck
[INFO] finished frobbing fredrb/rust-brainfck
[INFO] frobbed toml for fredrb/rust-brainfck written to work/ex/clippy-test-run/sources/stable/gh/fredrb/rust-brainfck/Cargo.toml
[INFO] started frobbing fredrb/rust-brainfck
[INFO] finished frobbing fredrb/rust-brainfck
[INFO] frobbed toml for fredrb/rust-brainfck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fredrb/rust-brainfck/Cargo.toml
[INFO] crate fredrb/rust-brainfck has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting fredrb/rust-brainfck against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fredrb/rust-brainfck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a1f6cc00dd54e1ed9fb39513bf8f5c3660c29b59572942f40e8da5e8365d8d57
[INFO] running `"docker" "start" "-a" "a1f6cc00dd54e1ed9fb39513bf8f5c3660c29b59572942f40e8da5e8365d8d57"`
[INFO] [stderr]     Checking brainfck v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/program_loader.rs:23:19
[INFO] [stderr]    |
[INFO] [stderr] 23 |         Err(_) => return Err(LoadError::FailedToRead),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(LoadError::FailedToRead)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/program_loader.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |         Ok(_) => return Ok(s),
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/program_loader.rs:23:19
[INFO] [stderr]    |
[INFO] [stderr] 23 |         Err(_) => return Err(LoadError::FailedToRead),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(LoadError::FailedToRead)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/program_loader.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |         Ok(_) => return Ok(s),
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `machine::Machine`
[INFO] [stderr]   --> src/machine.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     pub fn new() -> Machine {
[INFO] [stderr] 12 | |         Machine {
[INFO] [stderr] 13 | |             memory: Memory::new(30000),
[INFO] [stderr] 14 | |             program_start: 20000,
[INFO] [stderr] ...  |
[INFO] [stderr] 17 | |         }
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | impl Default for machine::Machine {
[INFO] [stderr] 11 |     fn default() -> Self {
[INFO] [stderr] 12 |         Self::new()
[INFO] [stderr] 13 |     }
[INFO] [stderr] 14 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `machine::Machine`
[INFO] [stderr]   --> src/machine.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     pub fn new() -> Machine {
[INFO] [stderr] 12 | |         Machine {
[INFO] [stderr] 13 | |             memory: Memory::new(30000),
[INFO] [stderr] 14 | |             program_start: 20000,
[INFO] [stderr] ...  |
[INFO] [stderr] 17 | |         }
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | impl Default for machine::Machine {
[INFO] [stderr] 11 |     fn default() -> Self {
[INFO] [stderr] 12 |         Self::new()
[INFO] [stderr] 13 |     }
[INFO] [stderr] 14 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]  --> src/main.rs:8:9
[INFO] [stderr]   |
[INFO] [stderr] 8 |         Err(_) => panic!("Failed to load"),
[INFO] [stderr]   |         ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]   = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]  --> src/main.rs:8:9
[INFO] [stderr]   |
[INFO] [stderr] 8 |         Err(_) => panic!("Failed to load"),
[INFO] [stderr]   |         ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]   = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.67s
[INFO] running `"docker" "inspect" "a1f6cc00dd54e1ed9fb39513bf8f5c3660c29b59572942f40e8da5e8365d8d57"`
[INFO] running `"docker" "rm" "-f" "a1f6cc00dd54e1ed9fb39513bf8f5c3660c29b59572942f40e8da5e8365d8d57"`
[INFO] [stdout] a1f6cc00dd54e1ed9fb39513bf8f5c3660c29b59572942f40e8da5e8365d8d57