[INFO] updating cached repository fredlahde/kermit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fredlahde/kermit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fredlahde/kermit" "work/ex/clippy-test-run/sources/stable/gh/fredlahde/kermit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fredlahde/kermit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fredlahde/kermit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fredlahde/kermit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fredlahde/kermit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 520044f50fa25a2e5444d5dbd36fa494dced98af [INFO] sha for GitHub repo fredlahde/kermit: 520044f50fa25a2e5444d5dbd36fa494dced98af [INFO] validating manifest of fredlahde/kermit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fredlahde/kermit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fredlahde/kermit [INFO] finished frobbing fredlahde/kermit [INFO] frobbed toml for fredlahde/kermit written to work/ex/clippy-test-run/sources/stable/gh/fredlahde/kermit/Cargo.toml [INFO] started frobbing fredlahde/kermit [INFO] finished frobbing fredlahde/kermit [INFO] frobbed toml for fredlahde/kermit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fredlahde/kermit/Cargo.toml [INFO] crate fredlahde/kermit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fredlahde/kermit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fredlahde/kermit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b24065e896242fc2ffd188579d0bdd5b7c80ed1ba61842be98771a1af5dd447 [INFO] running `"docker" "start" "-a" "5b24065e896242fc2ffd188579d0bdd5b7c80ed1ba61842be98771a1af5dd447"` [INFO] [stderr] Checking kermit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let args: Vec = env::args().collect(); [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ComposeRunner` [INFO] [stderr] --> src/compose_runner.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub struct ComposeRunner {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/compose_scanner.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | fn new(path: &str) -> ScanResult { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `scan` [INFO] [stderr] --> src/compose_scanner.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn scan(&self, base_path: &str) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_file` [INFO] [stderr] --> src/compose_scanner.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn to_file(&self, path: &str, out_file: &str) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `check_compose_directory` [INFO] [stderr] --> src/compose_scanner.rs:65:1 [INFO] [stderr] | [INFO] [stderr] 65 | fn check_compose_directory(path: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let args: Vec = env::args().collect(); [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/compose_scanner.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn from_file(&self, in_file: &str) -> Result, Error> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/compose_scanner.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | if !meta.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `meta.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ComposeRunner` [INFO] [stderr] --> src/compose_runner.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub struct ComposeRunner {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/compose_scanner.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | fn new(path: &str) -> ScanResult { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `scan` [INFO] [stderr] --> src/compose_scanner.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn scan(&self, base_path: &str) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_file` [INFO] [stderr] --> src/compose_scanner.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn to_file(&self, path: &str, out_file: &str) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `check_compose_directory` [INFO] [stderr] --> src/compose_scanner.rs:65:1 [INFO] [stderr] | [INFO] [stderr] 65 | fn check_compose_directory(path: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/compose_scanner.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn from_file(&self, in_file: &str) -> Result, Error> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/compose_scanner.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | if !meta.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `meta.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `"docker" "inspect" "5b24065e896242fc2ffd188579d0bdd5b7c80ed1ba61842be98771a1af5dd447"` [INFO] running `"docker" "rm" "-f" "5b24065e896242fc2ffd188579d0bdd5b7c80ed1ba61842be98771a1af5dd447"` [INFO] [stdout] 5b24065e896242fc2ffd188579d0bdd5b7c80ed1ba61842be98771a1af5dd447