[INFO] updating cached repository freaktechnik/fis-falsch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/freaktechnik/fis-falsch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/freaktechnik/fis-falsch" "work/ex/clippy-test-run/sources/stable/gh/freaktechnik/fis-falsch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/freaktechnik/fis-falsch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/freaktechnik/fis-falsch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/freaktechnik/fis-falsch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/freaktechnik/fis-falsch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d4d5518863cd7aa25ee8614ba30eccbbf880955d [INFO] sha for GitHub repo freaktechnik/fis-falsch: d4d5518863cd7aa25ee8614ba30eccbbf880955d [INFO] validating manifest of freaktechnik/fis-falsch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of freaktechnik/fis-falsch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing freaktechnik/fis-falsch [INFO] finished frobbing freaktechnik/fis-falsch [INFO] frobbed toml for freaktechnik/fis-falsch written to work/ex/clippy-test-run/sources/stable/gh/freaktechnik/fis-falsch/Cargo.toml [INFO] started frobbing freaktechnik/fis-falsch [INFO] finished frobbing freaktechnik/fis-falsch [INFO] frobbed toml for freaktechnik/fis-falsch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/freaktechnik/fis-falsch/Cargo.toml [INFO] crate freaktechnik/fis-falsch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting freaktechnik/fis-falsch against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/freaktechnik/fis-falsch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd068455b1779f2a403251b0ae1b7188188fe62cef366cc937a9a61e7d489f4f [INFO] running `"docker" "start" "-a" "bd068455b1779f2a403251b0ae1b7188188fe62cef366cc937a9a61e7d489f4f"` [INFO] [stderr] Compiling actix-web v0.7.13 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-signal v0.2.6 [INFO] [stderr] Checking trust-dns-proto v0.4.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0-alpha.5 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking webpki v0.18.1 [INFO] [stderr] Checking sct v0.4.0 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking rustls v0.14.0 [INFO] [stderr] Checking webpki-roots v0.15.0 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking trust-dns-resolver v0.10.0-alpha.3 [INFO] [stderr] Checking tokio-rustls v0.8.0 [INFO] [stderr] Checking actix v0.7.5 [INFO] [stderr] Checking actix-net v0.1.1 [INFO] [stderr] Checking fis-falsch v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/server/main.rs:128:18 [INFO] [stderr] | [INFO] [stderr] 128 | fn submit_outage(data: Json) -> HttpResponse { [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `station_id` [INFO] [stderr] --> src/server/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | station_id: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sub_type` [INFO] [stderr] --> src/server/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | sub_type: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `train` [INFO] [stderr] --> src/server/main.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | train: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `station` [INFO] [stderr] --> src/server/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | station: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `defect_type` [INFO] [stderr] --> src/server/main.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | defect_type: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match get_name(record.station) { [INFO] [stderr] 49 | | Some(val) => stations.push(val), [INFO] [stderr] 50 | | None => (), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let Some(val) = get_name(record.station) { stations.push(val) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/main.rs:133:36 [INFO] [stderr] | [INFO] [stderr] 133 | let parts = station_info.split("$"); [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/main.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / match s { [INFO] [stderr] 144 | | "<1>" => return Some(name.to_string()), [INFO] [stderr] 145 | | _ => (), [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "<1>" = s { return Some(name.to_string()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/server/main.rs:128:18 [INFO] [stderr] | [INFO] [stderr] 128 | fn submit_outage(data: Json) -> HttpResponse { [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `station_id` [INFO] [stderr] --> src/server/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | station_id: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sub_type` [INFO] [stderr] --> src/server/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | sub_type: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `train` [INFO] [stderr] --> src/server/main.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | train: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `station` [INFO] [stderr] --> src/server/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | station: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `defect_type` [INFO] [stderr] --> src/server/main.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | defect_type: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match get_name(record.station) { [INFO] [stderr] 49 | | Some(val) => stations.push(val), [INFO] [stderr] 50 | | None => (), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let Some(val) = get_name(record.station) { stations.push(val) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/main.rs:133:36 [INFO] [stderr] | [INFO] [stderr] 133 | let parts = station_info.split("$"); [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/main.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / match s { [INFO] [stderr] 144 | | "<1>" => return Some(name.to_string()), [INFO] [stderr] 145 | | _ => (), [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "<1>" = s { return Some(name.to_string()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.70s [INFO] running `"docker" "inspect" "bd068455b1779f2a403251b0ae1b7188188fe62cef366cc937a9a61e7d489f4f"` [INFO] running `"docker" "rm" "-f" "bd068455b1779f2a403251b0ae1b7188188fe62cef366cc937a9a61e7d489f4f"` [INFO] [stdout] bd068455b1779f2a403251b0ae1b7188188fe62cef366cc937a9a61e7d489f4f