[INFO] updating cached repository frankier/opus-parse [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/frankier/opus-parse [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/frankier/opus-parse" "work/ex/clippy-test-run/sources/stable/gh/frankier/opus-parse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/frankier/opus-parse'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/frankier/opus-parse" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frankier/opus-parse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frankier/opus-parse'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3be5f1113195f82cc9b3d1f4ad9d9693d705936d [INFO] sha for GitHub repo frankier/opus-parse: 3be5f1113195f82cc9b3d1f4ad9d9693d705936d [INFO] validating manifest of frankier/opus-parse on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of frankier/opus-parse on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing frankier/opus-parse [INFO] finished frobbing frankier/opus-parse [INFO] frobbed toml for frankier/opus-parse written to work/ex/clippy-test-run/sources/stable/gh/frankier/opus-parse/Cargo.toml [INFO] started frobbing frankier/opus-parse [INFO] finished frobbing frankier/opus-parse [INFO] frobbed toml for frankier/opus-parse written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frankier/opus-parse/Cargo.toml [INFO] crate frankier/opus-parse has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting frankier/opus-parse against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/frankier/opus-parse:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 891e7192a2c4bc8d0d54d58c15dada7141ba83e10718f2e9cab5c5e6c2a5dc80 [INFO] running `"docker" "start" "-a" "891e7192a2c4bc8d0d54d58c15dada7141ba83e10718f2e9cab5c5e6c2a5dc80"` [INFO] [stderr] Checking xml-rs v0.4.1 [INFO] [stderr] Checking itertools v0.6.0 [INFO] [stderr] Checking walkdir v2.1.3 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking minidom v0.3.1 [INFO] [stderr] Checking opus-parse v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:247:45 [INFO] [stderr] | [INFO] [stderr] 247 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:248:45 [INFO] [stderr] | [INFO] [stderr] 248 | delim_type: delim_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delim_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:247:45 [INFO] [stderr] | [INFO] [stderr] 247 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:248:45 [INFO] [stderr] | [INFO] [stderr] 248 | delim_type: delim_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delim_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | fn get_value<'a>(attrs: &'a Vec, name: &str) -> Option<&'a String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | fn req_value<'a>(attrs: &'a Vec, name: &str) -> Result<&'a String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / pub fn next(&mut self) -> Result { [INFO] [stderr] 220 | | loop { [INFO] [stderr] 221 | | let ev = self.er.next(); [INFO] [stderr] 222 | | match ev? { [INFO] [stderr] ... | [INFO] [stderr] 316 | | } [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | fn get_value<'a>(attrs: &'a Vec, name: &str) -> Option<&'a String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | fn req_value<'a>(attrs: &'a Vec, name: &str) -> Result<&'a String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / pub fn next(&mut self) -> Result { [INFO] [stderr] 220 | | loop { [INFO] [stderr] 221 | | let ev = self.er.next(); [INFO] [stderr] 222 | | match ev? { [INFO] [stderr] ... | [INFO] [stderr] 316 | | } [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.36s [INFO] running `"docker" "inspect" "891e7192a2c4bc8d0d54d58c15dada7141ba83e10718f2e9cab5c5e6c2a5dc80"` [INFO] running `"docker" "rm" "-f" "891e7192a2c4bc8d0d54d58c15dada7141ba83e10718f2e9cab5c5e6c2a5dc80"` [INFO] [stdout] 891e7192a2c4bc8d0d54d58c15dada7141ba83e10718f2e9cab5c5e6c2a5dc80