[INFO] updating cached repository francoiswnel/Hack-Emulator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/francoiswnel/Hack-Emulator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/francoiswnel/Hack-Emulator" "work/ex/clippy-test-run/sources/stable/gh/francoiswnel/Hack-Emulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/francoiswnel/Hack-Emulator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/francoiswnel/Hack-Emulator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/francoiswnel/Hack-Emulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/francoiswnel/Hack-Emulator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c82a25650881bd6df0c7db2ae7320532eb68d667 [INFO] sha for GitHub repo francoiswnel/Hack-Emulator: c82a25650881bd6df0c7db2ae7320532eb68d667 [INFO] validating manifest of francoiswnel/Hack-Emulator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of francoiswnel/Hack-Emulator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing francoiswnel/Hack-Emulator [INFO] finished frobbing francoiswnel/Hack-Emulator [INFO] frobbed toml for francoiswnel/Hack-Emulator written to work/ex/clippy-test-run/sources/stable/gh/francoiswnel/Hack-Emulator/Cargo.toml [INFO] started frobbing francoiswnel/Hack-Emulator [INFO] finished frobbing francoiswnel/Hack-Emulator [INFO] frobbed toml for francoiswnel/Hack-Emulator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/francoiswnel/Hack-Emulator/Cargo.toml [INFO] crate francoiswnel/Hack-Emulator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting francoiswnel/Hack-Emulator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/francoiswnel/Hack-Emulator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d7f29166cd63b4adc10602d8958d8ff046ea5439457c173391c393b1d10efb0 [INFO] running `"docker" "start" "-a" "6d7f29166cd63b4adc10602d8958d8ff046ea5439457c173391c393b1d10efb0"` [INFO] [stderr] Checking hemu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:298:26 [INFO] [stderr] | [INFO] [stderr] 298 | self.screen[(address - 0b1 << 14) as usize] = input; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(address - 0b1) << 14` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | return self.ram[address as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ram[address as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | return self.screen[(address - 0b1 << 14) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.screen[(address - 0b1 << 14) as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | return self.keyboard; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.keyboard` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:306:33 [INFO] [stderr] | [INFO] [stderr] 306 | return self.screen[(address - 0b1 << 14) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(address - 0b1) << 14` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:298:26 [INFO] [stderr] | [INFO] [stderr] 298 | self.screen[(address - 0b1 << 14) as usize] = input; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(address - 0b1) << 14` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | return self.ram[address as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ram[address as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | return self.screen[(address - 0b1 << 14) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.screen[(address - 0b1 << 14) as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | return self.keyboard; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.keyboard` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:306:33 [INFO] [stderr] | [INFO] [stderr] 306 | return self.screen[(address - 0b1 << 14) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(address - 0b1) << 14` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: value assigned to `instruction` is never read [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | let mut instruction: u16 = 0; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `instruction` is never read [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | let mut instruction: u16 = 0; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match rom_file.read_to_string(&mut rom_buffer) { [INFO] [stderr] 52 | | Err(why) => { [INFO] [stderr] 53 | | panic!("\nError: Failed to read {:?}: {}\n", [INFO] [stderr] 54 | | rom_file_name, [INFO] [stderr] ... | [INFO] [stderr] 57 | | Ok(_) => (), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | if let Err(why) = rom_file.read_to_string(&mut rom_buffer) { [INFO] [stderr] 52 | panic!("\nError: Failed to read {:?}: {}\n", [INFO] [stderr] 53 | rom_file_name, [INFO] [stderr] 54 | why.description()) [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `buffer_line_number` is used as a loop counter. Consider using `for (buffer_line_number, item) in rom_buffer.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | for instruction in rom_buffer.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | self.write_a = !self.instruction_type || (self.instruction_type && instruction & 0b1 << 5 != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 175 | self.write_a = instruction & 0b1 << 5 != 0 || !self.instruction_type; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 175 | self.write_a = !(self.instruction_type && instruction & 0b1 << 5 == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | self.flags = self.flags | 0b1 << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.flags |= 0b1 << 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | self.flags = self.flags | 0b1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.flags |= 0b1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match rom_file.read_to_string(&mut rom_buffer) { [INFO] [stderr] 52 | | Err(why) => { [INFO] [stderr] 53 | | panic!("\nError: Failed to read {:?}: {}\n", [INFO] [stderr] 54 | | rom_file_name, [INFO] [stderr] ... | [INFO] [stderr] 57 | | Ok(_) => (), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | if let Err(why) = rom_file.read_to_string(&mut rom_buffer) { [INFO] [stderr] 52 | panic!("\nError: Failed to read {:?}: {}\n", [INFO] [stderr] 53 | rom_file_name, [INFO] [stderr] 54 | why.description()) [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `buffer_line_number` is used as a loop counter. Consider using `for (buffer_line_number, item) in rom_buffer.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | for instruction in rom_buffer.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | self.write_a = !self.instruction_type || (self.instruction_type && instruction & 0b1 << 5 != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 175 | self.write_a = instruction & 0b1 << 5 != 0 || !self.instruction_type; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 175 | self.write_a = !(self.instruction_type && instruction & 0b1 << 5 == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | self.flags = self.flags | 0b1 << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.flags |= 0b1 << 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | self.flags = self.flags | 0b1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.flags |= 0b1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `"docker" "inspect" "6d7f29166cd63b4adc10602d8958d8ff046ea5439457c173391c393b1d10efb0"` [INFO] running `"docker" "rm" "-f" "6d7f29166cd63b4adc10602d8958d8ff046ea5439457c173391c393b1d10efb0"` [INFO] [stdout] 6d7f29166cd63b4adc10602d8958d8ff046ea5439457c173391c393b1d10efb0