[INFO] updating cached repository frafra/brutegol [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/frafra/brutegol [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/frafra/brutegol" "work/ex/clippy-test-run/sources/stable/gh/frafra/brutegol"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/frafra/brutegol'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/frafra/brutegol" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frafra/brutegol"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frafra/brutegol'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a91dd151d1bcf4f0aff05d26506e32b6fd1879a5 [INFO] sha for GitHub repo frafra/brutegol: a91dd151d1bcf4f0aff05d26506e32b6fd1879a5 [INFO] validating manifest of frafra/brutegol on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of frafra/brutegol on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing frafra/brutegol [INFO] finished frobbing frafra/brutegol [INFO] frobbed toml for frafra/brutegol written to work/ex/clippy-test-run/sources/stable/gh/frafra/brutegol/Cargo.toml [INFO] started frobbing frafra/brutegol [INFO] finished frobbing frafra/brutegol [INFO] frobbed toml for frafra/brutegol written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frafra/brutegol/Cargo.toml [INFO] crate frafra/brutegol has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting frafra/brutegol against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/frafra/brutegol:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c1dc408da27e4068438438827ca22e063a5ebf5cdf9f7a53792cf5970d0c649 [INFO] running `"docker" "start" "-a" "8c1dc408da27e4068438438827ca22e063a5ebf5cdf9f7a53792cf5970d0c649"` [INFO] [stderr] Checking brutegol v0.3.0 (/opt/crater/workdir) [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return prepare; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `prepare` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | return repeated; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `repeated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | return i%columns+(rows-1-i/columns)*columns; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i%columns+(rows-1-i/columns)*columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return i+columns-2*(i%columns)-1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i+columns-2*(i%columns)-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return i%columns*rows+i/columns; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i%columns*rows+i/columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return mirror_diagonal(len, rows, columns, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mirror_diagonal(len, rows, columns, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return len-1-i; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `len-1-i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return mirror_vertical(len, rows, columns, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mirror_vertical(len, rows, columns, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | return mirror_vertical(len, rows, columns, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mirror_vertical(len, rows, columns, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/main.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | fn mirror_horizontal(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/main.rs:100:20 [INFO] [stderr] | [INFO] [stderr] 100 | fn mirror_vertical(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rows` [INFO] [stderr] --> src/main.rs:100:32 [INFO] [stderr] | [INFO] [stderr] 100 | fn mirror_vertical(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^^ help: consider using `_rows` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/main.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | fn mirror_diagonal(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rows` [INFO] [stderr] --> src/main.rs:116:27 [INFO] [stderr] | [INFO] [stderr] 116 | fn rotate_180(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^^ help: consider using `_rows` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `columns` [INFO] [stderr] --> src/main.rs:116:40 [INFO] [stderr] | [INFO] [stderr] 116 | fn rotate_180(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^^^^^ help: consider using `_columns` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn show(table: &Vec, rows: usize, columns: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | / match table[c+r*columns] { [INFO] [stderr] 14 | | false => prepare.push('x'), [INFO] [stderr] 15 | | true => prepare.push('@'), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if table[c+r*columns] { prepare.push('@') } else { prepare.push('x') }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `history` [INFO] [stderr] --> src/main.rs:70:31 [INFO] [stderr] | [INFO] [stderr] 70 | 'comparison: for i in 0..history.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | 'comparison: for (i, ) in history.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `table` [INFO] [stderr] --> src/main.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | for j in 0..table.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for (j, ) in table.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | let mut transformations: Vec usize> = vec![ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Checking quickcheck v0.6.2 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return prepare; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `prepare` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | return repeated; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `repeated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | return i%columns+(rows-1-i/columns)*columns; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i%columns+(rows-1-i/columns)*columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return i+columns-2*(i%columns)-1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i+columns-2*(i%columns)-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return i%columns*rows+i/columns; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i%columns*rows+i/columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return mirror_diagonal(len, rows, columns, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mirror_diagonal(len, rows, columns, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return len-1-i; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `len-1-i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return mirror_vertical(len, rows, columns, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mirror_vertical(len, rows, columns, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | return mirror_vertical(len, rows, columns, p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mirror_vertical(len, rows, columns, p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | return i == pos; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i == pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | return i == pos; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i == pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | return i == pos; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i == pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | return i == pos; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `i == pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/main.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | fn mirror_horizontal(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/main.rs:100:20 [INFO] [stderr] | [INFO] [stderr] 100 | fn mirror_vertical(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rows` [INFO] [stderr] --> src/main.rs:100:32 [INFO] [stderr] | [INFO] [stderr] 100 | fn mirror_vertical(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^^ help: consider using `_rows` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/main.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | fn mirror_diagonal(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rows` [INFO] [stderr] --> src/main.rs:116:27 [INFO] [stderr] | [INFO] [stderr] 116 | fn rotate_180(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^^ help: consider using `_rows` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `columns` [INFO] [stderr] --> src/main.rs:116:40 [INFO] [stderr] | [INFO] [stderr] 116 | fn rotate_180(len: usize, rows: usize, columns: usize, i: usize) -> usize { [INFO] [stderr] | ^^^^^^^ help: consider using `_columns` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn show(table: &Vec, rows: usize, columns: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | / match table[c+r*columns] { [INFO] [stderr] 14 | | false => prepare.push('x'), [INFO] [stderr] 15 | | true => prepare.push('@'), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if table[c+r*columns] { prepare.push('@') } else { prepare.push('x') }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `history` [INFO] [stderr] --> src/main.rs:70:31 [INFO] [stderr] | [INFO] [stderr] 70 | 'comparison: for i in 0..history.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | 'comparison: for (i, ) in history.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `table` [INFO] [stderr] --> src/main.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | for j in 0..table.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for (j, ) in table.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | let mut transformations: Vec usize> = vec![ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `show` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:226:25 [INFO] [stderr] | [INFO] [stderr] 226 | assert_eq!(show(&mut glider(), 4, 4), result); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.41s [INFO] running `"docker" "inspect" "8c1dc408da27e4068438438827ca22e063a5ebf5cdf9f7a53792cf5970d0c649"` [INFO] running `"docker" "rm" "-f" "8c1dc408da27e4068438438827ca22e063a5ebf5cdf9f7a53792cf5970d0c649"` [INFO] [stdout] 8c1dc408da27e4068438438827ca22e063a5ebf5cdf9f7a53792cf5970d0c649