[INFO] updating cached repository fracture91/pong-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fracture91/pong-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fracture91/pong-rust" "work/ex/clippy-test-run/sources/stable/gh/fracture91/pong-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fracture91/pong-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fracture91/pong-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fracture91/pong-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fracture91/pong-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2ba36af7aa7f6528add353fa162f9484f21e6c4a [INFO] sha for GitHub repo fracture91/pong-rust: 2ba36af7aa7f6528add353fa162f9484f21e6c4a [INFO] validating manifest of fracture91/pong-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fracture91/pong-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fracture91/pong-rust [INFO] finished frobbing fracture91/pong-rust [INFO] frobbed toml for fracture91/pong-rust written to work/ex/clippy-test-run/sources/stable/gh/fracture91/pong-rust/Cargo.toml [INFO] started frobbing fracture91/pong-rust [INFO] finished frobbing fracture91/pong-rust [INFO] frobbed toml for fracture91/pong-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fracture91/pong-rust/Cargo.toml [INFO] crate fracture91/pong-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fracture91/pong-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fracture91/pong-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 310f6ef02be68a91b156a093ac0e0381698aaa45515795901404061bd651f6cb [INFO] running `"docker" "start" "-a" "310f6ef02be68a91b156a093ac0e0381698aaa45515795901404061bd651f6cb"` [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Checking alga v0.5.2 [INFO] [stderr] Checking x11-dl v2.16.0 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking libloading v0.3.4 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking glutin v0.10.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.49.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.42.0 [INFO] [stderr] Checking gfx v0.16.1 [INFO] [stderr] Checking gfx_device_gl v0.14.4 [INFO] [stderr] Checking piston-gfx_texture v0.29.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.46.0 [INFO] [stderr] Checking piston_window v0.73.0 [INFO] [stderr] Checking pong v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | (rv as f64) * PADDLE_SPEED [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(rv)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:41 [INFO] [stderr] | [INFO] [stderr] 62 | fn update_position(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:34 [INFO] [stderr] | [INFO] [stderr] 83 | let scale = Vector2::new((args.width as f64) / WORLD_WIDTH, (args.height as f64) / WORLD_HEIGHT); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:69 [INFO] [stderr] | [INFO] [stderr] 83 | let scale = Vector2::new((args.width as f64) / WORLD_WIDTH, (args.height as f64) / WORLD_HEIGHT); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:98:32 [INFO] [stderr] | [INFO] [stderr] 98 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:116:43 [INFO] [stderr] | [INFO] [stderr] 116 | let starting_y: f64 = (WORLD_HEIGHT / 2 as f64) - (PADDLE_HEIGHT / 2 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:116:72 [INFO] [stderr] | [INFO] [stderr] 116 | let starting_y: f64 = (WORLD_HEIGHT / 2 as f64) - (PADDLE_HEIGHT / 2 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | (rv as f64) * PADDLE_SPEED [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(rv)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:41 [INFO] [stderr] | [INFO] [stderr] 62 | fn update_position(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:34 [INFO] [stderr] | [INFO] [stderr] 83 | let scale = Vector2::new((args.width as f64) / WORLD_WIDTH, (args.height as f64) / WORLD_HEIGHT); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:83:69 [INFO] [stderr] | [INFO] [stderr] 83 | let scale = Vector2::new((args.width as f64) / WORLD_WIDTH, (args.height as f64) / WORLD_HEIGHT); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:98:32 [INFO] [stderr] | [INFO] [stderr] 98 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:116:43 [INFO] [stderr] | [INFO] [stderr] 116 | let starting_y: f64 = (WORLD_HEIGHT / 2 as f64) - (PADDLE_HEIGHT / 2 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:116:72 [INFO] [stderr] | [INFO] [stderr] 116 | let starting_y: f64 = (WORLD_HEIGHT / 2 as f64) - (PADDLE_HEIGHT / 2 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `"docker" "inspect" "310f6ef02be68a91b156a093ac0e0381698aaa45515795901404061bd651f6cb"` [INFO] running `"docker" "rm" "-f" "310f6ef02be68a91b156a093ac0e0381698aaa45515795901404061bd651f6cb"` [INFO] [stdout] 310f6ef02be68a91b156a093ac0e0381698aaa45515795901404061bd651f6cb