[INFO] updating cached repository foxmk/rust-gamedev-experiment [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/foxmk/rust-gamedev-experiment [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/foxmk/rust-gamedev-experiment" "work/ex/clippy-test-run/sources/stable/gh/foxmk/rust-gamedev-experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/foxmk/rust-gamedev-experiment'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/foxmk/rust-gamedev-experiment" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foxmk/rust-gamedev-experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foxmk/rust-gamedev-experiment'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1c052d4cb279050c0ed00542b803a10b2a453166 [INFO] sha for GitHub repo foxmk/rust-gamedev-experiment: 1c052d4cb279050c0ed00542b803a10b2a453166 [INFO] validating manifest of foxmk/rust-gamedev-experiment on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of foxmk/rust-gamedev-experiment on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing foxmk/rust-gamedev-experiment [INFO] finished frobbing foxmk/rust-gamedev-experiment [INFO] frobbed toml for foxmk/rust-gamedev-experiment written to work/ex/clippy-test-run/sources/stable/gh/foxmk/rust-gamedev-experiment/Cargo.toml [INFO] started frobbing foxmk/rust-gamedev-experiment [INFO] finished frobbing foxmk/rust-gamedev-experiment [INFO] frobbed toml for foxmk/rust-gamedev-experiment written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foxmk/rust-gamedev-experiment/Cargo.toml [INFO] crate foxmk/rust-gamedev-experiment has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting foxmk/rust-gamedev-experiment against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/foxmk/rust-gamedev-experiment:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec6c842aa26ca29ba99cc9c71c12b99c04115327df327d5bc1f399e32018410e [INFO] running `"docker" "start" "-a" "ec6c842aa26ca29ba99cc9c71c12b99c04115327df327d5bc1f399e32018410e"` [INFO] [stderr] Checking tempfile v3.0.2 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Checking x11-dl v2.17.5 [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking genmesh v0.5.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking gfx_device_gl v0.15.2 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.20.0 [INFO] [stderr] Checking dungeon-generator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / return Renderer { [INFO] [stderr] 123 | | encoder_ref, [INFO] [stderr] 124 | | width, [INFO] [stderr] 125 | | height, [INFO] [stderr] ... | [INFO] [stderr] 131 | | mvp: transform, [INFO] [stderr] 132 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 122 | Renderer { [INFO] [stderr] 123 | encoder_ref, [INFO] [stderr] 124 | width, [INFO] [stderr] 125 | height, [INFO] [stderr] 126 | out, [INFO] [stderr] 127 | bundle, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/graphics.rs:86:61 [INFO] [stderr] | [INFO] [stderr] 86 | let vertex_buffer = factory.create_buffer::(1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/graphics.rs:92:57 [INFO] [stderr] | [INFO] [stderr] 92 | let index_buffer = factory.create_buffer::(1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/graphics.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | end: 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return InputProcessor {}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `InputProcessor {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/game.rs:47:101 [INFO] [stderr] | [INFO] [stderr] 47 | let elapsed_millis = (elapsed.as_secs() as f32 * 1000.0) + (elapsed.subsec_nanos() as f32 / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / return App { [INFO] [stderr] 35 | | game: game::Game::new(), [INFO] [stderr] 36 | | renderer, [INFO] [stderr] 37 | | input_processor, [INFO] [stderr] 38 | | window, [INFO] [stderr] 39 | | device, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 34 | App { [INFO] [stderr] 35 | game: game::Game::new(), [INFO] [stderr] 36 | renderer, [INFO] [stderr] 37 | input_processor, [INFO] [stderr] 38 | window, [INFO] [stderr] 39 | device, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / return Renderer { [INFO] [stderr] 123 | | encoder_ref, [INFO] [stderr] 124 | | width, [INFO] [stderr] 125 | | height, [INFO] [stderr] ... | [INFO] [stderr] 131 | | mvp: transform, [INFO] [stderr] 132 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 122 | Renderer { [INFO] [stderr] 123 | encoder_ref, [INFO] [stderr] 124 | width, [INFO] [stderr] 125 | height, [INFO] [stderr] 126 | out, [INFO] [stderr] 127 | bundle, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/graphics.rs:86:61 [INFO] [stderr] | [INFO] [stderr] 86 | let vertex_buffer = factory.create_buffer::(1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/graphics.rs:92:57 [INFO] [stderr] | [INFO] [stderr] 92 | let index_buffer = factory.create_buffer::(1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/graphics.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | end: 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return InputProcessor {}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `InputProcessor {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/game.rs:47:101 [INFO] [stderr] | [INFO] [stderr] 47 | let elapsed_millis = (elapsed.as_secs() as f32 * 1000.0) + (elapsed.subsec_nanos() as f32 / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / return App { [INFO] [stderr] 35 | | game: game::Game::new(), [INFO] [stderr] 36 | | renderer, [INFO] [stderr] 37 | | input_processor, [INFO] [stderr] 38 | | window, [INFO] [stderr] 39 | | device, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 34 | App { [INFO] [stderr] 35 | game: game::Game::new(), [INFO] [stderr] 36 | renderer, [INFO] [stderr] 37 | input_processor, [INFO] [stderr] 38 | window, [INFO] [stderr] 39 | device, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: field is never used: `should_update` [INFO] [stderr] --> src/graphics.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | should_update: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `should_update` [INFO] [stderr] --> src/graphics.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | should_update: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | app.run(&mut events_loop); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | app.run(&mut events_loop); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.37s [INFO] running `"docker" "inspect" "ec6c842aa26ca29ba99cc9c71c12b99c04115327df327d5bc1f399e32018410e"` [INFO] running `"docker" "rm" "-f" "ec6c842aa26ca29ba99cc9c71c12b99c04115327df327d5bc1f399e32018410e"` [INFO] [stdout] ec6c842aa26ca29ba99cc9c71c12b99c04115327df327d5bc1f399e32018410e