[INFO] updating cached repository fouralarmfire/rustbuzz [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fouralarmfire/rustbuzz [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fouralarmfire/rustbuzz" "work/ex/clippy-test-run/sources/stable/gh/fouralarmfire/rustbuzz"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fouralarmfire/rustbuzz'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fouralarmfire/rustbuzz" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fouralarmfire/rustbuzz"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fouralarmfire/rustbuzz'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5a75f0d1067f7bb668b50c34878d07a9d2c0e45a [INFO] sha for GitHub repo fouralarmfire/rustbuzz: 5a75f0d1067f7bb668b50c34878d07a9d2c0e45a [INFO] validating manifest of fouralarmfire/rustbuzz on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fouralarmfire/rustbuzz on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fouralarmfire/rustbuzz [INFO] finished frobbing fouralarmfire/rustbuzz [INFO] frobbed toml for fouralarmfire/rustbuzz written to work/ex/clippy-test-run/sources/stable/gh/fouralarmfire/rustbuzz/Cargo.toml [INFO] started frobbing fouralarmfire/rustbuzz [INFO] finished frobbing fouralarmfire/rustbuzz [INFO] frobbed toml for fouralarmfire/rustbuzz written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fouralarmfire/rustbuzz/Cargo.toml [INFO] crate fouralarmfire/rustbuzz has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fouralarmfire/rustbuzz against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fouralarmfire/rustbuzz:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 248bd6a1eb7556688864a6f8766976cc18b999a469396c8b4bd17c58d6c85e9e [INFO] running `"docker" "start" "-a" "248bd6a1eb7556688864a6f8766976cc18b999a469396c8b4bd17c58d6c85e9e"` [INFO] [stderr] Checking rust_buzz v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | let result = if divisible_by_fifteen(number) { [INFO] [stderr] | ________________^ [INFO] [stderr] 21 | | "fizzbuzz".into() [INFO] [stderr] 22 | | } else if divisible_by_five(number) { [INFO] [stderr] 23 | | "buzz".into() [INFO] [stderr] ... | [INFO] [stderr] 27 | | number.to_string().into() [INFO] [stderr] 28 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | let result = if divisible_by_fifteen(number) { [INFO] [stderr] | ________________^ [INFO] [stderr] 21 | | "fizzbuzz".into() [INFO] [stderr] 22 | | } else if divisible_by_five(number) { [INFO] [stderr] 23 | | "buzz".into() [INFO] [stderr] ... | [INFO] [stderr] 27 | | number.to_string().into() [INFO] [stderr] 28 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.45s [INFO] running `"docker" "inspect" "248bd6a1eb7556688864a6f8766976cc18b999a469396c8b4bd17c58d6c85e9e"` [INFO] running `"docker" "rm" "-f" "248bd6a1eb7556688864a6f8766976cc18b999a469396c8b4bd17c58d6c85e9e"` [INFO] [stdout] 248bd6a1eb7556688864a6f8766976cc18b999a469396c8b4bd17c58d6c85e9e