[INFO] updating cached repository foundoulis/slytherlisp_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/foundoulis/slytherlisp_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/foundoulis/slytherlisp_rust" "work/ex/clippy-test-run/sources/stable/gh/foundoulis/slytherlisp_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/foundoulis/slytherlisp_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/foundoulis/slytherlisp_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foundoulis/slytherlisp_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foundoulis/slytherlisp_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c6f7230567bd8e79ecee636790d65035aa0391c [INFO] sha for GitHub repo foundoulis/slytherlisp_rust: 5c6f7230567bd8e79ecee636790d65035aa0391c [INFO] validating manifest of foundoulis/slytherlisp_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of foundoulis/slytherlisp_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing foundoulis/slytherlisp_rust [INFO] finished frobbing foundoulis/slytherlisp_rust [INFO] frobbed toml for foundoulis/slytherlisp_rust written to work/ex/clippy-test-run/sources/stable/gh/foundoulis/slytherlisp_rust/Cargo.toml [INFO] started frobbing foundoulis/slytherlisp_rust [INFO] finished frobbing foundoulis/slytherlisp_rust [INFO] frobbed toml for foundoulis/slytherlisp_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foundoulis/slytherlisp_rust/Cargo.toml [INFO] crate foundoulis/slytherlisp_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting foundoulis/slytherlisp_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/foundoulis/slytherlisp_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7de68ce28eca21fa8f5356e994efb3e9ae40b4f5c506e3f0348d975e5c10923e [INFO] running `"docker" "start" "-a" "7de68ce28eca21fa8f5356e994efb3e9ae40b4f5c506e3f0348d975e5c10923e"` [INFO] [stderr] Checking memchr v2.1.1 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking slytherlisp_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/lexicalvarstorage.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | environ: environ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `environ` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/lexicalvarstorage.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | environ: environ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `environ` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/parser/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod parser; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/parser.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/parser.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | let tokens = raw_tokens.into_iter().filter(|x| *x != ControlToken::Other).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/parser/parser.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn lisp(code: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/lexicalvarstorage.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(self.local[&key].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.local[&key].clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/lexicalvarstorage.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(self.environ[&key].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.environ[&key].clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/lexicalvarstorage.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | return Err(format!("Undefined variable '{}'", key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Undefined variable '{}'", key))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/parser/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod parser; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/parser.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/parser.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | let tokens = raw_tokens.into_iter().filter(|x| *x != ControlToken::Other).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/parser/parser.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn lisp(code: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/lexicalvarstorage.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(self.local[&key].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.local[&key].clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/lexicalvarstorage.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(self.environ[&key].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.environ[&key].clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/lexicalvarstorage.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | return Err(format!("Undefined variable '{}'", key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Undefined variable '{}'", key))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_type` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn test_type() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/parser.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | 'reverse: while stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/parser.rs:140:8 [INFO] [stderr] | [INFO] [stderr] 140 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `types::conslist::ConsList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types/conslist.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / impl ConsList { [INFO] [stderr] 10 | | pub fn new(list: &Vec) -> ConsList { [INFO] [stderr] 11 | | ConsList(LispValue::from_iterable(list), list.len()) [INFO] [stderr] 12 | | } [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/conslist.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(list: &Vec) -> ConsList { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[LispValue]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/types/conslist.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | start = start + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `start += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/lispvalue.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn from_iterable(list: &Vec) -> LispValue { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[LispValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types/lispvalue.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/types/lispvalue.rs:39:45 [INFO] [stderr] | [INFO] [stderr] 39 | LispValue::Symbol(ref value) => format!("{}", value), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `value.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types/lispvalue.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | if temp_cdr.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `temp_cdr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/types/lispvalue.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | format!("{}", temp_car) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `temp_car.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_type` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn test_type() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/parser.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | 'reverse: while stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/parser.rs:140:8 [INFO] [stderr] | [INFO] [stderr] 140 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `types::conslist::ConsList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/types/conslist.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / impl ConsList { [INFO] [stderr] 10 | | pub fn new(list: &Vec) -> ConsList { [INFO] [stderr] 11 | | ConsList(LispValue::from_iterable(list), list.len()) [INFO] [stderr] 12 | | } [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/conslist.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(list: &Vec) -> ConsList { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[LispValue]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/types/conslist.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | start = start + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `start += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/lispvalue.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn from_iterable(list: &Vec) -> LispValue { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[LispValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types/lispvalue.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/types/lispvalue.rs:39:45 [INFO] [stderr] | [INFO] [stderr] 39 | LispValue::Symbol(ref value) => format!("{}", value), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `value.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types/lispvalue.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | if temp_cdr.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `temp_cdr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/types/lispvalue.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | format!("{}", temp_car) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `temp_car.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.43s [INFO] running `"docker" "inspect" "7de68ce28eca21fa8f5356e994efb3e9ae40b4f5c506e3f0348d975e5c10923e"` [INFO] running `"docker" "rm" "-f" "7de68ce28eca21fa8f5356e994efb3e9ae40b4f5c506e3f0348d975e5c10923e"` [INFO] [stdout] 7de68ce28eca21fa8f5356e994efb3e9ae40b4f5c506e3f0348d975e5c10923e