[INFO] updating cached repository fooker/pinup [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fooker/pinup [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fooker/pinup" "work/ex/clippy-test-run/sources/stable/gh/fooker/pinup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fooker/pinup'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fooker/pinup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fooker/pinup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fooker/pinup'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bc61166432dd9af31c1e5870b33b321bee86ef95 [INFO] sha for GitHub repo fooker/pinup: bc61166432dd9af31c1e5870b33b321bee86ef95 [INFO] validating manifest of fooker/pinup on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fooker/pinup on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fooker/pinup [INFO] finished frobbing fooker/pinup [INFO] frobbed toml for fooker/pinup written to work/ex/clippy-test-run/sources/stable/gh/fooker/pinup/Cargo.toml [INFO] started frobbing fooker/pinup [INFO] finished frobbing fooker/pinup [INFO] frobbed toml for fooker/pinup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fooker/pinup/Cargo.toml [INFO] crate fooker/pinup has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fooker/pinup against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fooker/pinup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e85a2a81ccc3fc96eb7b74a8352e686a49247ff1b1ba7915e3c2fd67f43b7b4f [INFO] running `"docker" "start" "-a" "e85a2a81ccc3fc96eb7b74a8352e686a49247ff1b1ba7915e3c2fd67f43b7b4f"` [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking yaml-rust v0.4.0 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking nix v0.6.0 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking clap v2.29.2 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking sysfs_gpio v0.5.1 [INFO] [stderr] Checking ctrlc v3.1.1 [INFO] [stderr] Checking pinup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(yaml::from_str(&data)?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(yaml::from_str(&data)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(yaml::from_str(&data)?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(yaml::from_str(&data)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.84s [INFO] running `"docker" "inspect" "e85a2a81ccc3fc96eb7b74a8352e686a49247ff1b1ba7915e3c2fd67f43b7b4f"` [INFO] running `"docker" "rm" "-f" "e85a2a81ccc3fc96eb7b74a8352e686a49247ff1b1ba7915e3c2fd67f43b7b4f"` [INFO] [stdout] e85a2a81ccc3fc96eb7b74a8352e686a49247ff1b1ba7915e3c2fd67f43b7b4f