[INFO] updating cached repository flxo/rogcat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/flxo/rogcat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/flxo/rogcat" "work/ex/clippy-test-run/sources/stable/gh/flxo/rogcat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/flxo/rogcat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/flxo/rogcat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flxo/rogcat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flxo/rogcat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 947c77ac5137e6a44cb1d050bbe4d242ca334d36 [INFO] sha for GitHub repo flxo/rogcat: 947c77ac5137e6a44cb1d050bbe4d242ca334d36 [INFO] validating manifest of flxo/rogcat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flxo/rogcat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flxo/rogcat [INFO] finished frobbing flxo/rogcat [INFO] frobbed toml for flxo/rogcat written to work/ex/clippy-test-run/sources/stable/gh/flxo/rogcat/Cargo.toml [INFO] started frobbing flxo/rogcat [INFO] finished frobbing flxo/rogcat [INFO] frobbed toml for flxo/rogcat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flxo/rogcat/Cargo.toml [INFO] crate flxo/rogcat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flxo/rogcat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/flxo/rogcat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83a909fed1f79467820926577997facd738741b856df8061a95cd66ed13612f3 [INFO] running `"docker" "start" "-a" "83a909fed1f79467820926577997facd738741b856df8061a95cd66ed13612f3"` [INFO] [stderr] Compiling crc32fast v1.1.0 [INFO] [stderr] Checking signal-hook v0.1.6 [INFO] [stderr] Checking directories v1.0.2 [INFO] [stderr] Checking libudev-sys v0.1.4 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking serde-hjson v0.8.2 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking serialport v3.1.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking zip v0.5.0 [INFO] [stderr] Checking parking_lot v0.7.0 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking mio-serial v3.1.0 [INFO] [stderr] Checking config v0.9.1 [INFO] [stderr] Checking console v0.7.0 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-serial v3.1.0 [INFO] [stderr] Checking indicatif v0.10.1 [INFO] [stderr] Checking tokio-process v0.2.3 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking rogcat v0.3.0-alpha.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn tempfile_with_content(c: &SVec) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:68:52 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn check_file_content(file: &PathBuf, content: &SVec) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tests/utils.rs:80:10 [INFO] [stderr] | [INFO] [stderr] 80 | .expect(&format!( [INFO] [stderr] | __________^ [INFO] [stderr] 81 | | "Error: rogcat binary not found, looked in `{:?}`. Do you need to run `cargo build`?", [INFO] [stderr] 82 | | dirs [INFO] [stderr] 83 | | )) [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|| panic!("Error: rogcat binary not found, looked in `{:?}`. Do you need to run `cargo build`?", dirs))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn run_rogcat(args: &SVec, input: Option) -> Result<(bool, SVec), Error> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tests/utils.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | if input.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:116:41 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn run_rogcat_with_input_file(args: &SVec, payload: &SVec) -> Result<(bool, SVec), Error> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:116:57 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn run_rogcat_with_input_file(args: &SVec, payload: &SVec) -> Result<(bool, SVec), Error> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/profiles.rs:47:48 [INFO] [stderr] | [INFO] [stderr] 47 | fn run_rogcat_with_config_and_input_file(args: &SVec, payload: &SVec) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/profiles.rs:47:64 [INFO] [stderr] | [INFO] [stderr] 47 | fn run_rogcat_with_config_and_input_file(args: &SVec, payload: &SVec) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tests/system.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | let result = run_rogcat(a, None).expect(&a.join(" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = &a.join(" "); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.64s [INFO] running `"docker" "inspect" "83a909fed1f79467820926577997facd738741b856df8061a95cd66ed13612f3"` [INFO] running `"docker" "rm" "-f" "83a909fed1f79467820926577997facd738741b856df8061a95cd66ed13612f3"` [INFO] [stdout] 83a909fed1f79467820926577997facd738741b856df8061a95cd66ed13612f3