[INFO] updating cached repository flugsio/gluj [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/flugsio/gluj [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/flugsio/gluj" "work/ex/clippy-test-run/sources/stable/gh/flugsio/gluj"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/flugsio/gluj'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/flugsio/gluj" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flugsio/gluj"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flugsio/gluj'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 893e99ce7d66fa2679737cd5e5b87f5586004441 [INFO] sha for GitHub repo flugsio/gluj: 893e99ce7d66fa2679737cd5e5b87f5586004441 [INFO] validating manifest of flugsio/gluj on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flugsio/gluj on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flugsio/gluj [INFO] finished frobbing flugsio/gluj [INFO] frobbed toml for flugsio/gluj written to work/ex/clippy-test-run/sources/stable/gh/flugsio/gluj/Cargo.toml [INFO] started frobbing flugsio/gluj [INFO] finished frobbing flugsio/gluj [INFO] frobbed toml for flugsio/gluj written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flugsio/gluj/Cargo.toml [INFO] crate flugsio/gluj has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flugsio/gluj against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/flugsio/gluj:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2a67ca54619277c48a00ad62acc1f7971a00f57ca15b85ad5c15147a72b2f1f [INFO] running `"docker" "start" "-a" "d2a67ca54619277c48a00ad62acc1f7971a00f57ca15b85ad5c15147a72b2f1f"` [INFO] [stderr] Checking gluj v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | latest: latest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `latest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | glucose: glucose, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `glucose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | latest: latest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `latest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | glucose: glucose, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `glucose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/graph.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &Grapheme::Empty => write!(f, " "), [INFO] [stderr] 25 | | &Grapheme::Timeline => write!(f, "|"), [INFO] [stderr] 26 | | &Grapheme::Waitline => write!(f, "-"), [INFO] [stderr] ... | [INFO] [stderr] 31 | | &Grapheme::Glucose(_) => write!(f, "?"), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | Grapheme::Empty => write!(f, " "), [INFO] [stderr] 25 | Grapheme::Timeline => write!(f, "|"), [INFO] [stderr] 26 | Grapheme::Waitline => write!(f, "-"), [INFO] [stderr] 27 | Grapheme::Glucose(x) if -1.0 < x && x < 34.0 => { [INFO] [stderr] 28 | let y = char::from_digit(x.round() as u32, 36).unwrap().to_uppercase().next().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph.rs:38:45 [INFO] [stderr] | [INFO] [stderr] 38 | let latest = entries.last().map(|e| e.at.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `e.at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/graph.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/graph.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &Grapheme::Empty => write!(f, " "), [INFO] [stderr] 25 | | &Grapheme::Timeline => write!(f, "|"), [INFO] [stderr] 26 | | &Grapheme::Waitline => write!(f, "-"), [INFO] [stderr] ... | [INFO] [stderr] 31 | | &Grapheme::Glucose(_) => write!(f, "?"), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | Grapheme::Empty => write!(f, " "), [INFO] [stderr] 25 | Grapheme::Timeline => write!(f, "|"), [INFO] [stderr] 26 | Grapheme::Waitline => write!(f, "-"), [INFO] [stderr] 27 | Grapheme::Glucose(x) if -1.0 < x && x < 34.0 => { [INFO] [stderr] 28 | let y = char::from_digit(x.round() as u32, 36).unwrap().to_uppercase().next().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph.rs:38:45 [INFO] [stderr] | [INFO] [stderr] 38 | let latest = entries.last().map(|e| e.at.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `e.at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/graph.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/graph.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | assert!(1i64 == 1); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gluj`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d2a67ca54619277c48a00ad62acc1f7971a00f57ca15b85ad5c15147a72b2f1f"` [INFO] running `"docker" "rm" "-f" "d2a67ca54619277c48a00ad62acc1f7971a00f57ca15b85ad5c15147a72b2f1f"` [INFO] [stdout] d2a67ca54619277c48a00ad62acc1f7971a00f57ca15b85ad5c15147a72b2f1f