[INFO] updating cached repository flowstage/routing-service
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/flowstage/routing-service
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/flowstage/routing-service" "work/ex/clippy-test-run/sources/stable/gh/flowstage/routing-service"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/flowstage/routing-service'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/flowstage/routing-service" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flowstage/routing-service"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flowstage/routing-service'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ccfb0e535ae75b3e81dfb22bf6c5d97182938343
[INFO] sha for GitHub repo flowstage/routing-service: ccfb0e535ae75b3e81dfb22bf6c5d97182938343
[INFO] validating manifest of flowstage/routing-service on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of flowstage/routing-service on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing flowstage/routing-service
[INFO] finished frobbing flowstage/routing-service
[INFO] frobbed toml for flowstage/routing-service written to work/ex/clippy-test-run/sources/stable/gh/flowstage/routing-service/Cargo.toml
[INFO] started frobbing flowstage/routing-service
[INFO] finished frobbing flowstage/routing-service
[INFO] frobbed toml for flowstage/routing-service written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flowstage/routing-service/Cargo.toml
[INFO] crate flowstage/routing-service has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting flowstage/routing-service against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/flowstage/routing-service:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c361276d43960bae482a582c439c65bdba78f5c8105c187928db62a64345d438
[INFO] running `"docker" "start" "-a" "c361276d43960bae482a582c439c65bdba78f5c8105c187928db62a64345d438"`
[INFO] [stderr]     Checking futures-cpupool v0.1.7
[INFO] [stderr]     Checking mio v0.6.11
[INFO] [stderr]     Checking tokio-io v0.1.4
[INFO] [stderr]     Checking regex v0.2.5
[INFO] [stderr]     Checking tokio-core v0.1.11
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking hyper v0.11.10
[INFO] [stderr]     Checking routing_service v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config/mod.rs:42:18
[INFO] [stderr]    |
[INFO] [stderr] 42 |         Config { socket: socket }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/mod.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Server { config: config }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config/mod.rs:42:18
[INFO] [stderr]    |
[INFO] [stderr] 42 |         Config { socket: socket }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/mod.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Server { config: config }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:24:14
[INFO] [stderr]    |
[INFO] [stderr] 24 | const NAME: &'static str = env!("CARGO_PKG_NAME");
[INFO] [stderr]    |             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:25:21
[INFO] [stderr]    |
[INFO] [stderr] 25 | const DESCRIPTION: &'static str = env!("CARGO_PKG_DESCRIPTION");
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:29:24
[INFO] [stderr]    |
[INFO] [stderr] 29 | const DEFAULT_SOCKET: &'static str = "127.0.0.1:8080";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:32:24
[INFO] [stderr]    |
[INFO] [stderr] 32 | const SOCKET_INVALID: &'static str = "Could not parse socket.";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/server/handler/version/mod.rs:22:17
[INFO] [stderr]    |
[INFO] [stderr] 22 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:24:14
[INFO] [stderr]    |
[INFO] [stderr] 24 | const NAME: &'static str = env!("CARGO_PKG_NAME");
[INFO] [stderr]    |             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:25:21
[INFO] [stderr]    |
[INFO] [stderr] 25 | const DESCRIPTION: &'static str = env!("CARGO_PKG_DESCRIPTION");
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:29:24
[INFO] [stderr]    |
[INFO] [stderr] 29 | const DEFAULT_SOCKET: &'static str = "127.0.0.1:8080";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config/mod.rs:32:24
[INFO] [stderr]    |
[INFO] [stderr] 32 | const SOCKET_INVALID: &'static str = "Could not parse socket.";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/server/handler/version/mod.rs:22:17
[INFO] [stderr]    |
[INFO] [stderr] 22 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/config/mod.rs:74:12
[INFO] [stderr]    |
[INFO] [stderr] 74 |       if let Err(_) = s.parse::<SocketAddr>() {
[INFO] [stderr]    |  _____-      ^^^^^^
[INFO] [stderr] 75 | |         Err(String::from(SOCKET_INVALID))
[INFO] [stderr] 76 | |     } else {
[INFO] [stderr] 77 | |         Ok(())
[INFO] [stderr] 78 | |     }
[INFO] [stderr]    | |_____- help: try this: `if s.parse::<SocketAddr>().is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/server/mod.rs:97:22
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 Get, "^/version$", get_version
[INFO] [stderr]    |                      ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]    = help: consider using `==` on `str`s
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/server/mod.rs:122:12
[INFO] [stderr]     |
[INFO] [stderr] 122 |     table: &Vec<Route>,
[INFO] [stderr]     |            ^^^^^^^^^^^ help: change this to: `&[Route]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/server/mod.rs:136:15
[INFO] [stderr]     |
[INFO] [stderr] 136 |     } else if res.len() == 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/config/mod.rs:74:12
[INFO] [stderr]    |
[INFO] [stderr] 74 |       if let Err(_) = s.parse::<SocketAddr>() {
[INFO] [stderr]    |  _____-      ^^^^^^
[INFO] [stderr] 75 | |         Err(String::from(SOCKET_INVALID))
[INFO] [stderr] 76 | |     } else {
[INFO] [stderr] 77 | |         Ok(())
[INFO] [stderr] 78 | |     }
[INFO] [stderr]    | |_____- help: try this: `if s.parse::<SocketAddr>().is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/server/mod.rs:97:22
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 Get, "^/version$", get_version
[INFO] [stderr]    |                      ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]    = help: consider using `==` on `str`s
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/server/mod.rs:122:12
[INFO] [stderr]     |
[INFO] [stderr] 122 |     table: &Vec<Route>,
[INFO] [stderr]     |            ^^^^^^^^^^^ help: change this to: `&[Route]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/server/mod.rs:136:15
[INFO] [stderr]     |
[INFO] [stderr] 136 |     } else if res.len() == 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/server/mod.rs:177:22
[INFO] [stderr]     |
[INFO] [stderr] 177 |                 Get, "^/valid$", mock_handler 
[INFO] [stderr]     |                      ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: consider using `==` on `str`s
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/server/mod.rs:195:22
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 Get, "^/valid$", mock_handler 
[INFO] [stderr]     |                      ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: consider using `==` on `str`s
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/server/mod.rs:216:22
[INFO] [stderr]     |
[INFO] [stderr] 216 |                 Get, "^/valid$", mock_handler,
[INFO] [stderr]     |                      ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: consider using `==` on `str`s
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/server/mod.rs:217:22
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 Get, "^/valid$", mock_handler 
[INFO] [stderr]     |                      ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: consider using `==` on `str`s
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 20.88s
[INFO] running `"docker" "inspect" "c361276d43960bae482a582c439c65bdba78f5c8105c187928db62a64345d438"`
[INFO] running `"docker" "rm" "-f" "c361276d43960bae482a582c439c65bdba78f5c8105c187928db62a64345d438"`
[INFO] [stdout] c361276d43960bae482a582c439c65bdba78f5c8105c187928db62a64345d438