[INFO] updating cached repository flofriday/thumbcloud [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/flofriday/thumbcloud [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/flofriday/thumbcloud" "work/ex/clippy-test-run/sources/stable/gh/flofriday/thumbcloud"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/flofriday/thumbcloud'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/flofriday/thumbcloud" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flofriday/thumbcloud"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flofriday/thumbcloud'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d815943928e307455e5446d5783ebd01770a0289 [INFO] sha for GitHub repo flofriday/thumbcloud: d815943928e307455e5446d5783ebd01770a0289 [INFO] validating manifest of flofriday/thumbcloud on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flofriday/thumbcloud on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flofriday/thumbcloud [INFO] finished frobbing flofriday/thumbcloud [INFO] frobbed toml for flofriday/thumbcloud written to work/ex/clippy-test-run/sources/stable/gh/flofriday/thumbcloud/Cargo.toml [INFO] started frobbing flofriday/thumbcloud [INFO] finished frobbing flofriday/thumbcloud [INFO] frobbed toml for flofriday/thumbcloud written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flofriday/thumbcloud/Cargo.toml [INFO] crate flofriday/thumbcloud has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flofriday/thumbcloud against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/flofriday/thumbcloud:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c529ea06663db626b2e243ead475c82a0a54f1a900e4573b4cafbb3691a84acf [INFO] running `"docker" "start" "-a" "c529ea06663db626b2e243ead475c82a0a54f1a900e4573b4cafbb3691a84acf"` [INFO] [stderr] Checking machine-ip v0.2.1 [INFO] [stderr] Compiling actix-web v0.7.3 [INFO] [stderr] Checking socket2 v0.3.7 [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Checking pretty-bytes v0.2.2 [INFO] [stderr] Checking miniz-sys v0.1.10 [INFO] [stderr] Checking brotli-sys v0.3.2 [INFO] [stderr] Checking http v0.1.10 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Compiling toml v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Compiling nom v4.0.0 [INFO] [stderr] Checking tokio-signal v0.2.1 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking crossbeam-channel v0.2.4 [INFO] [stderr] Checking h2 v0.1.11 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking actix v0.7.3 [INFO] [stderr] Compiling askama_shared v0.7.1 [INFO] [stderr] Compiling askama_derive v0.7.1 [INFO] [stderr] Compiling askama v0.7.1 [INFO] [stderr] Compiling thumbcloud v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:83:44 [INFO] [stderr] | [INFO] [stderr] 83 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] //because clap allways passes a String [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:107:44 [INFO] [stderr] | [INFO] [stderr] 107 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] //because clap allways passes a String [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:83:44 [INFO] [stderr] | [INFO] [stderr] 83 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] //because clap allways passes a String [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:83:44 [INFO] [stderr] | [INFO] [stderr] 83 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] //because clap allways passes a String [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:107:44 [INFO] [stderr] | [INFO] [stderr] 107 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] //because clap allways passes a String [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:83:44 [INFO] [stderr] | [INFO] [stderr] 83 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] //because clap allways passes a String [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 29s [INFO] running `"docker" "inspect" "c529ea06663db626b2e243ead475c82a0a54f1a900e4573b4cafbb3691a84acf"` [INFO] running `"docker" "rm" "-f" "c529ea06663db626b2e243ead475c82a0a54f1a900e4573b4cafbb3691a84acf"` [INFO] [stdout] c529ea06663db626b2e243ead475c82a0a54f1a900e4573b4cafbb3691a84acf