[INFO] updating cached repository flannelhead/adventofcode2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/flannelhead/adventofcode2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/flannelhead/adventofcode2018" "work/ex/clippy-test-run/sources/stable/gh/flannelhead/adventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/flannelhead/adventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/flannelhead/adventofcode2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flannelhead/adventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flannelhead/adventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 73f8fdb46998336d20f65af830f5e9a71668f05b [INFO] sha for GitHub repo flannelhead/adventofcode2018: 73f8fdb46998336d20f65af830f5e9a71668f05b [INFO] validating manifest of flannelhead/adventofcode2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flannelhead/adventofcode2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flannelhead/adventofcode2018 [INFO] finished frobbing flannelhead/adventofcode2018 [INFO] frobbed toml for flannelhead/adventofcode2018 written to work/ex/clippy-test-run/sources/stable/gh/flannelhead/adventofcode2018/Cargo.toml [INFO] started frobbing flannelhead/adventofcode2018 [INFO] finished frobbing flannelhead/adventofcode2018 [INFO] frobbed toml for flannelhead/adventofcode2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flannelhead/adventofcode2018/Cargo.toml [INFO] crate flannelhead/adventofcode2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flannelhead/adventofcode2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/flannelhead/adventofcode2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f624485500553a96046f1fb2bee056dfcbb4e67113ca6bd2537a03c44a5590bd [INFO] running `"docker" "start" "-a" "f624485500553a96046f1fb2bee056dfcbb4e67113ca6bd2537a03c44a5590bd"` [INFO] [stderr] Checking adventofcode2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/4_1.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | event: event [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/8.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/8.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | children: children [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/6_1.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | fn find_bounding_box(points: &Vec) -> Rect { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/2_2.rs:4:22 [INFO] [stderr] | [INFO] [stderr] 4 | fn levenshtein(str1: &String, str2: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/2_2.rs:4:37 [INFO] [stderr] | [INFO] [stderr] 4 | fn levenshtein(str1: &String, str2: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/2_2.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | fn common_chars(str1: &String, str2: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/2_2.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | fn common_chars(str1: &String, str2: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/3_1.rs:82:60 [INFO] [stderr] | [INFO] [stderr] 82 | let count_of_overlaps = claim_map.values().filter(|&c| c >= &2).count(); [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/7_1.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/8.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | if node.children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `node.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bin/7_1.rs:5:51 [INFO] [stderr] | [INFO] [stderr] 5 | fn part1(mut steps: HashMap>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/7_1.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return task_name as i32 - 'A' as i32 + 61; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `task_name as i32 - 'A' as i32 + 61` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bin/7_1.rs:45:51 [INFO] [stderr] | [INFO] [stderr] 45 | fn part2(mut steps: HashMap>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/2_2.rs:4:22 [INFO] [stderr] | [INFO] [stderr] 4 | fn levenshtein(str1: &String, str2: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/2_2.rs:4:37 [INFO] [stderr] | [INFO] [stderr] 4 | fn levenshtein(str1: &String, str2: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/2_2.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | fn common_chars(str1: &String, str2: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/2_2.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | fn common_chars(str1: &String, str2: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/4_1.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | let max_minute = max_minutes.get(&max_sum_guard_id).unwrap().0 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&max_minutes[&max_sum_guard_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/8.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/8.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | children: children [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bin/7_1.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / loop { [INFO] [stderr] 8 | | match take_task(&mut steps) { [INFO] [stderr] 9 | | Some(step) => { [INFO] [stderr] 10 | | steps_ordered.push(step); [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(step) = take_task(&mut steps) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/7_1.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | steps.entry(target).or_insert(HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/7_1.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | steps.entry(dep).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/4_1.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | event: event [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/5_1.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / return data.chars().fold(String::new(), |mut res, new_char| { [INFO] [stderr] 6 | | match res.chars().last() { [INFO] [stderr] 7 | | Some(chr) => if chr != new_char && chr.eq_ignore_ascii_case(&new_char) { [INFO] [stderr] 8 | | res.pop(); [INFO] [stderr] ... | [INFO] [stderr] 14 | | res [INFO] [stderr] 15 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 5 | data.chars().fold(String::new(), |mut res, new_char| { [INFO] [stderr] 6 | match res.chars().last() { [INFO] [stderr] 7 | Some(chr) => if chr != new_char && chr.eq_ignore_ascii_case(&new_char) { [INFO] [stderr] 8 | res.pop(); [INFO] [stderr] 9 | return res [INFO] [stderr] 10 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/7_1.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/5_1.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | fn reduce(data: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/5_1.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | / match res.chars().last() { [INFO] [stderr] 7 | | Some(chr) => if chr != new_char && chr.eq_ignore_ascii_case(&new_char) { [INFO] [stderr] 8 | | res.pop(); [INFO] [stderr] 9 | | return res [INFO] [stderr] 10 | | }, [INFO] [stderr] 11 | | None => () [INFO] [stderr] 12 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | if let Some(chr) = res.chars().last() { if chr != new_char && chr.eq_ignore_ascii_case(&new_char) { [INFO] [stderr] 7 | res.pop(); [INFO] [stderr] 8 | return res [INFO] [stderr] 9 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/5_1.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let range = 'a' as u8 .. 'z' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/5_1.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | let range = 'a' as u8 .. 'z' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/3_1.rs:82:60 [INFO] [stderr] | [INFO] [stderr] 82 | let count_of_overlaps = claim_map.values().filter(|&c| c >= &2).count(); [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bin/7_1.rs:5:51 [INFO] [stderr] | [INFO] [stderr] 5 | fn part1(mut steps: HashMap>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/7_1.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return task_name as i32 - 'A' as i32 + 61; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `task_name as i32 - 'A' as i32 + 61` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bin/7_1.rs:45:51 [INFO] [stderr] | [INFO] [stderr] 45 | fn part2(mut steps: HashMap>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/8.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | if node.children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `node.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bin/7_1.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / loop { [INFO] [stderr] 8 | | match take_task(&mut steps) { [INFO] [stderr] 9 | | Some(step) => { [INFO] [stderr] 10 | | steps_ordered.push(step); [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(step) = take_task(&mut steps) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/4_1.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | let max_minute = max_minutes.get(&max_sum_guard_id).unwrap().0 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&max_minutes[&max_sum_guard_id]` [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/7_1.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | steps.entry(target).or_insert(HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/7_1.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | steps.entry(dep).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/5_1.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / return data.chars().fold(String::new(), |mut res, new_char| { [INFO] [stderr] 6 | | match res.chars().last() { [INFO] [stderr] 7 | | Some(chr) => if chr != new_char && chr.eq_ignore_ascii_case(&new_char) { [INFO] [stderr] 8 | | res.pop(); [INFO] [stderr] ... | [INFO] [stderr] 14 | | res [INFO] [stderr] 15 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 5 | data.chars().fold(String::new(), |mut res, new_char| { [INFO] [stderr] 6 | match res.chars().last() { [INFO] [stderr] 7 | Some(chr) => if chr != new_char && chr.eq_ignore_ascii_case(&new_char) { [INFO] [stderr] 8 | res.pop(); [INFO] [stderr] 9 | return res [INFO] [stderr] 10 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/5_1.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | fn reduce(data: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/5_1.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | / match res.chars().last() { [INFO] [stderr] 7 | | Some(chr) => if chr != new_char && chr.eq_ignore_ascii_case(&new_char) { [INFO] [stderr] 8 | | res.pop(); [INFO] [stderr] 9 | | return res [INFO] [stderr] 10 | | }, [INFO] [stderr] 11 | | None => () [INFO] [stderr] 12 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | if let Some(chr) = res.chars().last() { if chr != new_char && chr.eq_ignore_ascii_case(&new_char) { [INFO] [stderr] 7 | res.pop(); [INFO] [stderr] 8 | return res [INFO] [stderr] 9 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/5_1.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let range = 'a' as u8 .. 'z' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/5_1.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | let range = 'a' as u8 .. 'z' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/6_1.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | fn find_bounding_box(points: &Vec) -> Rect { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.68s [INFO] running `"docker" "inspect" "f624485500553a96046f1fb2bee056dfcbb4e67113ca6bd2537a03c44a5590bd"` [INFO] running `"docker" "rm" "-f" "f624485500553a96046f1fb2bee056dfcbb4e67113ca6bd2537a03c44a5590bd"` [INFO] [stdout] f624485500553a96046f1fb2bee056dfcbb4e67113ca6bd2537a03c44a5590bd