[INFO] updating cached repository flammel/rustasata
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/flammel/rustasata
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/flammel/rustasata" "work/ex/clippy-test-run/sources/stable/gh/flammel/rustasata"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/flammel/rustasata'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/flammel/rustasata" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flammel/rustasata"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flammel/rustasata'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ef02642a60bda40deaa415b2b91f357230d853d3
[INFO] sha for GitHub repo flammel/rustasata: ef02642a60bda40deaa415b2b91f357230d853d3
[INFO] validating manifest of flammel/rustasata on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of flammel/rustasata on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing flammel/rustasata
[INFO] finished frobbing flammel/rustasata
[INFO] frobbed toml for flammel/rustasata written to work/ex/clippy-test-run/sources/stable/gh/flammel/rustasata/Cargo.toml
[INFO] started frobbing flammel/rustasata
[INFO] finished frobbing flammel/rustasata
[INFO] frobbed toml for flammel/rustasata written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flammel/rustasata/Cargo.toml
[INFO] crate flammel/rustasata has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting flammel/rustasata against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/flammel/rustasata:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] eee378c8ae58fed3a585715d90edd6db526b60755c4b254c8bdea3e58d06e32a
[INFO] running `"docker" "start" "-a" "eee378c8ae58fed3a585715d90edd6db526b60755c4b254c8bdea3e58d06e32a"`
[INFO] [stderr]     Checking indexmap v0.4.1
[INFO] [stderr]     Checking fern v0.5.6
[INFO] [stderr]     Checking criterion-plot v0.2.5
[INFO] [stderr]     Checking itertools-num v0.1.2
[INFO] [stderr]     Checking criterion-stats v0.2.5
[INFO] [stderr]     Checking serde_json v1.0.26
[INFO] [stderr]     Checking csv v1.0.1
[INFO] [stderr]     Checking chrono v0.4.6
[INFO] [stderr]    Compiling serde_derive v1.0.76
[INFO] [stderr]     Checking priority-queue v0.5.2
[INFO] [stderr]     Checking rustasata v0.1.0 (/opt/crater/workdir)
[INFO] [stderr]     Checking handlebars v0.32.4
[INFO] [stderr]     Checking simplelog v0.5.2
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:44:42
[INFO] [stderr]    |
[INFO] [stderr] 44 |     pub fn propagate(&mut self, literal: &Literal, assigns: &VecMap<bool>) -> WatchedUpdate {
[INFO] [stderr]    |                                          ^^^^^^^^ help: consider passing by value instead: `Literal`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/decision_provider.rs:32:21
[INFO] [stderr]    |
[INFO] [stderr] 32 |     fn new(literal: &Literal) -> VariablePriority {
[INFO] [stderr]    |                     ^^^^^^^^ help: consider passing by value instead: `Literal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/decision_provider.rs:41:28
[INFO] [stderr]    |
[INFO] [stderr] 41 |     fn occ(&self, literal: &Literal) -> VariablePriority {
[INFO] [stderr]    |                            ^^^^^^^^ help: consider passing by value instead: `Literal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/decision_provider.rs:83:44
[INFO] [stderr]    |
[INFO] [stderr] 83 |     pub fn new_clause(&mut self, literals: &Vec<Literal>) {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^ help: change this to: `&[Literal]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:23:21
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn new(num: &i64) -> Literal {
[INFO] [stderr]    |                     ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:27:18
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn index(&self) -> usize {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |     pub fn sign(&self) -> bool {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:39:16
[INFO] [stderr]    |
[INFO] [stderr] 39 |     pub fn var(&self) -> VariableName {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:43:25
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn falsified_by(&self, var_val: Option<&bool>) -> bool {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:50:25
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn satisfied_by(&self, var_val: Option<&bool>) -> bool {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/parser.rs:18:16
[INFO] [stderr]    |
[INFO] [stderr] 18 |           if let Ok(_) = file.read_to_string(&mut contents) {
[INFO] [stderr]    |  _________-      ^^^^^
[INFO] [stderr] 19 | |             parse(contents.as_str())
[INFO] [stderr] 20 | |         } else {
[INFO] [stderr] 21 | |             Err(DimacsError("Could not read file"))
[INFO] [stderr] 22 | |         }
[INFO] [stderr]    | |_________- help: try this: `if file.read_to_string(&mut contents).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:33:31
[INFO] [stderr]    |
[INFO] [stderr] 33 |             !line.starts_with("p")
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `'p'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:34:38
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 && !line.starts_with("c")
[INFO] [stderr]    |                                      ^^^ help: try using a char instead: `'c'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:35:38
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 && !line.starts_with("%")
[INFO] [stderr]    |                                      ^^^ help: try using a char instead: `'%'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:36:38
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 && !line.starts_with("0")
[INFO] [stderr]    |                                      ^^^ help: try using a char instead: `'0'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/solver.rs:245:36
[INFO] [stderr]     |
[INFO] [stderr] 245 |             if let Some(clauses) = self.watches.get_mut((!unit).index()).map(|cs| cs.clone()) {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.watches.get_mut((!unit).index()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/solver.rs:294:12
[INFO] [stderr]     |
[INFO] [stderr] 294 |         if self.trail_lim.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.trail_lim.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/solver.rs:329:49
[INFO] [stderr]     |
[INFO] [stderr] 329 |     fn resolve(alits: &mut Vec<Literal>, blits: &Vec<Literal>, literal: Literal) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^ help: change this to: `&[Literal]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/solver.rs:342:27
[INFO] [stderr]     |
[INFO] [stderr] 342 |         learned_literals: &Vec<Literal>,
[INFO] [stderr]     |                           ^^^^^^^^^^^^^ help: change this to: `&[Literal]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/solver.rs:430:9
[INFO] [stderr]     |
[INFO] [stderr] 430 | /         if self.stats.conflicts > self.restart.2 && self.trail_lim.len() > 0 {
[INFO] [stderr] 431 | |             true
[INFO] [stderr] 432 | |         } else {
[INFO] [stderr] 433 | |             false
[INFO] [stderr] 434 | |         }
[INFO] [stderr]     | |_________^ help: you can reduce it to: `self.stats.conflicts > self.restart.2 && self.trail_lim.len() > 0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/solver.rs:430:53
[INFO] [stderr]     |
[INFO] [stderr] 430 |         if self.stats.conflicts > self.restart.2 && self.trail_lim.len() > 0 {
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.trail_lim.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Checking criterion v0.2.5
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:44:42
[INFO] [stderr]    |
[INFO] [stderr] 44 |     pub fn propagate(&mut self, literal: &Literal, assigns: &VecMap<bool>) -> WatchedUpdate {
[INFO] [stderr]    |                                          ^^^^^^^^ help: consider passing by value instead: `Literal`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/decision_provider.rs:32:21
[INFO] [stderr]    |
[INFO] [stderr] 32 |     fn new(literal: &Literal) -> VariablePriority {
[INFO] [stderr]    |                     ^^^^^^^^ help: consider passing by value instead: `Literal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/decision_provider.rs:41:28
[INFO] [stderr]    |
[INFO] [stderr] 41 |     fn occ(&self, literal: &Literal) -> VariablePriority {
[INFO] [stderr]    |                            ^^^^^^^^ help: consider passing by value instead: `Literal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/decision_provider.rs:83:44
[INFO] [stderr]    |
[INFO] [stderr] 83 |     pub fn new_clause(&mut self, literals: &Vec<Literal>) {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^ help: change this to: `&[Literal]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:23:21
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn new(num: &i64) -> Literal {
[INFO] [stderr]    |                     ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:27:18
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn index(&self) -> usize {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |     pub fn sign(&self) -> bool {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:39:16
[INFO] [stderr]    |
[INFO] [stderr] 39 |     pub fn var(&self) -> VariableName {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:43:25
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn falsified_by(&self, var_val: Option<&bool>) -> bool {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/literal.rs:50:25
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn satisfied_by(&self, var_val: Option<&bool>) -> bool {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/parser.rs:18:16
[INFO] [stderr]    |
[INFO] [stderr] 18 |           if let Ok(_) = file.read_to_string(&mut contents) {
[INFO] [stderr]    |  _________-      ^^^^^
[INFO] [stderr] 19 | |             parse(contents.as_str())
[INFO] [stderr] 20 | |         } else {
[INFO] [stderr] 21 | |             Err(DimacsError("Could not read file"))
[INFO] [stderr] 22 | |         }
[INFO] [stderr]    | |_________- help: try this: `if file.read_to_string(&mut contents).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:33:31
[INFO] [stderr]    |
[INFO] [stderr] 33 |             !line.starts_with("p")
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `'p'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:34:38
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 && !line.starts_with("c")
[INFO] [stderr]    |                                      ^^^ help: try using a char instead: `'c'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:35:38
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 && !line.starts_with("%")
[INFO] [stderr]    |                                      ^^^ help: try using a char instead: `'%'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:36:38
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 && !line.starts_with("0")
[INFO] [stderr]    |                                      ^^^ help: try using a char instead: `'0'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/solver.rs:245:36
[INFO] [stderr]     |
[INFO] [stderr] 245 |             if let Some(clauses) = self.watches.get_mut((!unit).index()).map(|cs| cs.clone()) {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.watches.get_mut((!unit).index()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/solver.rs:294:12
[INFO] [stderr]     |
[INFO] [stderr] 294 |         if self.trail_lim.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.trail_lim.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/solver.rs:329:49
[INFO] [stderr]     |
[INFO] [stderr] 329 |     fn resolve(alits: &mut Vec<Literal>, blits: &Vec<Literal>, literal: Literal) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^ help: change this to: `&[Literal]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/solver.rs:342:27
[INFO] [stderr]     |
[INFO] [stderr] 342 |         learned_literals: &Vec<Literal>,
[INFO] [stderr]     |                           ^^^^^^^^^^^^^ help: change this to: `&[Literal]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/solver.rs:430:9
[INFO] [stderr]     |
[INFO] [stderr] 430 | /         if self.stats.conflicts > self.restart.2 && self.trail_lim.len() > 0 {
[INFO] [stderr] 431 | |             true
[INFO] [stderr] 432 | |         } else {
[INFO] [stderr] 433 | |             false
[INFO] [stderr] 434 | |         }
[INFO] [stderr]     | |_________^ help: you can reduce it to: `self.stats.conflicts > self.restart.2 && self.trail_lim.len() > 0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/solver.rs:430:53
[INFO] [stderr]     |
[INFO] [stderr] 430 |         if self.stats.conflicts > self.restart.2 && self.trail_lim.len() > 0 {
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.trail_lim.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 28.52s
[INFO] running `"docker" "inspect" "eee378c8ae58fed3a585715d90edd6db526b60755c4b254c8bdea3e58d06e32a"`
[INFO] running `"docker" "rm" "-f" "eee378c8ae58fed3a585715d90edd6db526b60755c4b254c8bdea3e58d06e32a"`
[INFO] [stdout] eee378c8ae58fed3a585715d90edd6db526b60755c4b254c8bdea3e58d06e32a