[INFO] updating cached repository fitzgen/intrusive_splay_tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fitzgen/intrusive_splay_tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fitzgen/intrusive_splay_tree" "work/ex/clippy-test-run/sources/stable/gh/fitzgen/intrusive_splay_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fitzgen/intrusive_splay_tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fitzgen/intrusive_splay_tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fitzgen/intrusive_splay_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fitzgen/intrusive_splay_tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ca672e9d03d8d1afc0d246a98cf82e2a28f833ec [INFO] sha for GitHub repo fitzgen/intrusive_splay_tree: ca672e9d03d8d1afc0d246a98cf82e2a28f833ec [INFO] validating manifest of fitzgen/intrusive_splay_tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fitzgen/intrusive_splay_tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fitzgen/intrusive_splay_tree [INFO] finished frobbing fitzgen/intrusive_splay_tree [INFO] frobbed toml for fitzgen/intrusive_splay_tree written to work/ex/clippy-test-run/sources/stable/gh/fitzgen/intrusive_splay_tree/Cargo.toml [INFO] started frobbing fitzgen/intrusive_splay_tree [INFO] finished frobbing fitzgen/intrusive_splay_tree [INFO] frobbed toml for fitzgen/intrusive_splay_tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fitzgen/intrusive_splay_tree/Cargo.toml [INFO] crate fitzgen/intrusive_splay_tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fitzgen/intrusive_splay_tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fitzgen/intrusive_splay_tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0651a18628e121c3fc773d5c720237b9e74429ac8faf8ec871b908b4e8717225 [INFO] running `"docker" "start" "-a" "0651a18628e121c3fc773d5c720237b9e74429ac8faf8ec871b908b4e8717225"` [INFO] [stderr] Checking typed-arena v1.3.0 [INFO] [stderr] Checking intrusive_splay_tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking env_logger v0.5.6 [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/internal.rs:83:30 [INFO] [stderr] | [INFO] [stderr] 83 | self.root = Some(node.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/internal.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / if self.root.is_none() { [INFO] [stderr] 114 | | return None; [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.root?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] Checking quickcheck v0.6.2 [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const single::Single<'_>`) [INFO] [stderr] --> tests/single.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | let elem = node.offset(-(offset as isize)) as *const Self::Elem; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `intrusive_splay_tree`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Single<'_>`) [INFO] [stderr] --> tests/single.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | let elem = node.offset(-(offset as isize)) as *const Self::Elem; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `intrusive_splay_tree`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/internal.rs:83:30 [INFO] [stderr] | [INFO] [stderr] 83 | self.root = Some(node.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/internal.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / if self.root.is_none() { [INFO] [stderr] 114 | | return None; [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.root?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const single::Single<'_>`) [INFO] [stderr] --> tests/single.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | let elem = node.offset(-(offset as isize)) as *const Self::Elem; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/quickcheck.rs:22:56 [INFO] [stderr] | [INFO] [stderr] 22 | let xs = arena.alloc_extend(xs.into_iter().map(|x| Single::new(x))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Single::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/quickcheck.rs:37:56 [INFO] [stderr] | [INFO] [stderr] 37 | let xs = arena.alloc_extend(xs.into_iter().map(|x| Single::new(x))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Single::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/quickcheck.rs:52:56 [INFO] [stderr] | [INFO] [stderr] 52 | let xs = arena.alloc_extend(xs.into_iter().map(|x| Single::new(x))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Single::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Multiple<'_>`) [INFO] [stderr] --> tests/quickcheck.rs:81:1 [INFO] [stderr] | [INFO] [stderr] 81 | / impl_intrusive_node! { [INFO] [stderr] 82 | | impl<'a> IntrusiveNode<'a> for ByX<'a> [INFO] [stderr] 83 | | where [INFO] [stderr] 84 | | type Elem = Multiple<'a>, [INFO] [stderr] 85 | | node = by_x; [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Multiple<'_>`) [INFO] [stderr] --> tests/quickcheck.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | let elem = node.offset(-(offset as isize)) as *const Self::Elem; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `intrusive_splay_tree`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0651a18628e121c3fc773d5c720237b9e74429ac8faf8ec871b908b4e8717225"` [INFO] running `"docker" "rm" "-f" "0651a18628e121c3fc773d5c720237b9e74429ac8faf8ec871b908b4e8717225"` [INFO] [stdout] 0651a18628e121c3fc773d5c720237b9e74429ac8faf8ec871b908b4e8717225