[INFO] updating cached repository firefox7025/ImageSorter
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/firefox7025/ImageSorter
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/firefox7025/ImageSorter" "work/ex/clippy-test-run/sources/stable/gh/firefox7025/ImageSorter"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/firefox7025/ImageSorter'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/firefox7025/ImageSorter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/firefox7025/ImageSorter"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/firefox7025/ImageSorter'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d551cd493613fd0acedda144da83bb53127af8e9
[INFO] sha for GitHub repo firefox7025/ImageSorter: d551cd493613fd0acedda144da83bb53127af8e9
[INFO] validating manifest of firefox7025/ImageSorter on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of firefox7025/ImageSorter on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing firefox7025/ImageSorter
[INFO] finished frobbing firefox7025/ImageSorter
[INFO] frobbed toml for firefox7025/ImageSorter written to work/ex/clippy-test-run/sources/stable/gh/firefox7025/ImageSorter/Cargo.toml
[INFO] started frobbing firefox7025/ImageSorter
[INFO] finished frobbing firefox7025/ImageSorter
[INFO] frobbed toml for firefox7025/ImageSorter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/firefox7025/ImageSorter/Cargo.toml
[INFO] crate firefox7025/ImageSorter has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting firefox7025/ImageSorter against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/firefox7025/ImageSorter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e64f286d7f0bb1e2c829784641db42923c881fe52ac1945b8d63026f5de1a4d7
[INFO] running `"docker" "start" "-a" "e64f286d7f0bb1e2c829784641db42923c881fe52ac1945b8d63026f5de1a4d7"`
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]    Compiling num-derive v0.2.2
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking rayon-core v1.4.1
[INFO] [stderr]     Checking rayon v1.0.2
[INFO] [stderr]     Checking jpeg-decoder v0.1.15
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking img_hash v2.1.0
[INFO] [stderr]     Checking image_sorter v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/findimages.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return images;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `images`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hashimages.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return hash1;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `hash1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hashimages.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return (image1.dist_ratio(image2) * 100 as f32) as i32;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(image1.dist_ratio(image2) * 100 as f32) as i32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/findimages.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return images;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `images`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hashimages.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return hash1;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `hash1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hashimages.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return (image1.dist_ratio(image2) * 100 as f32) as i32;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(image1.dist_ratio(image2) * 100 as f32) as i32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `x`
[INFO] [stderr]    --> src/main.rs:109:27
[INFO] [stderr]     |
[INFO] [stderr] 109 |             .min_by_key(|(x, y)| hashimages::image_diff(val, y)).unwrap();
[INFO] [stderr]     |                           ^ help: consider using `_x` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dist_ratio`
[INFO] [stderr]   --> src/main.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |     let dist_ratio = matches.value_of("Similarity").unwrap_or("20");
[INFO] [stderr]    |         ^^^^^^^^^^ help: consider using `_dist_ratio` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable `output_directory` is assigned to, but never used
[INFO] [stderr]   --> src/main.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let output_directory;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: consider using `_output_directory` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `output_directory` is never read
[INFO] [stderr]   --> src/main.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             output_directory = path;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `x`
[INFO] [stderr]    --> src/main.rs:109:27
[INFO] [stderr]     |
[INFO] [stderr] 109 |             .min_by_key(|(x, y)| hashimages::image_diff(val, y)).unwrap();
[INFO] [stderr]     |                           ^ help: consider using `_x` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dist_ratio`
[INFO] [stderr]   --> src/main.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |     let dist_ratio = matches.value_of("Similarity").unwrap_or("20");
[INFO] [stderr]    |         ^^^^^^^^^^ help: consider using `_dist_ratio` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable `output_directory` is assigned to, but never used
[INFO] [stderr]   --> src/main.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let output_directory;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: consider using `_output_directory` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `output_directory` is never read
[INFO] [stderr]   --> src/main.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             output_directory = path;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/findimages.rs:34:21
[INFO] [stderr]    |
[INFO] [stderr] 34 |                     ();
[INFO] [stderr]    |                     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/findimages.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     ();
[INFO] [stderr]    |                     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let output_directory =`
[INFO] [stderr]   --> src/main.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let output_directory;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/main.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             ();
[INFO] [stderr]    |             ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/findimages.rs:34:21
[INFO] [stderr]    |
[INFO] [stderr] 34 |                     ();
[INFO] [stderr]    |                     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/findimages.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     ();
[INFO] [stderr]    |                     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let output_directory =`
[INFO] [stderr]   --> src/main.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let output_directory;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/main.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             ();
[INFO] [stderr]    |             ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 20.81s
[INFO] running `"docker" "inspect" "e64f286d7f0bb1e2c829784641db42923c881fe52ac1945b8d63026f5de1a4d7"`
[INFO] running `"docker" "rm" "-f" "e64f286d7f0bb1e2c829784641db42923c881fe52ac1945b8d63026f5de1a4d7"`
[INFO] [stdout] e64f286d7f0bb1e2c829784641db42923c881fe52ac1945b8d63026f5de1a4d7