[INFO] updating cached repository firba1/tpol-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/firba1/tpol-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/firba1/tpol-rs" "work/ex/clippy-test-run/sources/stable/gh/firba1/tpol-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/firba1/tpol-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/firba1/tpol-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/firba1/tpol-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/firba1/tpol-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 28dddb6ce86477e06cdb94ee3678bdb01946b9fb [INFO] sha for GitHub repo firba1/tpol-rs: 28dddb6ce86477e06cdb94ee3678bdb01946b9fb [INFO] validating manifest of firba1/tpol-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of firba1/tpol-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing firba1/tpol-rs [INFO] finished frobbing firba1/tpol-rs [INFO] frobbed toml for firba1/tpol-rs written to work/ex/clippy-test-run/sources/stable/gh/firba1/tpol-rs/Cargo.toml [INFO] started frobbing firba1/tpol-rs [INFO] finished frobbing firba1/tpol-rs [INFO] frobbed toml for firba1/tpol-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/firba1/tpol-rs/Cargo.toml [INFO] crate firba1/tpol-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting firba1/tpol-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/firba1/tpol-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8eeda30e7ca05d4ff207b1d51a7d178cb2018c9d0bba2d8fd06bd1a634aa0e8 [INFO] running `"docker" "start" "-a" "e8eeda30e7ca05d4ff207b1d51a7d178cb2018c9d0bba2d8fd06bd1a634aa0e8"` [INFO] [stderr] Checking tpol v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:70:67 [INFO] [stderr] | [INFO] [stderr] 70 | let (history_file_option, prompts_config_path_option) = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:70:67 [INFO] [stderr] | [INFO] [stderr] 70 | let (history_file_option, prompts_config_path_option) = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:21:43 [INFO] [stderr] | [INFO] [stderr] 21 | let words: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | let last_word = words.iter().nth(words.len()-1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:57:61 [INFO] [stderr] | [INFO] [stderr] 57 | let completions: Vec = completion_str.split("\n").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | / File::open(prompts_config_path) [INFO] [stderr] 114 | | .map(|file| { [INFO] [stderr] 115 | | let prompts_config: HashMap = serde_json::from_reader(file) [INFO] [stderr] 116 | | .unwrap_or(HashMap::new()); [INFO] [stderr] 117 | | prompts_config [INFO] [stderr] 118 | | }) [INFO] [stderr] 119 | | .unwrap_or(HashMap::new()) [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | File::open(prompts_config_path) [INFO] [stderr] 114 | .map(|file| { [INFO] [stderr] 115 | let prompts_config: HashMap = serde_json::from_reader(file) [INFO] [stderr] 116 | .unwrap_or(HashMap::new()); [INFO] [stderr] 117 | prompts_config [INFO] [stderr] 118 | }).unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:115:67 [INFO] [stderr] | [INFO] [stderr] 115 | let prompts_config: HashMap = serde_json::from_reader(file) [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 116 | | .unwrap_or(HashMap::new()); [INFO] [stderr] | |__________________________________________________^ help: try this: `serde_json::from_reader(file).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:146:59 [INFO] [stderr] | [INFO] [stderr] 146 | let mut command = if line.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:147:48 [INFO] [stderr] | [INFO] [stderr] 147 | let parts = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:156:56 [INFO] [stderr] | [INFO] [stderr] 156 | command.args(line.trim().split(" ").collect::>()); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:21:43 [INFO] [stderr] | [INFO] [stderr] 21 | let words: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | let last_word = words.iter().nth(words.len()-1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:57:61 [INFO] [stderr] | [INFO] [stderr] 57 | let completions: Vec = completion_str.split("\n").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | / File::open(prompts_config_path) [INFO] [stderr] 114 | | .map(|file| { [INFO] [stderr] 115 | | let prompts_config: HashMap = serde_json::from_reader(file) [INFO] [stderr] 116 | | .unwrap_or(HashMap::new()); [INFO] [stderr] 117 | | prompts_config [INFO] [stderr] 118 | | }) [INFO] [stderr] 119 | | .unwrap_or(HashMap::new()) [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | File::open(prompts_config_path) [INFO] [stderr] 114 | .map(|file| { [INFO] [stderr] 115 | let prompts_config: HashMap = serde_json::from_reader(file) [INFO] [stderr] 116 | .unwrap_or(HashMap::new()); [INFO] [stderr] 117 | prompts_config [INFO] [stderr] 118 | }).unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:115:67 [INFO] [stderr] | [INFO] [stderr] 115 | let prompts_config: HashMap = serde_json::from_reader(file) [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 116 | | .unwrap_or(HashMap::new()); [INFO] [stderr] | |__________________________________________________^ help: try this: `serde_json::from_reader(file).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:146:59 [INFO] [stderr] | [INFO] [stderr] 146 | let mut command = if line.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:147:48 [INFO] [stderr] | [INFO] [stderr] 147 | let parts = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:156:56 [INFO] [stderr] | [INFO] [stderr] 156 | command.args(line.trim().split(" ").collect::>()); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "e8eeda30e7ca05d4ff207b1d51a7d178cb2018c9d0bba2d8fd06bd1a634aa0e8"` [INFO] running `"docker" "rm" "-f" "e8eeda30e7ca05d4ff207b1d51a7d178cb2018c9d0bba2d8fd06bd1a634aa0e8"` [INFO] [stdout] e8eeda30e7ca05d4ff207b1d51a7d178cb2018c9d0bba2d8fd06bd1a634aa0e8