[INFO] updating cached repository ficoos/sdfgen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ficoos/sdfgen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ficoos/sdfgen" "work/ex/clippy-test-run/sources/stable/gh/ficoos/sdfgen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ficoos/sdfgen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ficoos/sdfgen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ficoos/sdfgen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ficoos/sdfgen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 85a577aa8f948d441de3d8d7cb4f913646adc2d8 [INFO] sha for GitHub repo ficoos/sdfgen: 85a577aa8f948d441de3d8d7cb4f913646adc2d8 [INFO] validating manifest of ficoos/sdfgen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ficoos/sdfgen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ficoos/sdfgen [INFO] finished frobbing ficoos/sdfgen [INFO] frobbed toml for ficoos/sdfgen written to work/ex/clippy-test-run/sources/stable/gh/ficoos/sdfgen/Cargo.toml [INFO] started frobbing ficoos/sdfgen [INFO] finished frobbing ficoos/sdfgen [INFO] frobbed toml for ficoos/sdfgen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ficoos/sdfgen/Cargo.toml [INFO] crate ficoos/sdfgen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ficoos/sdfgen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ficoos/sdfgen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 819aac61ee12c49e789bcbdd08b6d4012e81de27df662e426262262c2c9895a7 [INFO] running `"docker" "start" "-a" "819aac61ee12c49e789bcbdd08b6d4012e81de27df662e426262262c2c9895a7"` [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking sdf_gen v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return xdiff * xdiff + ydiff * ydiff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xdiff * xdiff + ydiff * ydiff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return luma > 250; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `luma > 250` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return bitmap; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return target_image; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `target_image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | let rad = spread as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(spread)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / let mut bx = 0; [INFO] [stderr] 52 | | if x > rad { [INFO] [stderr] 53 | | bx = x - rad; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let bx = if x > rad { x - rad } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut by = 0; [INFO] [stderr] 57 | | if y > rad { [INFO] [stderr] 58 | | by = y - rad; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let by = if y > rad { y - rad } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | let norm_dist = ((sdist / (spread as f32)) * 128f32 + 127.5f32) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(spread)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / let mut spread = 16u8; [INFO] [stderr] 93 | | if args.len() > 2 { [INFO] [stderr] 94 | | spread = args[2].parse::().unwrap(); [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let spread = if args.len() > 2 { args[2].parse::().unwrap() } else { 16u8 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let ref mut fout = File::create(&Path::new("sdf.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------ help: try: `let fout = &mut File::create(&Path::new("sdf.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return xdiff * xdiff + ydiff * ydiff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xdiff * xdiff + ydiff * ydiff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return luma > 250; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `luma > 250` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return bitmap; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return target_image; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `target_image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | let rad = spread as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(spread)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / let mut bx = 0; [INFO] [stderr] 52 | | if x > rad { [INFO] [stderr] 53 | | bx = x - rad; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let bx = if x > rad { x - rad } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut by = 0; [INFO] [stderr] 57 | | if y > rad { [INFO] [stderr] 58 | | by = y - rad; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let by = if y > rad { y - rad } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | let norm_dist = ((sdist / (spread as f32)) * 128f32 + 127.5f32) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(spread)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / let mut spread = 16u8; [INFO] [stderr] 93 | | if args.len() > 2 { [INFO] [stderr] 94 | | spread = args[2].parse::().unwrap(); [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let spread = if args.len() > 2 { args[2].parse::().unwrap() } else { 16u8 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let ref mut fout = File::create(&Path::new("sdf.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------ help: try: `let fout = &mut File::create(&Path::new("sdf.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.43s [INFO] running `"docker" "inspect" "819aac61ee12c49e789bcbdd08b6d4012e81de27df662e426262262c2c9895a7"` [INFO] running `"docker" "rm" "-f" "819aac61ee12c49e789bcbdd08b6d4012e81de27df662e426262262c2c9895a7"` [INFO] [stdout] 819aac61ee12c49e789bcbdd08b6d4012e81de27df662e426262262c2c9895a7