[INFO] updating cached repository ficoos/roll
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ficoos/roll
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ficoos/roll" "work/ex/clippy-test-run/sources/stable/gh/ficoos/roll"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ficoos/roll'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ficoos/roll" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ficoos/roll"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ficoos/roll'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d7d320663191b72a99cc1aaa8b920c4bdf0869a8
[INFO] sha for GitHub repo ficoos/roll: d7d320663191b72a99cc1aaa8b920c4bdf0869a8
[INFO] validating manifest of ficoos/roll on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ficoos/roll on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ficoos/roll
[INFO] finished frobbing ficoos/roll
[INFO] frobbed toml for ficoos/roll written to work/ex/clippy-test-run/sources/stable/gh/ficoos/roll/Cargo.toml
[INFO] started frobbing ficoos/roll
[INFO] finished frobbing ficoos/roll
[INFO] frobbed toml for ficoos/roll written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ficoos/roll/Cargo.toml
[INFO] crate ficoos/roll has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ficoos/roll against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ficoos/roll:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 95cb50354ddbf31eb0191c4fd93a2f2c3b4d2c778d61bbcd99ec2c5913a3c718
[INFO] running `"docker" "start" "-a" "95cb50354ddbf31eb0191c4fd93a2f2c3b4d2c778d61bbcd99ec2c5913a3c718"`
[INFO] [stderr]     Checking roll v2.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:152:60
[INFO] [stderr]     |
[INFO] [stderr] 152 |                         '+' => Box::new(Add { lhs: result, rhs: rhs }),
[INFO] [stderr]     |                                                            ^^^^^^^^ help: replace it with: `rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:153:65
[INFO] [stderr]     |
[INFO] [stderr] 153 |                         '-' => Box::new(Subtract { lhs: result, rhs: rhs }),
[INFO] [stderr]     |                                                                 ^^^^^^^^ help: replace it with: `rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:152:60
[INFO] [stderr]     |
[INFO] [stderr] 152 |                         '+' => Box::new(Add { lhs: result, rhs: rhs }),
[INFO] [stderr]     |                                                            ^^^^^^^^ help: replace it with: `rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:153:65
[INFO] [stderr]     |
[INFO] [stderr] 153 |                         '-' => Box::new(Subtract { lhs: result, rhs: rhs }),
[INFO] [stderr]     |                                                                 ^^^^^^^^ help: replace it with: `rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return sum as i32;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum as i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:75:9
[INFO] [stderr]    |
[INFO] [stderr] 75 |         return self.value;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     return if nums_found { result } else { default };
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if nums_found { result } else { default }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:127:5
[INFO] [stderr]     |
[INFO] [stderr] 127 |     return Some(Box::new(Scalar{ value: die_count as i32 }));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Box::new(Scalar{ value: die_count as i32 }))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:168:5
[INFO] [stderr]     |
[INFO] [stderr] 168 |     return Ok(result);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return sum as i32;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum as i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:75:9
[INFO] [stderr]    |
[INFO] [stderr] 75 |         return self.value;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     return if nums_found { result } else { default };
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if nums_found { result } else { default }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:127:5
[INFO] [stderr]     |
[INFO] [stderr] 127 |     return Some(Box::new(Scalar{ value: die_count as i32 }));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Box::new(Scalar{ value: die_count as i32 }))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:168:5
[INFO] [stderr]     |
[INFO] [stderr] 168 |     return Ok(result);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:111:5
[INFO] [stderr]     |
[INFO] [stderr] 111 | /     match chars.peek() {
[INFO] [stderr] 112 | |         Some(&'d') => {
[INFO] [stderr] 113 | |             chars.next();
[INFO] [stderr] 114 | |             let sides_count = read_u32(chars, 6);
[INFO] [stderr] ...   |
[INFO] [stderr] 124 | |         _ => {},
[INFO] [stderr] 125 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 111 |     if let Some(&'d') = chars.peek() {
[INFO] [stderr] 112 |     chars.next();
[INFO] [stderr] 113 |     let sides_count = read_u32(chars, 6);
[INFO] [stderr] 114 |     if die_count == 0 {
[INFO] [stderr] 115 |         return None;
[INFO] [stderr] 116 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:173:5
[INFO] [stderr]     |
[INFO] [stderr] 173 | /     let request: String;
[INFO] [stderr] 174 | |     if std::env::args().len() == 1 {
[INFO] [stderr] 175 | |         // Default roll
[INFO] [stderr] 176 | |         request = String::from("d");
[INFO] [stderr] 177 | |     } else {
[INFO] [stderr] 178 | |         request = std::env::args().skip(1).collect::<Vec<String>>().join(" ");
[INFO] [stderr] 179 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let request = if std::env::args().len() == 1 { String::from("d") } else { std::env::args().skip(1).collect::<Vec<String>>().join(" ") };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:111:5
[INFO] [stderr]     |
[INFO] [stderr] 111 | /     match chars.peek() {
[INFO] [stderr] 112 | |         Some(&'d') => {
[INFO] [stderr] 113 | |             chars.next();
[INFO] [stderr] 114 | |             let sides_count = read_u32(chars, 6);
[INFO] [stderr] ...   |
[INFO] [stderr] 124 | |         _ => {},
[INFO] [stderr] 125 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 111 |     if let Some(&'d') = chars.peek() {
[INFO] [stderr] 112 |     chars.next();
[INFO] [stderr] 113 |     let sides_count = read_u32(chars, 6);
[INFO] [stderr] 114 |     if die_count == 0 {
[INFO] [stderr] 115 |         return None;
[INFO] [stderr] 116 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:173:5
[INFO] [stderr]     |
[INFO] [stderr] 173 | /     let request: String;
[INFO] [stderr] 174 | |     if std::env::args().len() == 1 {
[INFO] [stderr] 175 | |         // Default roll
[INFO] [stderr] 176 | |         request = String::from("d");
[INFO] [stderr] 177 | |     } else {
[INFO] [stderr] 178 | |         request = std::env::args().skip(1).collect::<Vec<String>>().join(" ");
[INFO] [stderr] 179 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let request = if std::env::args().len() == 1 { String::from("d") } else { std::env::args().skip(1).collect::<Vec<String>>().join(" ") };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/main.rs:205:11
[INFO] [stderr]     |
[INFO] [stderr] 205 |         ].into_iter() {
[INFO] [stderr]     |           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `roll`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "95cb50354ddbf31eb0191c4fd93a2f2c3b4d2c778d61bbcd99ec2c5913a3c718"`
[INFO] running `"docker" "rm" "-f" "95cb50354ddbf31eb0191c4fd93a2f2c3b4d2c778d61bbcd99ec2c5913a3c718"`
[INFO] [stdout] 95cb50354ddbf31eb0191c4fd93a2f2c3b4d2c778d61bbcd99ec2c5913a3c718