[INFO] updating cached repository fichtknick/livelog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fichtknick/livelog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fichtknick/livelog" "work/ex/clippy-test-run/sources/stable/gh/fichtknick/livelog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fichtknick/livelog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fichtknick/livelog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fichtknick/livelog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fichtknick/livelog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a2f180fafbbeb060bc580934ecd364d7ce860bdb [INFO] sha for GitHub repo fichtknick/livelog: a2f180fafbbeb060bc580934ecd364d7ce860bdb [INFO] validating manifest of fichtknick/livelog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fichtknick/livelog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fichtknick/livelog [INFO] finished frobbing fichtknick/livelog [INFO] frobbed toml for fichtknick/livelog written to work/ex/clippy-test-run/sources/stable/gh/fichtknick/livelog/Cargo.toml [INFO] started frobbing fichtknick/livelog [INFO] finished frobbing fichtknick/livelog [INFO] frobbed toml for fichtknick/livelog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fichtknick/livelog/Cargo.toml [INFO] crate fichtknick/livelog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fichtknick/livelog against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fichtknick/livelog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2dda7fdf3988af936573bf9cf7e7e56ae4ab4c8c77004905df2d0402e3b4692d [INFO] running `"docker" "start" "-a" "2dda7fdf3988af936573bf9cf7e7e56ae4ab4c8c77004905df2d0402e3b4692d"` [INFO] [stderr] Checking livelog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | Ok(f) => return f, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let mut logfile = init_file(&env::args().nth(1)); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | content = String::from(content1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `content1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | Ok(f) => return f, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let mut logfile = init_file(&env::args().nth(1)); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | content = String::from(content1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `content1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "2dda7fdf3988af936573bf9cf7e7e56ae4ab4c8c77004905df2d0402e3b4692d"` [INFO] running `"docker" "rm" "-f" "2dda7fdf3988af936573bf9cf7e7e56ae4ab4c8c77004905df2d0402e3b4692d"` [INFO] [stdout] 2dda7fdf3988af936573bf9cf7e7e56ae4ab4c8c77004905df2d0402e3b4692d