[INFO] updating cached repository fhaynes/palladium [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fhaynes/palladium [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fhaynes/palladium" "work/ex/clippy-test-run/sources/stable/gh/fhaynes/palladium"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fhaynes/palladium'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fhaynes/palladium" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fhaynes/palladium"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fhaynes/palladium'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8b0a1413dacd1b1fe4de7a8e2733dbca892cc213 [INFO] sha for GitHub repo fhaynes/palladium: 8b0a1413dacd1b1fe4de7a8e2733dbca892cc213 [INFO] validating manifest of fhaynes/palladium on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fhaynes/palladium on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fhaynes/palladium [INFO] finished frobbing fhaynes/palladium [INFO] frobbed toml for fhaynes/palladium written to work/ex/clippy-test-run/sources/stable/gh/fhaynes/palladium/Cargo.toml [INFO] started frobbing fhaynes/palladium [INFO] finished frobbing fhaynes/palladium [INFO] frobbed toml for fhaynes/palladium written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fhaynes/palladium/Cargo.toml [INFO] crate fhaynes/palladium has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fhaynes/palladium against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fhaynes/palladium:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3fab237f0bc0d94ddc720b666389806287e6fa3d3ee116229f6875dd45ef5940 [INFO] running `"docker" "start" "-a" "3fab237f0bc0d94ddc720b666389806287e6fa3d3ee116229f6875dd45ef5940"` [INFO] [stderr] Checking uuid v0.7.0 [INFO] [stderr] Checking iridium v0.0.33 [INFO] [stderr] Checking palladium v0.0.26 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | free_registers: free_registers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `free_registers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | free_registers: free_registers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `free_registers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/visitor.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match node { [INFO] [stderr] 68 | | &Token::AdditionOperator => { [INFO] [stderr] 69 | | // TODO: Need to clean this up. Remove the unwraps. [INFO] [stderr] 70 | | let result_register = self.free_registers.pop().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 161 | | }, [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *node { [INFO] [stderr] 68 | Token::AdditionOperator => { [INFO] [stderr] 69 | // TODO: Need to clean this up. Remove the unwraps. [INFO] [stderr] 70 | let result_register = self.free_registers.pop().unwrap(); [INFO] [stderr] 71 | let left_register = self.used_registers.pop().unwrap(); [INFO] [stderr] 72 | let right_register = self.used_registers.pop().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/visitor.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match node { [INFO] [stderr] 68 | | &Token::AdditionOperator => { [INFO] [stderr] 69 | | // TODO: Need to clean this up. Remove the unwraps. [INFO] [stderr] 70 | | let result_register = self.free_registers.pop().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 161 | | }, [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *node { [INFO] [stderr] 68 | Token::AdditionOperator => { [INFO] [stderr] 69 | // TODO: Need to clean this up. Remove the unwraps. [INFO] [stderr] 70 | let result_register = self.free_registers.pop().unwrap(); [INFO] [stderr] 71 | let left_register = self.used_registers.pop().unwrap(); [INFO] [stderr] 72 | let right_register = self.used_registers.pop().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.77s [INFO] running `"docker" "inspect" "3fab237f0bc0d94ddc720b666389806287e6fa3d3ee116229f6875dd45ef5940"` [INFO] running `"docker" "rm" "-f" "3fab237f0bc0d94ddc720b666389806287e6fa3d3ee116229f6875dd45ef5940"` [INFO] [stdout] 3fab237f0bc0d94ddc720b666389806287e6fa3d3ee116229f6875dd45ef5940