[INFO] updating cached repository ffleming/shrimpy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ffleming/shrimpy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ffleming/shrimpy" "work/ex/clippy-test-run/sources/stable/gh/ffleming/shrimpy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ffleming/shrimpy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ffleming/shrimpy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ffleming/shrimpy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ffleming/shrimpy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a81c2efb2fbc757fcc6ffe33fe38e6a1ed5d675f [INFO] sha for GitHub repo ffleming/shrimpy: a81c2efb2fbc757fcc6ffe33fe38e6a1ed5d675f [INFO] validating manifest of ffleming/shrimpy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ffleming/shrimpy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ffleming/shrimpy [INFO] finished frobbing ffleming/shrimpy [INFO] frobbed toml for ffleming/shrimpy written to work/ex/clippy-test-run/sources/stable/gh/ffleming/shrimpy/Cargo.toml [INFO] started frobbing ffleming/shrimpy [INFO] finished frobbing ffleming/shrimpy [INFO] frobbed toml for ffleming/shrimpy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ffleming/shrimpy/Cargo.toml [INFO] crate ffleming/shrimpy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ffleming/shrimpy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ffleming/shrimpy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a9f7c6d9b9ffa92b6467382b3ac4eb51ac94914c29ae743e8e4d37f92a686267 [INFO] running `"docker" "start" "-a" "a9f7c6d9b9ffa92b6467382b3ac4eb51ac94914c29ae743e8e4d37f92a686267"` [INFO] [stderr] Checking shrimpy v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/response.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / return Ok(HttpResponse { [INFO] [stderr] 17 | | code: code, [INFO] [stderr] 18 | | code_mnemonic: String::from("OK"), [INFO] [stderr] 19 | | http_version: http_version.clone(), [INFO] [stderr] 20 | | headers: HashMap::new(), [INFO] [stderr] 21 | | body: body_string.clone() [INFO] [stderr] 22 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Ok(HttpResponse { [INFO] [stderr] 17 | code: code, [INFO] [stderr] 18 | code_mnemonic: String::from("OK"), [INFO] [stderr] 19 | http_version: http_version.clone(), [INFO] [stderr] 20 | headers: HashMap::new(), [INFO] [stderr] 21 | body: body_string.clone() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/response.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / return Ok(HttpResponse { [INFO] [stderr] 17 | | code: code, [INFO] [stderr] 18 | | code_mnemonic: String::from("OK"), [INFO] [stderr] 19 | | http_version: http_version.clone(), [INFO] [stderr] 20 | | headers: HashMap::new(), [INFO] [stderr] 21 | | body: body_string.clone() [INFO] [stderr] 22 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Ok(HttpResponse { [INFO] [stderr] 17 | code: code, [INFO] [stderr] 18 | code_mnemonic: String::from("OK"), [INFO] [stderr] 19 | http_version: http_version.clone(), [INFO] [stderr] 20 | headers: HashMap::new(), [INFO] [stderr] 21 | body: body_string.clone() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http/request.rs:16:43 [INFO] [stderr] | [INFO] [stderr] 16 | let mut request_i = request.split("\n").map(|l| l.trim() ); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http/request.rs:24:59 [INFO] [stderr] | [INFO] [stderr] 24 | let request_parts: Vec<&str> = request_line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http/request.rs:31:60 [INFO] [stderr] | [INFO] [stderr] 31 | let mut path_iterator = path_with_params.splitn(2, "?"); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/http/response.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(http_version: &String, body_string: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(http_version: &str, body_string: &String) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `http_version.clone()` to [INFO] [stderr] | [INFO] [stderr] 19 | http_version: http_version.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/http/response.rs:14:52 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(http_version: &String, body_string: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(http_version: &String, body_string: &str) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `body_string.clone()` to [INFO] [stderr] | [INFO] [stderr] 21 | body: body_string.to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `argument_parser::ArgumentHash` [INFO] [stderr] --> src/argument_parser.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> ArgumentHash { [INFO] [stderr] 26 | | ArgumentHash { [INFO] [stderr] 27 | | arguments: Vec::::new(), [INFO] [stderr] 28 | | short_arguments: HashMap::new(), [INFO] [stderr] 29 | | long_arguments: HashMap::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/argument_parser.rs:52:43 [INFO] [stderr] | [INFO] [stderr] 52 | fn check_long_arg<'a>(&'a self, word: &'a String) -> (&str, &str) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/argument_parser.rs:54:48 [INFO] [stderr] | [INFO] [stderr] 54 | let mut bareword_iter = bareword.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/argument_parser.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let ref key = self.long_arguments. [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | let key = &self.long_arguments. [INFO] [stderr] 58 | get(provided_long_arg). [INFO] [stderr] 59 | expect("Don't know what to do with that option"). [INFO] [stderr] 60 | key; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/argument_parser.rs:64:44 [INFO] [stderr] | [INFO] [stderr] 64 | fn check_short_arg<'a>(&'a self, word: &'a String, args_vec: &'a Vec, i: usize) -> (&str, &str) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/argument_parser.rs:64:66 [INFO] [stderr] | [INFO] [stderr] 64 | fn check_short_arg<'a>(&'a self, word: &'a String, args_vec: &'a Vec, i: usize) -> (&str, &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/argument_parser.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let ref key = arg.key; [INFO] [stderr] | ----^^^^^^^----------- help: try: `let key = &arg.key;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/argument_parser.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let ref word = args_vec[i]; [INFO] [stderr] | ----^^^^^^^^--------------- help: try: `let word = &args_vec[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/argument_parser.rs:97:40 [INFO] [stderr] | [INFO] [stderr] 97 | } else if word.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http/request.rs:16:43 [INFO] [stderr] | [INFO] [stderr] 16 | let mut request_i = request.split("\n").map(|l| l.trim() ); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http/request.rs:24:59 [INFO] [stderr] | [INFO] [stderr] 24 | let request_parts: Vec<&str> = request_line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http/request.rs:31:60 [INFO] [stderr] | [INFO] [stderr] 31 | let mut path_iterator = path_with_params.splitn(2, "?"); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/http/response.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(http_version: &String, body_string: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(http_version: &str, body_string: &String) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `http_version.clone()` to [INFO] [stderr] | [INFO] [stderr] 19 | http_version: http_version.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/http/response.rs:14:52 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(http_version: &String, body_string: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(http_version: &String, body_string: &str) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `body_string.clone()` to [INFO] [stderr] | [INFO] [stderr] 21 | body: body_string.to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `argument_parser::ArgumentHash` [INFO] [stderr] --> src/argument_parser.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> ArgumentHash { [INFO] [stderr] 26 | | ArgumentHash { [INFO] [stderr] 27 | | arguments: Vec::::new(), [INFO] [stderr] 28 | | short_arguments: HashMap::new(), [INFO] [stderr] 29 | | long_arguments: HashMap::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/argument_parser.rs:52:43 [INFO] [stderr] | [INFO] [stderr] 52 | fn check_long_arg<'a>(&'a self, word: &'a String) -> (&str, &str) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/argument_parser.rs:54:48 [INFO] [stderr] | [INFO] [stderr] 54 | let mut bareword_iter = bareword.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/argument_parser.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let ref key = self.long_arguments. [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | let key = &self.long_arguments. [INFO] [stderr] 58 | get(provided_long_arg). [INFO] [stderr] 59 | expect("Don't know what to do with that option"). [INFO] [stderr] 60 | key; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/argument_parser.rs:64:44 [INFO] [stderr] | [INFO] [stderr] 64 | fn check_short_arg<'a>(&'a self, word: &'a String, args_vec: &'a Vec, i: usize) -> (&str, &str) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/argument_parser.rs:64:66 [INFO] [stderr] | [INFO] [stderr] 64 | fn check_short_arg<'a>(&'a self, word: &'a String, args_vec: &'a Vec, i: usize) -> (&str, &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/argument_parser.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let ref key = arg.key; [INFO] [stderr] | ----^^^^^^^----------- help: try: `let key = &arg.key;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/argument_parser.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let ref word = args_vec[i]; [INFO] [stderr] | ----^^^^^^^^--------------- help: try: `let word = &args_vec[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/argument_parser.rs:97:40 [INFO] [stderr] | [INFO] [stderr] 97 | } else if word.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "a9f7c6d9b9ffa92b6467382b3ac4eb51ac94914c29ae743e8e4d37f92a686267"` [INFO] running `"docker" "rm" "-f" "a9f7c6d9b9ffa92b6467382b3ac4eb51ac94914c29ae743e8e4d37f92a686267"` [INFO] [stdout] a9f7c6d9b9ffa92b6467382b3ac4eb51ac94914c29ae743e8e4d37f92a686267