[INFO] updating cached repository ferruccio/r53up [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ferruccio/r53up [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ferruccio/r53up" "work/ex/clippy-test-run/sources/stable/gh/ferruccio/r53up"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ferruccio/r53up'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ferruccio/r53up" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ferruccio/r53up"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ferruccio/r53up'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f4f61b96ef58e1ff5b475b4f0fab72be12d7b1d5 [INFO] sha for GitHub repo ferruccio/r53up: f4f61b96ef58e1ff5b475b4f0fab72be12d7b1d5 [INFO] validating manifest of ferruccio/r53up on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ferruccio/r53up on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ferruccio/r53up [INFO] finished frobbing ferruccio/r53up [INFO] frobbed toml for ferruccio/r53up written to work/ex/clippy-test-run/sources/stable/gh/ferruccio/r53up/Cargo.toml [INFO] started frobbing ferruccio/r53up [INFO] finished frobbing ferruccio/r53up [INFO] frobbed toml for ferruccio/r53up written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ferruccio/r53up/Cargo.toml [INFO] crate ferruccio/r53up has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ferruccio/r53up against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ferruccio/r53up:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47ba3d38bd9416ab5e9dec45be5e998481e92e2723a49f71b27801d8b1bdb7e4 [INFO] running `"docker" "start" "-a" "47ba3d38bd9416ab5e9dec45be5e998481e92e2723a49f71b27801d8b1bdb7e4"` [INFO] [stderr] Compiling rusoto_core v0.35.0 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking hyper v0.12.14 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking rusoto_credential v0.14.0 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking rusoto_route53 v0.35.0 [INFO] [stderr] Checking r53up v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | zone: zone, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `zone` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | dnsname: dnsname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dnsname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | ipv4: ipv4 [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ipv4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | zone: zone, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `zone` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | dnsname: dnsname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dnsname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | ipv4: ipv4 [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ipv4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | if domain.ends_with(".") { "" } else { "." }; [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | if domain.ends_with(".") { "" } else { "." }; [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.61s [INFO] running `"docker" "inspect" "47ba3d38bd9416ab5e9dec45be5e998481e92e2723a49f71b27801d8b1bdb7e4"` [INFO] running `"docker" "rm" "-f" "47ba3d38bd9416ab5e9dec45be5e998481e92e2723a49f71b27801d8b1bdb7e4"` [INFO] [stdout] 47ba3d38bd9416ab5e9dec45be5e998481e92e2723a49f71b27801d8b1bdb7e4