[INFO] updating cached repository ferrous-systems/cargo-review-deps
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ferrous-systems/cargo-review-deps
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ferrous-systems/cargo-review-deps" "work/ex/clippy-test-run/sources/stable/gh/ferrous-systems/cargo-review-deps"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ferrous-systems/cargo-review-deps'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ferrous-systems/cargo-review-deps" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ferrous-systems/cargo-review-deps"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ferrous-systems/cargo-review-deps'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c6706e58175267775264105ce6b7ce20442c9533
[INFO] sha for GitHub repo ferrous-systems/cargo-review-deps: c6706e58175267775264105ce6b7ce20442c9533
[INFO] validating manifest of ferrous-systems/cargo-review-deps on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ferrous-systems/cargo-review-deps on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ferrous-systems/cargo-review-deps
[INFO] finished frobbing ferrous-systems/cargo-review-deps
[INFO] frobbed toml for ferrous-systems/cargo-review-deps written to work/ex/clippy-test-run/sources/stable/gh/ferrous-systems/cargo-review-deps/Cargo.toml
[INFO] started frobbing ferrous-systems/cargo-review-deps
[INFO] finished frobbing ferrous-systems/cargo-review-deps
[INFO] frobbed toml for ferrous-systems/cargo-review-deps written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ferrous-systems/cargo-review-deps/Cargo.toml
[INFO] crate ferrous-systems/cargo-review-deps has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ferrous-systems/cargo-review-deps against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ferrous-systems/cargo-review-deps:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 85714aed5497ab737f38a0ba4b58a48b1e7b938f7c619d21fb13b99835dcb83e
[INFO] running `"docker" "start" "-a" "85714aed5497ab737f38a0ba4b58a48b1e7b938f7c619d21fb13b99835dcb83e"`
[INFO] [stderr]     Checking error-chain v0.12.0
[INFO] [stderr]     Checking assert_cli v0.6.3
[INFO] [stderr]     Checking cargo_metadata v0.6.2
[INFO] [stderr]     Checking cargo-review-deps v1.1.0-pre.1 (/opt/crater/workdir)
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 | /     if diff_status.is_err() {
[INFO] [stderr] 89 | |         if !has_diff_cmd() {
[INFO] [stderr] 90 | |             bail!("looks like you don't have a suitable diff command installed.\n\
[INFO] [stderr] 91 | |                    Try using --destination flag to run a custom diff tool or to compare sources manually.")
[INFO] [stderr] 92 | |         }
[INFO] [stderr] 93 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |     if diff_status.is_err() && !has_diff_cmd() {
[INFO] [stderr] 89 |     bail!("looks like you don't have a suitable diff command installed.\n\
[INFO] [stderr] 90 |            Try using --destination flag to run a custom diff tool or to compare sources manually.")
[INFO] [stderr] 91 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:251:1
[INFO] [stderr]     |
[INFO] [stderr] 251 | / fn crates_io_packages<'a>(
[INFO] [stderr] 252 | |     meta: &'a cargo_metadata::Metadata,
[INFO] [stderr] 253 | | ) -> impl Iterator<Item = &'a cargo_metadata::Package> {
[INFO] [stderr] 254 | |     meta.packages.iter().filter(|pkg| {
[INFO] [stderr] ...   |
[INFO] [stderr] 264 | |     })
[INFO] [stderr] 265 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 | /     if diff_status.is_err() {
[INFO] [stderr] 89 | |         if !has_diff_cmd() {
[INFO] [stderr] 90 | |             bail!("looks like you don't have a suitable diff command installed.\n\
[INFO] [stderr] 91 | |                    Try using --destination flag to run a custom diff tool or to compare sources manually.")
[INFO] [stderr] 92 | |         }
[INFO] [stderr] 93 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |     if diff_status.is_err() && !has_diff_cmd() {
[INFO] [stderr] 89 |     bail!("looks like you don't have a suitable diff command installed.\n\
[INFO] [stderr] 90 |            Try using --destination flag to run a custom diff tool or to compare sources manually.")
[INFO] [stderr] 91 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:251:1
[INFO] [stderr]     |
[INFO] [stderr] 251 | / fn crates_io_packages<'a>(
[INFO] [stderr] 252 | |     meta: &'a cargo_metadata::Metadata,
[INFO] [stderr] 253 | | ) -> impl Iterator<Item = &'a cargo_metadata::Package> {
[INFO] [stderr] 254 | |     meta.packages.iter().filter(|pkg| {
[INFO] [stderr] ...   |
[INFO] [stderr] 264 | |     })
[INFO] [stderr] 265 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.70s
[INFO] running `"docker" "inspect" "85714aed5497ab737f38a0ba4b58a48b1e7b938f7c619d21fb13b99835dcb83e"`
[INFO] running `"docker" "rm" "-f" "85714aed5497ab737f38a0ba4b58a48b1e7b938f7c619d21fb13b99835dcb83e"`
[INFO] [stdout] 85714aed5497ab737f38a0ba4b58a48b1e7b938f7c619d21fb13b99835dcb83e