[INFO] updating cached repository fennelq/parse_chg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fennelq/parse_chg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fennelq/parse_chg" "work/ex/clippy-test-run/sources/stable/gh/fennelq/parse_chg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fennelq/parse_chg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fennelq/parse_chg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fennelq/parse_chg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fennelq/parse_chg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bdec10982f080bf19a8bdaf5cbe6fb237a989e52 [INFO] sha for GitHub repo fennelq/parse_chg: bdec10982f080bf19a8bdaf5cbe6fb237a989e52 [INFO] validating manifest of fennelq/parse_chg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fennelq/parse_chg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fennelq/parse_chg [INFO] finished frobbing fennelq/parse_chg [INFO] frobbed toml for fennelq/parse_chg written to work/ex/clippy-test-run/sources/stable/gh/fennelq/parse_chg/Cargo.toml [INFO] started frobbing fennelq/parse_chg [INFO] finished frobbing fennelq/parse_chg [INFO] frobbed toml for fennelq/parse_chg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fennelq/parse_chg/Cargo.toml [INFO] crate fennelq/parse_chg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fennelq/parse_chg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fennelq/parse_chg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ca8b62a4fc1c927f9a31164fff76d90c68d1c0357891e5cdc4e90332cfa5254 [INFO] running `"docker" "start" "-a" "5ca8b62a4fc1c927f9a31164fff76d90c68d1c0357891e5cdc4e90332cfa5254"` [INFO] [stderr] Checking parse_chg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/sig/rab_e/rab_e.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | writeln!(f, "") [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/sig/rab_e/rab_e.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | writeln!(f, "") [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Pile` [INFO] [stderr] --> src/sig/rab_e/pile.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / enum PileType { [INFO] [stderr] 7 | | PileEF(PileEF), [INFO] [stderr] 8 | | PileFL(PileFL), [INFO] [stderr] 9 | | PileSize(PileSize), [INFO] [stderr] 10 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e_raw.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | if *&self.source.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `self.source.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e_raw.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | if *&self.name[6] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `self.name[6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e_raw.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if *&self.source.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `self.source.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e_raw.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if *&self.name[6] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `self.name[6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/sig/rab_e/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub mod rab_e; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | if *&self.name[6] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `self.name[6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if *&self.name[6] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `self.name[6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Pile` [INFO] [stderr] --> src/sig/rab_e/pile.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / enum PileType { [INFO] [stderr] 7 | | PileEF(PileEF), [INFO] [stderr] 8 | | PileFL(PileFL), [INFO] [stderr] 9 | | PileSize(PileSize), [INFO] [stderr] 10 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e_raw.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | if *&self.source.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `self.source.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e_raw.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | if *&self.name[6] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `self.name[6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e_raw.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if *&self.source.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `self.source.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e_raw.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if *&self.name[6] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `self.name[6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/sig/rab_e/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub mod rab_e; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | if *&self.name[6] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `self.name[6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sig/rab_e/rab_e.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if *&self.name[6] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `self.name[6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tests.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | / mod tests { [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | use std::path::Path; [INFO] [stderr] 5 | | use std::io::prelude::*; [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/boknagr_bkn.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/elemsres_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/material_mt.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/ndunions_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/nodesres_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/procalc_set.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/rigbodys_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/boknagr_bkn.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/rzagnums_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/zagrcmbs_zc.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/sig/building.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / fn write(&self) -> Vec { [INFO] [stderr] 87 | | let mut out = match &self.file_type { [INFO] [stderr] 88 | | file_type::FileType::BUILDER011 => b"BUILDER011".to_vec(), [INFO] [stderr] 89 | | file_type::FileType::CHARGE37 => b"CHARGE 3.7".to_vec(), [INFO] [stderr] ... | [INFO] [stderr] 133 | | out [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/sig/building.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] 141 | | writeln!(f, "{}", &self.file_type)?; [INFO] [stderr] 142 | | if let Some(ref s) = &self.barpbres_fe { writeln!(f, "{}", *s)? }; [INFO] [stderr] 143 | | if let Some(ref s) = &self.bkngwl_bnw { writeln!(f, "{}", *s)? }; [INFO] [stderr] ... | [INFO] [stderr] 182 | | write!(f, "") [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/elemsres_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/material_mt.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/ndunions_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sig/building.rs:236:26 [INFO] [stderr] | [INFO] [stderr] 236 | rab_e: rab_e.unwrap_or(vec![]), //Vec rab.e [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/sig/building_raw.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / fn write(&self) -> Vec { [INFO] [stderr] 87 | | let mut out = match &self.file_type { [INFO] [stderr] 88 | | file_type::FileType::BUILDER011 => b"BUILDER011".to_vec(), [INFO] [stderr] 89 | | file_type::FileType::CHARGE37 => b"CHARGE 3.7".to_vec(), [INFO] [stderr] ... | [INFO] [stderr] 133 | | out [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/sig/building_raw.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] 141 | | writeln!(f, "{}", &self.file_type)?; [INFO] [stderr] 142 | | if let Some(ref s) = &self.barpbres_fe { writeln!(f, "{}", *s)? }; [INFO] [stderr] 143 | | if let Some(ref s) = &self.bkngwl_bnw { writeln!(f, "{}", *s)? }; [INFO] [stderr] ... | [INFO] [stderr] 182 | | write!(f, "") [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/nodesres_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/procalc_set.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sig/building_raw.rs:236:26 [INFO] [stderr] | [INFO] [stderr] 236 | rab_e: rab_e.unwrap_or(vec![]), //Vec rab.e [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sig/mod.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | fn offset(len: &usize) -> [u8; 8] { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/read_write.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match file.read_to_end(&mut original_in) { [INFO] [stderr] 22 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 23 | | why.description()), [INFO] [stderr] 24 | | Ok(_) => (), [INFO] [stderr] 25 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Err(why) = file.read_to_end(&mut original_in) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 22 | why.description()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read_write.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | if building.0.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!building.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/read_write.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / match file.read_to_end(&mut original_in) { [INFO] [stderr] 45 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 46 | | why.description()), [INFO] [stderr] 47 | | Ok(_) => (), [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Err(why) = file.read_to_end(&mut original_in) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 45 | why.description()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read_write.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | if building.0.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!building.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/read_write.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | match remove_dir_all(out) {Err(_)=>(),Ok(_)=>(),}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `if let Err(_) = remove_dir_all(out) { () }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/read_write.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | match create_dir (out) {Err(_)=>(),Ok(_)=>(),}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `if let Err(_) = create_dir (out) { () }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/rigbodys_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/rzagnums_fe.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sig/zagrcmbs_zc.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | flag_line: *array_ref!(flag_line, 0 ,1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/sig/building.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / fn write(&self) -> Vec { [INFO] [stderr] 87 | | let mut out = match &self.file_type { [INFO] [stderr] 88 | | file_type::FileType::BUILDER011 => b"BUILDER011".to_vec(), [INFO] [stderr] 89 | | file_type::FileType::CHARGE37 => b"CHARGE 3.7".to_vec(), [INFO] [stderr] ... | [INFO] [stderr] 133 | | out [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/sig/building.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] 141 | | writeln!(f, "{}", &self.file_type)?; [INFO] [stderr] 142 | | if let Some(ref s) = &self.barpbres_fe { writeln!(f, "{}", *s)? }; [INFO] [stderr] 143 | | if let Some(ref s) = &self.bkngwl_bnw { writeln!(f, "{}", *s)? }; [INFO] [stderr] ... | [INFO] [stderr] 182 | | write!(f, "") [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sig/building.rs:236:26 [INFO] [stderr] | [INFO] [stderr] 236 | rab_e: rab_e.unwrap_or(vec![]), //Vec rab.e [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/sig/building_raw.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / fn write(&self) -> Vec { [INFO] [stderr] 87 | | let mut out = match &self.file_type { [INFO] [stderr] 88 | | file_type::FileType::BUILDER011 => b"BUILDER011".to_vec(), [INFO] [stderr] 89 | | file_type::FileType::CHARGE37 => b"CHARGE 3.7".to_vec(), [INFO] [stderr] ... | [INFO] [stderr] 133 | | out [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/sig/building_raw.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] 141 | | writeln!(f, "{}", &self.file_type)?; [INFO] [stderr] 142 | | if let Some(ref s) = &self.barpbres_fe { writeln!(f, "{}", *s)? }; [INFO] [stderr] 143 | | if let Some(ref s) = &self.bkngwl_bnw { writeln!(f, "{}", *s)? }; [INFO] [stderr] ... | [INFO] [stderr] 182 | | write!(f, "") [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sig/building_raw.rs:236:26 [INFO] [stderr] | [INFO] [stderr] 236 | rab_e: rab_e.unwrap_or(vec![]), //Vec rab.e [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sig/mod.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | fn offset(len: &usize) -> [u8; 8] { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/read_write.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match file.read_to_end(&mut original_in) { [INFO] [stderr] 22 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 23 | | why.description()), [INFO] [stderr] 24 | | Ok(_) => (), [INFO] [stderr] 25 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Err(why) = file.read_to_end(&mut original_in) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 22 | why.description()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read_write.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | if building.0.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!building.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/read_write.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / match file.read_to_end(&mut original_in) { [INFO] [stderr] 45 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 46 | | why.description()), [INFO] [stderr] 47 | | Ok(_) => (), [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Err(why) = file.read_to_end(&mut original_in) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 45 | why.description()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read_write.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | if building.0.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!building.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/read_write.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | match remove_dir_all(out) {Err(_)=>(),Ok(_)=>(),}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `if let Err(_) = remove_dir_all(out) { () }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/read_write.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | match create_dir (out) {Err(_)=>(),Ok(_)=>(),}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `if let Err(_) = create_dir (out) { () }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / match file.read_to_end(&mut original_in) { [INFO] [stderr] 29 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 30 | | why.description()), [INFO] [stderr] 31 | | Ok(_) => (), [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let Err(why) = file.read_to_end(&mut original_in) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 29 | why.description()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.29s [INFO] running `"docker" "inspect" "5ca8b62a4fc1c927f9a31164fff76d90c68d1c0357891e5cdc4e90332cfa5254"` [INFO] running `"docker" "rm" "-f" "5ca8b62a4fc1c927f9a31164fff76d90c68d1c0357891e5cdc4e90332cfa5254"` [INFO] [stdout] 5ca8b62a4fc1c927f9a31164fff76d90c68d1c0357891e5cdc4e90332cfa5254