[INFO] updating cached repository femnad/over-here [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/femnad/over-here [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/femnad/over-here" "work/ex/clippy-test-run/sources/stable/gh/femnad/over-here"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/femnad/over-here'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/femnad/over-here" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/femnad/over-here"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/femnad/over-here'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ee7f3bbd26bc0046888c466b4c0b6bf3163f8c7f [INFO] sha for GitHub repo femnad/over-here: ee7f3bbd26bc0046888c466b4c0b6bf3163f8c7f [INFO] validating manifest of femnad/over-here on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of femnad/over-here on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing femnad/over-here [INFO] finished frobbing femnad/over-here [INFO] frobbed toml for femnad/over-here written to work/ex/clippy-test-run/sources/stable/gh/femnad/over-here/Cargo.toml [INFO] started frobbing femnad/over-here [INFO] finished frobbing femnad/over-here [INFO] frobbed toml for femnad/over-here written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/femnad/over-here/Cargo.toml [INFO] crate femnad/over-here has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting femnad/over-here against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/femnad/over-here:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb02d55c68adeb061f4138a8fb9a64011f25c549d888ed256219579437afbdcf [INFO] running `"docker" "start" "-a" "eb02d55c68adeb061f4138a8fb9a64011f25c549d888ed256219579437afbdcf"` [INFO] [stderr] Checking rust-ini v0.10.0 [INFO] [stderr] Checking nix v0.8.0 [INFO] [stderr] Checking notify-rust v3.2.1 [INFO] [stderr] Checking over-here v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:29:32 [INFO] [stderr] | [INFO] [stderr] 29 | let mut config_file_path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | fn run_command(notifier:&String, notification:&Notification) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let ref summary = notification.summary; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let summary = ¬ification.summary;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let ref body = notification.body; [INFO] [stderr] | ----^^^^^^^^--------------------- help: try: `let body = ¬ification.body;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:29:32 [INFO] [stderr] | [INFO] [stderr] 29 | let mut config_file_path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | fn run_command(notifier:&String, notification:&Notification) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let ref summary = notification.summary; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let summary = ¬ification.summary;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let ref body = notification.body; [INFO] [stderr] | ----^^^^^^^^--------------------- help: try: `let body = ¬ification.body;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.86s [INFO] running `"docker" "inspect" "eb02d55c68adeb061f4138a8fb9a64011f25c549d888ed256219579437afbdcf"` [INFO] running `"docker" "rm" "-f" "eb02d55c68adeb061f4138a8fb9a64011f25c549d888ed256219579437afbdcf"` [INFO] [stdout] eb02d55c68adeb061f4138a8fb9a64011f25c549d888ed256219579437afbdcf