[INFO] updating cached repository felixhao/some_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/felixhao/some_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/felixhao/some_rust" "work/ex/clippy-test-run/sources/stable/gh/felixhao/some_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/felixhao/some_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/felixhao/some_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/felixhao/some_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/felixhao/some_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f84bd8858b30c6694286c4ebfea6fbb4edac17f1 [INFO] sha for GitHub repo felixhao/some_rust: f84bd8858b30c6694286c4ebfea6fbb4edac17f1 [INFO] validating manifest of felixhao/some_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of felixhao/some_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing felixhao/some_rust [INFO] finished frobbing felixhao/some_rust [INFO] frobbed toml for felixhao/some_rust written to work/ex/clippy-test-run/sources/stable/gh/felixhao/some_rust/Cargo.toml [INFO] started frobbing felixhao/some_rust [INFO] finished frobbing felixhao/some_rust [INFO] frobbed toml for felixhao/some_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/felixhao/some_rust/Cargo.toml [INFO] crate felixhao/some_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting felixhao/some_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/felixhao/some_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 141995f291026ceb9a96e4012263076149510ab527072668e5392640af05d6b4 [INFO] running `"docker" "start" "-a" "141995f291026ceb9a96e4012263076149510ab527072668e5392640af05d6b4"` [INFO] [stderr] Checking some_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/closure/mod.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | println!("arr any equal 2: {}", arr1.into_iter().any(|&x| x == 2)); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/closure/mod.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | .filter(|&x| x % 2 == 1) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 61 | | .fold(0, |sum, x| sum + x); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] --> src/flow/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner: loop { [INFO] [stderr] 43 | | println!("enter inner loop"); [INFO] [stderr] 44 | | if i == 1 { [INFO] [stderr] 45 | | break; [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/flow/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner: loop { [INFO] [stderr] 43 | | println!("enter inner loop"); [INFO] [stderr] 44 | | if i == 1 { [INFO] [stderr] 45 | | break; [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/matchs/mod.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | let bin = match bbb { [INFO] [stderr] | _______________^ [INFO] [stderr] 19 | | true => 1, [INFO] [stderr] 20 | | false => 0, [INFO] [stderr] 21 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if bbb { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/matchs/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / match reference { [INFO] [stderr] 40 | | &val => println!("reference is {:?}", val), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *reference { [INFO] [stderr] 40 | val => println!("reference is {:?}", val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/types/mod.rs:121:26 [INFO] [stderr] | [INFO] [stderr] 121 | List::Nil => format!("Nil"), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nil".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `some_rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/closure/mod.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | println!("arr any equal 2: {}", arr1.into_iter().any(|&x| x == 2)); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/closure/mod.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | .filter(|&x| x % 2 == 1) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 61 | | .fold(0, |sum, x| sum + x); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] --> src/flow/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner: loop { [INFO] [stderr] 43 | | println!("enter inner loop"); [INFO] [stderr] 44 | | if i == 1 { [INFO] [stderr] 45 | | break; [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/flow/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner: loop { [INFO] [stderr] 43 | | println!("enter inner loop"); [INFO] [stderr] 44 | | if i == 1 { [INFO] [stderr] 45 | | break; [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/matchs/mod.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | let bin = match bbb { [INFO] [stderr] | _______________^ [INFO] [stderr] 19 | | true => 1, [INFO] [stderr] 20 | | false => 0, [INFO] [stderr] 21 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if bbb { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/matchs/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / match reference { [INFO] [stderr] 40 | | &val => println!("reference is {:?}", val), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *reference { [INFO] [stderr] 40 | val => println!("reference is {:?}", val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/types/mod.rs:121:26 [INFO] [stderr] | [INFO] [stderr] 121 | List::Nil => format!("Nil"), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nil".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `some_rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "141995f291026ceb9a96e4012263076149510ab527072668e5392640af05d6b4"` [INFO] running `"docker" "rm" "-f" "141995f291026ceb9a96e4012263076149510ab527072668e5392640af05d6b4"` [INFO] [stdout] 141995f291026ceb9a96e4012263076149510ab527072668e5392640af05d6b4