[INFO] updating cached repository felipesere/dotter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/felipesere/dotter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/felipesere/dotter" "work/ex/clippy-test-run/sources/stable/gh/felipesere/dotter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/felipesere/dotter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/felipesere/dotter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/felipesere/dotter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/felipesere/dotter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 123bf7f90bbc280d4cd9513fd328b199fe32cd22 [INFO] sha for GitHub repo felipesere/dotter: 123bf7f90bbc280d4cd9513fd328b199fe32cd22 [INFO] validating manifest of felipesere/dotter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of felipesere/dotter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing felipesere/dotter [INFO] finished frobbing felipesere/dotter [INFO] frobbed toml for felipesere/dotter written to work/ex/clippy-test-run/sources/stable/gh/felipesere/dotter/Cargo.toml [INFO] started frobbing felipesere/dotter [INFO] finished frobbing felipesere/dotter [INFO] frobbed toml for felipesere/dotter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/felipesere/dotter/Cargo.toml [INFO] crate felipesere/dotter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting felipesere/dotter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/felipesere/dotter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55079669ff2d2a4eda7583add4bfafca63714f70f1014ce3f187495b2cea265e [INFO] running `"docker" "start" "-a" "55079669ff2d2a4eda7583add4bfafca63714f70f1014ce3f187495b2cea265e"` [INFO] [stderr] Compiling proc-macro2 v0.4.18 [INFO] [stderr] Compiling serde v1.0.77 [INFO] [stderr] Compiling git-version v0.2.1 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking openssl v0.10.12 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Compiling dotter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling syn v0.15.1 [INFO] [stderr] Checking native-tls v0.2.1 [INFO] [stderr] Checking hyper v0.12.10 [INFO] [stderr] Compiling serde_derive v1.0.77 [INFO] [stderr] Checking hyper-tls v0.3.0 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking reqwest v0.9.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symlinks.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | environment: environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `environment` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symlinks.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | environment: environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `environment` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/homebrew.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | Brew::FromTap(TappedBrew { tap: _, name }) => ls(name, Regular), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `TappedBrew { name, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/homebrew.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | Brew::FromTap(TappedBrew { tap: _, name }) => ls(name, Regular), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `TappedBrew { name, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/homebrew.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match source { [INFO] [stderr] 24 | | BrewSoure::Cask => { [INFO] [stderr] 25 | | command.arg("cask"); [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | _ => (), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | if let BrewSoure::Cask = source { [INFO] [stderr] 24 | command.arg("cask"); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/symlinks.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | if !target.contains("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | let group = inv.group(name.as_ref()).expect("did not find group."); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/homebrew.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match source { [INFO] [stderr] 24 | | BrewSoure::Cask => { [INFO] [stderr] 25 | | command.arg("cask"); [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | _ => (), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | if let BrewSoure::Cask = source { [INFO] [stderr] 24 | command.arg("cask"); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/homebrew.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | brew.execute(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/homebrew.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | brew.rollback(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/homebrew.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | brew_cask.execute(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/homebrew.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | brew_cask.rollback(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/homebrew.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | brew_cask.execute(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/homebrew.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | brew_cask.rollback(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/shell.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | echo_command.execute(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/symlinks.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | if !target.contains("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/symlinks.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | linker.execute(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/symlinks.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | linker.rollback(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/symlinks.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | linker.execute(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/symlinks.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | linker.rollback(&context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symlinks.rs:170:20 [INFO] [stderr] | [INFO] [stderr] 170 | assert_eq!(explanations.get(0).unwrap().message, expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&explanations[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symlinks.rs:192:20 [INFO] [stderr] | [INFO] [stderr] 192 | assert_eq!(explanations.get(0).unwrap().message, expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&explanations[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | let group = inv.group(name.as_ref()).expect("did not find group."); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.80s [INFO] running `"docker" "inspect" "55079669ff2d2a4eda7583add4bfafca63714f70f1014ce3f187495b2cea265e"` [INFO] running `"docker" "rm" "-f" "55079669ff2d2a4eda7583add4bfafca63714f70f1014ce3f187495b2cea265e"` [INFO] [stdout] 55079669ff2d2a4eda7583add4bfafca63714f70f1014ce3f187495b2cea265e