[INFO] updating cached repository fe-riff/rukafka
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/fe-riff/rukafka
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/fe-riff/rukafka" "work/ex/clippy-test-run/sources/stable/gh/fe-riff/rukafka"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fe-riff/rukafka'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/fe-riff/rukafka" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fe-riff/rukafka"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fe-riff/rukafka'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b6f088e5069e7f3b9b8c84d81364220cb1c0034f
[INFO] sha for GitHub repo fe-riff/rukafka: b6f088e5069e7f3b9b8c84d81364220cb1c0034f
[INFO] validating manifest of fe-riff/rukafka on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of fe-riff/rukafka on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing fe-riff/rukafka
[INFO] finished frobbing fe-riff/rukafka
[INFO] frobbed toml for fe-riff/rukafka written to work/ex/clippy-test-run/sources/stable/gh/fe-riff/rukafka/Cargo.toml
[INFO] started frobbing fe-riff/rukafka
[INFO] finished frobbing fe-riff/rukafka
[INFO] frobbed toml for fe-riff/rukafka written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fe-riff/rukafka/Cargo.toml
[INFO] crate fe-riff/rukafka has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting fe-riff/rukafka against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fe-riff/rukafka:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1e66ce1af6c0c364c112c4690292d8425995ee1a99ec64759e32505cd4f54754
[INFO] running `"docker" "start" "-a" "1e66ce1af6c0c364c112c4690292d8425995ee1a99ec64759e32505cd4f54754"`
[INFO] [stderr]     Checking ref_slice v1.1.1
[INFO] [stderr]    Compiling miniz-sys v0.1.10
[INFO] [stderr]    Compiling openssl-sys v0.9.24
[INFO] [stderr]     Checking snap v0.2.4
[INFO] [stderr]     Checking twox-hash v1.1.0
[INFO] [stderr]     Checking error-chain v0.10.0
[INFO] [stderr]    Compiling openssl v0.9.23
[INFO] [stderr]     Checking flate2 v0.2.20
[INFO] [stderr]     Checking kafka v0.7.0
[INFO] [stderr]     Checking rukafka v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wireformat.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         headers: headers,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `headers`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wireformat.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         headers: headers,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `headers`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/wireformat.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     return [b1, b2, b3, b4];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[b1, b2, b3, b4]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/wireformat.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     return [b1, b2, b3, b4];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[b1, b2, b3, b4]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/wireformat.rs:49:50
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn new_message<'a>(bytes: &'a [u8], headers: HashMap<String, [String; 1]>) -> Message<'a> {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn new_message<'a, S: ::std::hash::BuildHasher>(bytes: &'a [u8], headers: HashMap<String, [String; 1], S>) -> Message<'a> {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/wireformat.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn to_kafka<'a>(message: Message) -> Vec<u8> {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/wireformat.rs:49:50
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn new_message<'a>(bytes: &'a [u8], headers: HashMap<String, [String; 1]>) -> Message<'a> {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 49 | pub fn new_message<'a, S: ::std::hash::BuildHasher>(bytes: &'a [u8], headers: HashMap<String, [String; 1], S>) -> Message<'a> {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/wireformat.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn to_kafka<'a>(message: Message) -> Vec<u8> {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/wireformat.rs:98:31
[INFO] [stderr]    |
[INFO] [stderr] 98 |         let msg = new_message("hello".as_bytes(), headers);
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/wireformat.rs:107:31
[INFO] [stderr]     |
[INFO] [stderr] 107 |         let msg = new_message("hello".as_bytes(), headers);
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 17.06s
[INFO] running `"docker" "inspect" "1e66ce1af6c0c364c112c4690292d8425995ee1a99ec64759e32505cd4f54754"`
[INFO] running `"docker" "rm" "-f" "1e66ce1af6c0c364c112c4690292d8425995ee1a99ec64759e32505cd4f54754"`
[INFO] [stdout] 1e66ce1af6c0c364c112c4690292d8425995ee1a99ec64759e32505cd4f54754