[INFO] updating cached repository fdumontmd/cask-update [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fdumontmd/cask-update [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fdumontmd/cask-update" "work/ex/clippy-test-run/sources/stable/gh/fdumontmd/cask-update"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fdumontmd/cask-update'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fdumontmd/cask-update" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fdumontmd/cask-update"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fdumontmd/cask-update'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 823f29623c33c0c4edd44e4320f2de25ab0a7c8c [INFO] sha for GitHub repo fdumontmd/cask-update: 823f29623c33c0c4edd44e4320f2de25ab0a7c8c [INFO] validating manifest of fdumontmd/cask-update on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fdumontmd/cask-update on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fdumontmd/cask-update [INFO] finished frobbing fdumontmd/cask-update [INFO] frobbed toml for fdumontmd/cask-update written to work/ex/clippy-test-run/sources/stable/gh/fdumontmd/cask-update/Cargo.toml [INFO] started frobbing fdumontmd/cask-update [INFO] finished frobbing fdumontmd/cask-update [INFO] frobbed toml for fdumontmd/cask-update written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fdumontmd/cask-update/Cargo.toml [INFO] crate fdumontmd/cask-update has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fdumontmd/cask-update against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fdumontmd/cask-update:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb9c0136a5c5c488a188fe689be0c1461d2a543ed5f5f74736465db471c87afe [INFO] running `"docker" "start" "-a" "bb9c0136a5c5c488a188fe689be0c1461d2a543ed5f5f74736465db471c87afe"` [INFO] [stderr] Checking tabwriter v1.0.4 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling syn v0.13.4 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling structopt-derive v0.2.8 [INFO] [stderr] Checking structopt v0.2.8 [INFO] [stderr] Checking cask-update v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | write!(&mut tw, "Cask\tInstalled\tLatest\tNeeds update\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / write!( [INFO] [stderr] 117 | | &mut tw, [INFO] [stderr] 118 | | "{}\t{}\t{}\t{}\n", [INFO] [stderr] 119 | | cask.name, [INFO] [stderr] ... | [INFO] [stderr] 122 | | if cask.updatable { "Yes" } else { "No" } [INFO] [stderr] 123 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | write!(&mut tw, "Cask\tInstalled\tLatest\tNeeds update\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / write!( [INFO] [stderr] 117 | | &mut tw, [INFO] [stderr] 118 | | "{}\t{}\t{}\t{}\n", [INFO] [stderr] 119 | | cask.name, [INFO] [stderr] ... | [INFO] [stderr] 122 | | if cask.updatable { "Yes" } else { "No" } [INFO] [stderr] 123 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:84:33 [INFO] [stderr] | [INFO] [stderr] 84 | let latest = latest.ok_or(format!("Unknown latest version for {}", name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown latest version for {}", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:85:39 [INFO] [stderr] | [INFO] [stderr] 85 | let installed = installed.ok_or(format!("Unknown installed version for {}", name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown installed version for {}", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:86:39 [INFO] [stderr] | [INFO] [stderr] 86 | let path = installed_path.ok_or(format!("Unknown installed path for {}", name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown installed path for {}", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:84:33 [INFO] [stderr] | [INFO] [stderr] 84 | let latest = latest.ok_or(format!("Unknown latest version for {}", name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown latest version for {}", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:85:39 [INFO] [stderr] | [INFO] [stderr] 85 | let installed = installed.ok_or(format!("Unknown installed version for {}", name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown installed version for {}", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:86:39 [INFO] [stderr] | [INFO] [stderr] 86 | let path = installed_path.ok_or(format!("Unknown installed path for {}", name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown installed path for {}", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.94s [INFO] running `"docker" "inspect" "bb9c0136a5c5c488a188fe689be0c1461d2a543ed5f5f74736465db471c87afe"` [INFO] running `"docker" "rm" "-f" "bb9c0136a5c5c488a188fe689be0c1461d2a543ed5f5f74736465db471c87afe"` [INFO] [stdout] bb9c0136a5c5c488a188fe689be0c1461d2a543ed5f5f74736465db471c87afe