[INFO] updating cached repository fasihrana/glutin_multiwindow_example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fasihrana/glutin_multiwindow_example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fasihrana/glutin_multiwindow_example" "work/ex/clippy-test-run/sources/stable/gh/fasihrana/glutin_multiwindow_example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fasihrana/glutin_multiwindow_example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fasihrana/glutin_multiwindow_example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fasihrana/glutin_multiwindow_example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fasihrana/glutin_multiwindow_example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 40cdc7507a2462d58916c354f0d2322386897dd8 [INFO] sha for GitHub repo fasihrana/glutin_multiwindow_example: 40cdc7507a2462d58916c354f0d2322386897dd8 [INFO] validating manifest of fasihrana/glutin_multiwindow_example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fasihrana/glutin_multiwindow_example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fasihrana/glutin_multiwindow_example [INFO] finished frobbing fasihrana/glutin_multiwindow_example [INFO] frobbed toml for fasihrana/glutin_multiwindow_example written to work/ex/clippy-test-run/sources/stable/gh/fasihrana/glutin_multiwindow_example/Cargo.toml [INFO] started frobbing fasihrana/glutin_multiwindow_example [INFO] finished frobbing fasihrana/glutin_multiwindow_example [INFO] frobbed toml for fasihrana/glutin_multiwindow_example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fasihrana/glutin_multiwindow_example/Cargo.toml [INFO] crate fasihrana/glutin_multiwindow_example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fasihrana/glutin_multiwindow_example against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fasihrana/glutin_multiwindow_example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3eb63a39f5cab4f6bdd89c4960988ef4b7eec08d3f428f30104bd9a8e596c4b2 [INFO] running `"docker" "start" "-a" "3eb63a39f5cab4f6bdd89c4960988ef4b7eec08d3f428f30104bd9a8e596c4b2"` [INFO] [stderr] Compiling gleam v0.6.3 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking glutin v0.18.0 [INFO] [stderr] Checking mwindowsample v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `new` [INFO] [stderr] --> src/main.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | let mut new = 0; [INFO] [stderr] | ^^^ help: consider using `_new` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | let mut new = 0; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / match e { [INFO] [stderr] 38 | | glutin::Event::WindowEvent {event, ..} => { [INFO] [stderr] 39 | | match event { [INFO] [stderr] 40 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] ... | [INFO] [stderr] 51 | | _=>(), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let glutin::Event::WindowEvent {event, ..} = e { [INFO] [stderr] 38 | match event { [INFO] [stderr] 39 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 40 | exit = true; [INFO] [stderr] 41 | }, [INFO] [stderr] 42 | glutin::WindowEvent::MouseInput{state,..} => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | self.gl_window.swap_buffers(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if wv.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wv.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused variable: `new` [INFO] [stderr] --> src/main.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | let mut new = 0; [INFO] [stderr] | ^^^ help: consider using `_new` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | let mut new = 0; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / match e { [INFO] [stderr] 38 | | glutin::Event::WindowEvent {event, ..} => { [INFO] [stderr] 39 | | match event { [INFO] [stderr] 40 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] ... | [INFO] [stderr] 51 | | _=>(), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let glutin::Event::WindowEvent {event, ..} = e { [INFO] [stderr] 38 | match event { [INFO] [stderr] 39 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 40 | exit = true; [INFO] [stderr] 41 | }, [INFO] [stderr] 42 | glutin::WindowEvent::MouseInput{state,..} => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | self.gl_window.swap_buffers(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if wv.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wv.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.96s [INFO] running `"docker" "inspect" "3eb63a39f5cab4f6bdd89c4960988ef4b7eec08d3f428f30104bd9a8e596c4b2"` [INFO] running `"docker" "rm" "-f" "3eb63a39f5cab4f6bdd89c4960988ef4b7eec08d3f428f30104bd9a8e596c4b2"` [INFO] [stdout] 3eb63a39f5cab4f6bdd89c4960988ef4b7eec08d3f428f30104bd9a8e596c4b2