[INFO] updating cached repository faradayio/geochunk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/faradayio/geochunk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/faradayio/geochunk" "work/ex/clippy-test-run/sources/stable/gh/faradayio/geochunk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/faradayio/geochunk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/faradayio/geochunk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/faradayio/geochunk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/faradayio/geochunk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 282cbb735d0fffb1dcbfeaa274ac4035850273e7 [INFO] sha for GitHub repo faradayio/geochunk: 282cbb735d0fffb1dcbfeaa274ac4035850273e7 [INFO] validating manifest of faradayio/geochunk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of faradayio/geochunk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing faradayio/geochunk [INFO] finished frobbing faradayio/geochunk [INFO] frobbed toml for faradayio/geochunk written to work/ex/clippy-test-run/sources/stable/gh/faradayio/geochunk/Cargo.toml [INFO] started frobbing faradayio/geochunk [INFO] finished frobbing faradayio/geochunk [INFO] frobbed toml for faradayio/geochunk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/faradayio/geochunk/Cargo.toml [INFO] crate faradayio/geochunk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting faradayio/geochunk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/faradayio/geochunk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5e4a07be7ffde5f4b7ff3e9233ebe732061b4bb4a520e03d05b787eadf1927a [INFO] running `"docker" "start" "-a" "d5e4a07be7ffde5f4b7ff3e9233ebe732061b4bb4a520e03d05b787eadf1927a"` [INFO] [stderr] Checking cli_test_dir v0.1.4 [INFO] [stderr] Checking snap v0.2.3 [INFO] [stderr] Checking csv-core v0.1.3 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking docopt v0.8.1 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking geochunk v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/zip2010.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | target_population: target_population, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_population` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/zip2010.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | chunk_id_for_prefix: chunk_id_for_prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_id_for_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/zip2010.rs:205:28 [INFO] [stderr] | [INFO] [stderr] 205 | PrefixPopulation { maps: maps } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `maps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/zip2010.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | target_population: target_population, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_population` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/zip2010.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | chunk_id_for_prefix: chunk_id_for_prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_id_for_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/zip2010.rs:205:28 [INFO] [stderr] | [INFO] [stderr] 205 | PrefixPopulation { maps: maps } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `maps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/zip2010.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | for zip_int in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/zip2010.rs:172:28 [INFO] [stderr] | [INFO] [stderr] 172 | const ZIP_POPULATION_CSV: &'static str = include_str!("zip2010.csv"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/zip2010.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | for zip_int in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/zip2010.rs:142:38 [INFO] [stderr] | [INFO] [stderr] 142 | let classifier = Classifier::new(250000); [INFO] [stderr] | ^^^^^^ help: consider: `250_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/zip2010.rs:151:38 [INFO] [stderr] | [INFO] [stderr] 151 | let classifier = Classifier::new(250000); [INFO] [stderr] | ^^^^^^ help: consider: `250_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/zip2010.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | let classifier = Classifier::new(250000); [INFO] [stderr] | ^^^^^^ help: consider: `250_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/zip2010.rs:172:28 [INFO] [stderr] | [INFO] [stderr] 172 | const ZIP_POPULATION_CSV: &'static str = include_str!("zip2010.csv"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/zip2010.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | for i_rev in 0..(ZIP_CODE_LENGTH + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=ZIP_CODE_LENGTH` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/zip2010.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | for i_rev in 0..(ZIP_CODE_LENGTH + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=ZIP_CODE_LENGTH` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.83s [INFO] running `"docker" "inspect" "d5e4a07be7ffde5f4b7ff3e9233ebe732061b4bb4a520e03d05b787eadf1927a"` [INFO] running `"docker" "rm" "-f" "d5e4a07be7ffde5f4b7ff3e9233ebe732061b4bb4a520e03d05b787eadf1927a"` [INFO] [stdout] d5e4a07be7ffde5f4b7ff3e9233ebe732061b4bb4a520e03d05b787eadf1927a