[INFO] updating cached repository faradayio/credentials_to_env [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/faradayio/credentials_to_env [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/faradayio/credentials_to_env" "work/ex/clippy-test-run/sources/stable/gh/faradayio/credentials_to_env"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/faradayio/credentials_to_env'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/faradayio/credentials_to_env" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/faradayio/credentials_to_env"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/faradayio/credentials_to_env'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 22e013c174ea4569021a46c394268c26d894e5e1 [INFO] sha for GitHub repo faradayio/credentials_to_env: 22e013c174ea4569021a46c394268c26d894e5e1 [INFO] validating manifest of faradayio/credentials_to_env on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of faradayio/credentials_to_env on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing faradayio/credentials_to_env [INFO] finished frobbing faradayio/credentials_to_env [INFO] frobbed toml for faradayio/credentials_to_env written to work/ex/clippy-test-run/sources/stable/gh/faradayio/credentials_to_env/Cargo.toml [INFO] started frobbing faradayio/credentials_to_env [INFO] finished frobbing faradayio/credentials_to_env [INFO] frobbed toml for faradayio/credentials_to_env written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/faradayio/credentials_to_env/Cargo.toml [INFO] crate faradayio/credentials_to_env has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting faradayio/credentials_to_env against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/faradayio/credentials_to_env:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9889fda830088dd105cb888d88bded68e6bab9da212b59717301365c16bfa2f [INFO] running `"docker" "start" "-a" "f9889fda830088dd105cb888d88bded68e6bab9da212b59717301365c16bfa2f"` [INFO] [stderr] Checking errno v0.2.4 [INFO] [stderr] Compiling openssl-sys v0.9.35 [INFO] [stderr] Checking common_failures v0.1.1 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking exec v0.3.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking credentials v0.10.0 [INFO] [stderr] Checking credentials_to_env v0.4.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | allow_override: allow_override, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allow_override` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | secretfile: secretfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secretfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | allow_override: allow_override, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allow_override` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | secretfile: secretfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secretfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | if args[0].chars().next() == Some('-') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `args[0].starts_with('-')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:95:31 [INFO] [stderr] | [INFO] [stderr] 95 | if args.is_empty() || args[0].chars().next() == Some('-') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `args[0].starts_with('-')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:132:27 [INFO] [stderr] | [INFO] [stderr] 132 | let secretfile = try!(match &args.secretfile { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 133 | | &Some(ref path) => Secretfile::from_path(path), [INFO] [stderr] 134 | | &None => Secretfile::default(), [INFO] [stderr] 135 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 132 | let secretfile = try!(match args.secretfile { [INFO] [stderr] 133 | Some(ref path) => Secretfile::from_path(path), [INFO] [stderr] 134 | None => Secretfile::default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | if args[0].chars().next() == Some('-') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `args[0].starts_with('-')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:95:31 [INFO] [stderr] | [INFO] [stderr] 95 | if args.is_empty() || args[0].chars().next() == Some('-') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `args[0].starts_with('-')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:132:27 [INFO] [stderr] | [INFO] [stderr] 132 | let secretfile = try!(match &args.secretfile { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 133 | | &Some(ref path) => Secretfile::from_path(path), [INFO] [stderr] 134 | | &None => Secretfile::default(), [INFO] [stderr] 135 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 132 | let secretfile = try!(match args.secretfile { [INFO] [stderr] 133 | Some(ref path) => Secretfile::from_path(path), [INFO] [stderr] 134 | None => Secretfile::default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.14s [INFO] running `"docker" "inspect" "f9889fda830088dd105cb888d88bded68e6bab9da212b59717301365c16bfa2f"` [INFO] running `"docker" "rm" "-f" "f9889fda830088dd105cb888d88bded68e6bab9da212b59717301365c16bfa2f"` [INFO] [stdout] f9889fda830088dd105cb888d88bded68e6bab9da212b59717301365c16bfa2f