[INFO] updating cached repository facebookincubator/fastmod [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/facebookincubator/fastmod [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/facebookincubator/fastmod" "work/ex/clippy-test-run/sources/stable/gh/facebookincubator/fastmod"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/facebookincubator/fastmod'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/facebookincubator/fastmod" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/facebookincubator/fastmod"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/facebookincubator/fastmod'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6f19b3a4a15f6f3b21782d0029823cbcbef72469 [INFO] sha for GitHub repo facebookincubator/fastmod: 6f19b3a4a15f6f3b21782d0029823cbcbef72469 [INFO] validating manifest of facebookincubator/fastmod on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of facebookincubator/fastmod on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing facebookincubator/fastmod [INFO] finished frobbing facebookincubator/fastmod [INFO] frobbed toml for facebookincubator/fastmod written to work/ex/clippy-test-run/sources/stable/gh/facebookincubator/fastmod/Cargo.toml [INFO] started frobbing facebookincubator/fastmod [INFO] finished frobbing facebookincubator/fastmod [INFO] frobbed toml for facebookincubator/fastmod written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/facebookincubator/fastmod/Cargo.toml [INFO] crate facebookincubator/fastmod has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting facebookincubator/fastmod against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/facebookincubator/fastmod:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc6daa7fa2e35549bbdf92655de9318b8201c825a9342ed7de74e119def0924a [INFO] running `"docker" "start" "-a" "dc6daa7fa2e35549bbdf92655de9318b8201c825a9342ed7de74e119def0924a"` [INFO] [stderr] Compiling serde v1.0.38 [INFO] [stderr] Compiling remove_dir_all v0.5.0 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking serde_json v1.0.14 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking globset v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.38 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Checking ignore v0.4.1 [INFO] [stderr] Checking fastmod v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:378:17 [INFO] [stderr] | [INFO] [stderr] 378 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:383:17 [INFO] [stderr] | [INFO] [stderr] 383 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:388:17 [INFO] [stderr] | [INFO] [stderr] 388 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/terminal.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match &self.ti { [INFO] [stderr] 36 | | &None => false, [INFO] [stderr] 37 | | &Some(ref ti) => ti.apply_cap(capability_name, &[], &mut io::stdout()) [INFO] [stderr] 38 | | .is_ok(), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | match self.ti { [INFO] [stderr] 36 | None => false, [INFO] [stderr] 37 | Some(ref ti) => ti.apply_cap(capability_name, &[], &mut io::stdout()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | let editor = env::var("EDITOR").unwrap_or(String::from("vim")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("vim"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:105:40 [INFO] [stderr] | [INFO] [stderr] 105 | let args: Vec<&str> = editor.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | !s.ends_with("~") && !s.ends_with("tags") && !s.ends_with("TAGS") [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:400:23 [INFO] [stderr] | [INFO] [stderr] 400 | fn is_same(x: &&DiffResult<&str>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&DiffResult<&str>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:401:13 [INFO] [stderr] | [INFO] [stderr] 401 | / match x { [INFO] [stderr] 402 | | &&DiffResult::Both(..) => true, [INFO] [stderr] 403 | | _ => false, [INFO] [stderr] 404 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 401 | match *x { [INFO] [stderr] 402 | &DiffResult::Both(..) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | / match diff { [INFO] [stderr] 451 | | &DiffResult::Left(l) => { [INFO] [stderr] 452 | | self.term.fg(term::color::RED); [INFO] [stderr] 453 | | println!("- {}", l); [INFO] [stderr] ... | [INFO] [stderr] 461 | | } [INFO] [stderr] 462 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 450 | match *diff { [INFO] [stderr] 451 | DiffResult::Left(l) => { [INFO] [stderr] 452 | self.term.fg(term::color::RED); [INFO] [stderr] 453 | println!("- {}", l); [INFO] [stderr] 454 | self.term.reset(); [INFO] [stderr] 455 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:516:32 [INFO] [stderr] | [INFO] [stderr] 516 | let contents = slurped.ok().expect("checked for error above"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:613:36 [INFO] [stderr] | [INFO] [stderr] 613 | let contents = slurped.ok().expect("checked for error above"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/main.rs:764:32 [INFO] [stderr] | [INFO] [stderr] 764 | let mut dirs: Vec<_> = matches [INFO] [stderr] | ________________________________^ [INFO] [stderr] 765 | | .values_of("dir") [INFO] [stderr] 766 | | .unwrap_or(::clap::Values::default()) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 764 | let mut dirs: Vec<_> = matches [INFO] [stderr] 765 | .values_of("dir").unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/main.rs:768:17 [INFO] [stderr] | [INFO] [stderr] 768 | / matches [INFO] [stderr] 769 | | .values_of("file-or-dir") [INFO] [stderr] 770 | | .unwrap_or(::clap::Values::default()), [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 768 | matches [INFO] [stderr] 769 | .values_of("file-or-dir").unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:378:17 [INFO] [stderr] | [INFO] [stderr] 378 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:383:17 [INFO] [stderr] | [INFO] [stderr] 383 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:388:17 [INFO] [stderr] | [INFO] [stderr] 388 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/terminal.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match &self.ti { [INFO] [stderr] 36 | | &None => false, [INFO] [stderr] 37 | | &Some(ref ti) => ti.apply_cap(capability_name, &[], &mut io::stdout()) [INFO] [stderr] 38 | | .is_ok(), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | match self.ti { [INFO] [stderr] 36 | None => false, [INFO] [stderr] 37 | Some(ref ti) => ti.apply_cap(capability_name, &[], &mut io::stdout()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | let editor = env::var("EDITOR").unwrap_or(String::from("vim")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("vim"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:105:40 [INFO] [stderr] | [INFO] [stderr] 105 | let args: Vec<&str> = editor.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | !s.ends_with("~") && !s.ends_with("tags") && !s.ends_with("TAGS") [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:400:23 [INFO] [stderr] | [INFO] [stderr] 400 | fn is_same(x: &&DiffResult<&str>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&DiffResult<&str>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:401:13 [INFO] [stderr] | [INFO] [stderr] 401 | / match x { [INFO] [stderr] 402 | | &&DiffResult::Both(..) => true, [INFO] [stderr] 403 | | _ => false, [INFO] [stderr] 404 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 401 | match *x { [INFO] [stderr] 402 | &DiffResult::Both(..) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | / match diff { [INFO] [stderr] 451 | | &DiffResult::Left(l) => { [INFO] [stderr] 452 | | self.term.fg(term::color::RED); [INFO] [stderr] 453 | | println!("- {}", l); [INFO] [stderr] ... | [INFO] [stderr] 461 | | } [INFO] [stderr] 462 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 450 | match *diff { [INFO] [stderr] 451 | DiffResult::Left(l) => { [INFO] [stderr] 452 | self.term.fg(term::color::RED); [INFO] [stderr] 453 | println!("- {}", l); [INFO] [stderr] 454 | self.term.reset(); [INFO] [stderr] 455 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:516:32 [INFO] [stderr] | [INFO] [stderr] 516 | let contents = slurped.ok().expect("checked for error above"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:613:36 [INFO] [stderr] | [INFO] [stderr] 613 | let contents = slurped.ok().expect("checked for error above"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/main.rs:764:32 [INFO] [stderr] | [INFO] [stderr] 764 | let mut dirs: Vec<_> = matches [INFO] [stderr] | ________________________________^ [INFO] [stderr] 765 | | .values_of("dir") [INFO] [stderr] 766 | | .unwrap_or(::clap::Values::default()) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 764 | let mut dirs: Vec<_> = matches [INFO] [stderr] 765 | .values_of("dir").unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/main.rs:768:17 [INFO] [stderr] | [INFO] [stderr] 768 | / matches [INFO] [stderr] 769 | | .values_of("file-or-dir") [INFO] [stderr] 770 | | .unwrap_or(::clap::Values::default()), [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 768 | matches [INFO] [stderr] 769 | .values_of("file-or-dir").unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:972:39 [INFO] [stderr] | [INFO] [stderr] 972 | let regex = RegexBuilder::new("foo").multi_line(true).build().unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.76s [INFO] running `"docker" "inspect" "dc6daa7fa2e35549bbdf92655de9318b8201c825a9342ed7de74e119def0924a"` [INFO] running `"docker" "rm" "-f" "dc6daa7fa2e35549bbdf92655de9318b8201c825a9342ed7de74e119def0924a"` [INFO] [stdout] dc6daa7fa2e35549bbdf92655de9318b8201c825a9342ed7de74e119def0924a