[INFO] updating cached repository expobrain/mars-robot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/expobrain/mars-robot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/expobrain/mars-robot" "work/ex/clippy-test-run/sources/stable/gh/expobrain/mars-robot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/expobrain/mars-robot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/expobrain/mars-robot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/expobrain/mars-robot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/expobrain/mars-robot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d70ea7caf77ef9c746a4936e2f002ddee66c7725 [INFO] sha for GitHub repo expobrain/mars-robot: d70ea7caf77ef9c746a4936e2f002ddee66c7725 [INFO] validating manifest of expobrain/mars-robot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of expobrain/mars-robot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing expobrain/mars-robot [INFO] finished frobbing expobrain/mars-robot [INFO] frobbed toml for expobrain/mars-robot written to work/ex/clippy-test-run/sources/stable/gh/expobrain/mars-robot/Cargo.toml [INFO] started frobbing expobrain/mars-robot [INFO] finished frobbing expobrain/mars-robot [INFO] frobbed toml for expobrain/mars-robot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/expobrain/mars-robot/Cargo.toml [INFO] crate expobrain/mars-robot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting expobrain/mars-robot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/expobrain/mars-robot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e44cc1b05068eb20988f5ef65344e10e7c2ff1c680ec5ae0340a790a0a7705b1 [INFO] running `"docker" "start" "-a" "e44cc1b05068eb20988f5ef65344e10e7c2ff1c680ec5ae0340a790a0a7705b1"` [INFO] [stderr] Checking mars-robot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/engine.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn rotate(&self, mov: Movements) -> Vector { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/engine.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn with_size(size: &Size) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/engine.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn rotate(&self, mov: Movements) -> Vector { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/engine.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn with_size(size: &Size) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "e44cc1b05068eb20988f5ef65344e10e7c2ff1c680ec5ae0340a790a0a7705b1"` [INFO] running `"docker" "rm" "-f" "e44cc1b05068eb20988f5ef65344e10e7c2ff1c680ec5ae0340a790a0a7705b1"` [INFO] [stdout] e44cc1b05068eb20988f5ef65344e10e7c2ff1c680ec5ae0340a790a0a7705b1