[INFO] updating cached repository exoticorn/aoc18 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/exoticorn/aoc18 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/exoticorn/aoc18" "work/ex/clippy-test-run/sources/stable/gh/exoticorn/aoc18"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/exoticorn/aoc18'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/exoticorn/aoc18" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exoticorn/aoc18"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exoticorn/aoc18'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c22d5ab5c696a954e6e1b153744dd1ec4fd900be [INFO] sha for GitHub repo exoticorn/aoc18: c22d5ab5c696a954e6e1b153744dd1ec4fd900be [INFO] validating manifest of exoticorn/aoc18 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of exoticorn/aoc18 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing exoticorn/aoc18 [INFO] finished frobbing exoticorn/aoc18 [INFO] frobbed toml for exoticorn/aoc18 written to work/ex/clippy-test-run/sources/stable/gh/exoticorn/aoc18/Cargo.toml [INFO] started frobbing exoticorn/aoc18 [INFO] finished frobbing exoticorn/aoc18 [INFO] frobbed toml for exoticorn/aoc18 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exoticorn/aoc18/Cargo.toml [INFO] crate exoticorn/aoc18 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting exoticorn/aoc18 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/exoticorn/aoc18:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2f9aa4da09b7b2d66188f3e1e1dfa11bed5c5f681ca273f571318194c9965856 [INFO] running `"docker" "start" "-a" "2f9aa4da09b7b2d66188f3e1e1dfa11bed5c5f681ca273f571318194c9965856"` [INFO] [stderr] Checking aoc18 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/days/day12.rs:118:56 [INFO] [stderr] | [INFO] [stderr] 118 | let flowers_50000000000 = flower_sum(&pots, rules, 50000000000); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `50_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/days/day14.rs:4:26 [INFO] [stderr] | [INFO] [stderr] 4 | answers(scores_after(165061, 10), num_recipes_before("165061")) [INFO] [stderr] | ^^^^^^ help: consider: `165_061` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/days/day16.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 61 | | if let ParseState::Inst(before, inst) = mem::replace(&mut state, ParseState::Idle) { [INFO] [stderr] 62 | | samples.push(Sample { [INFO] [stderr] 63 | | before, [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | } else if let ParseState::Inst(before, inst) = mem::replace(&mut state, ParseState::Idle) { [INFO] [stderr] 61 | samples.push(Sample { [INFO] [stderr] 62 | before, [INFO] [stderr] 63 | inst, [INFO] [stderr] 64 | after: regs, [INFO] [stderr] 65 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/days/day9.rs:5:57 [INFO] [stderr] | [INFO] [stderr] 5 | answers(marble_score(452, 71250), marble_score(452, 7125000)) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/days/day12.rs:118:56 [INFO] [stderr] | ^^^^^^^ help: consider: `7_125_000` [INFO] [stderr] | [INFO] [stderr] 118 | let flowers_50000000000 = flower_sum(&pots, rules, 50000000000); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `50_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/days/day14.rs:4:26 [INFO] [stderr] | [INFO] [stderr] 4 | answers(scores_after(165061, 10), num_recipes_before("165061")) [INFO] [stderr] | ^^^^^^ help: consider: `165_061` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/days/day9.rs:77:44 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(marble_score(13, 7999), 146373); [INFO] [stderr] | ^^^^^^ help: consider: `146_373` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/days.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | pub const DAYS: &'static [fn(&AocData) -> AocResult] = &[ [INFO] [stderr] | -^^^^^^^---------------------------- help: consider removing `'static`: `&[fn(&AocData) -> AocResult]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/days/day16.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 61 | | if let ParseState::Inst(before, inst) = mem::replace(&mut state, ParseState::Idle) { [INFO] [stderr] 62 | | samples.push(Sample { [INFO] [stderr] 63 | | before, [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | } else if let ParseState::Inst(before, inst) = mem::replace(&mut state, ParseState::Idle) { [INFO] [stderr] 61 | samples.push(Sample { [INFO] [stderr] 62 | before, [INFO] [stderr] 63 | inst, [INFO] [stderr] 64 | after: regs, [INFO] [stderr] 65 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/days/day9.rs:5:57 [INFO] [stderr] | [INFO] [stderr] 5 | answers(marble_score(452, 71250), marble_score(452, 7125000)) [INFO] [stderr] | ^^^^^^^ help: consider: `7_125_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/days.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | pub const DAYS: &'static [fn(&AocData) -> AocResult] = &[ [INFO] [stderr] | -^^^^^^^---------------------------- help: consider removing `'static`: `&[fn(&AocData) -> AocResult]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/days/day17.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | assert_eq!(count_water(&map, &offsets), 57); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected tuple, found integral variable [INFO] [stderr] | [INFO] [stderr] = note: expected type `(usize, usize)` [INFO] [stderr] found type `{integer}` [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `aoc18`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/days/day13.rs:152:11 [INFO] [stderr] | [INFO] [stderr] 152 | while carts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!carts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/days/day15.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | let mid = ((min as u32 + max as u32) / 2) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(min)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/days/day15.rs:65:34 [INFO] [stderr] | [INFO] [stderr] 65 | let mid = ((min as u32 + max as u32) / 2) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/days/day15.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | / match fighter { [INFO] [stderr] 172 | | Tile::Fighter { elf, .. } => { [INFO] [stderr] 173 | | if !self.mark_targets(!elf) { [INFO] [stderr] 174 | | out_of_targets = true; [INFO] [stderr] ... | [INFO] [stderr] 187 | | _ => (), [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 171 | if let Tile::Fighter { elf, .. } = fighter { [INFO] [stderr] 172 | if !self.mark_targets(!elf) { [INFO] [stderr] 173 | out_of_targets = true; [INFO] [stderr] 174 | }; [INFO] [stderr] 175 | let (x, y) = if let Some((tx, ty)) = self.fill_distance_to_targets(x, y) { [INFO] [stderr] 176 | let (mx, my) = self.backtrace_to_fighter(tx, ty); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/days/day16.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | let va = inst.a as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(inst.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/days/day16.rs:97:14 [INFO] [stderr] | [INFO] [stderr] 97 | let vb = inst.b as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(inst.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/days/day16.rs:126:24 [INFO] [stderr] | [INFO] [stderr] 126 | let mut regs = sample.before.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `sample.before` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/days/day4.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | guards.entry(id).or_insert(Vec::new()).push(start..time); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `m` is used to index `minutes` [INFO] [stderr] --> src/days/day4.rs:71:14 [INFO] [stderr] | [INFO] [stderr] 71 | for m in 0..60 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for (m, ) in minutes.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/days/day6.rs:246:45 [INFO] [stderr] | [INFO] [stderr] 246 | let seed = find_inside_span(coords, sy, sx..(sx + 1), max_distance); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `sx..=sx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/days/day6.rs:251:11 [INFO] [stderr] | [INFO] [stderr] 251 | while span.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!span.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/days/day6.rs:259:11 [INFO] [stderr] | [INFO] [stderr] 259 | while span.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!span.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/days/day8.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2f9aa4da09b7b2d66188f3e1e1dfa11bed5c5f681ca273f571318194c9965856"` [INFO] running `"docker" "rm" "-f" "2f9aa4da09b7b2d66188f3e1e1dfa11bed5c5f681ca273f571318194c9965856"` [INFO] [stdout] 2f9aa4da09b7b2d66188f3e1e1dfa11bed5c5f681ca273f571318194c9965856