[INFO] updating cached repository exitc0d3/factors-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/exitc0d3/factors-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/exitc0d3/factors-rs" "work/ex/clippy-test-run/sources/stable/gh/exitc0d3/factors-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/exitc0d3/factors-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/exitc0d3/factors-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exitc0d3/factors-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exitc0d3/factors-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 767595cd1d18ab56c3c5047485ad6181b6cd2ec6 [INFO] sha for GitHub repo exitc0d3/factors-rs: 767595cd1d18ab56c3c5047485ad6181b6cd2ec6 [INFO] validating manifest of exitc0d3/factors-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of exitc0d3/factors-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing exitc0d3/factors-rs [INFO] finished frobbing exitc0d3/factors-rs [INFO] frobbed toml for exitc0d3/factors-rs written to work/ex/clippy-test-run/sources/stable/gh/exitc0d3/factors-rs/Cargo.toml [INFO] started frobbing exitc0d3/factors-rs [INFO] finished frobbing exitc0d3/factors-rs [INFO] frobbed toml for exitc0d3/factors-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exitc0d3/factors-rs/Cargo.toml [INFO] crate exitc0d3/factors-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting exitc0d3/factors-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/exitc0d3/factors-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0824b1180b7ff3466f55ec55f31fa34266ede9cdffb1186823cb43e39344a5eb [INFO] running `"docker" "start" "-a" "0824b1180b7ff3466f55ec55f31fa34266ede9cdffb1186823cb43e39344a5eb"` [INFO] [stderr] Checking rusty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return factors; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `factors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | if (i%iter == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if (factors.len() == 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: variable `maxPrime` should have a snake case name such as `max_prime` [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let maxPrime: i64 = i/2; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return factors; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `factors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | if (i%iter == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if (factors.len() == 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: variable `maxPrime` should have a snake case name such as `max_prime` [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let maxPrime: i64 = i/2; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "0824b1180b7ff3466f55ec55f31fa34266ede9cdffb1186823cb43e39344a5eb"` [INFO] running `"docker" "rm" "-f" "0824b1180b7ff3466f55ec55f31fa34266ede9cdffb1186823cb43e39344a5eb"` [INFO] [stdout] 0824b1180b7ff3466f55ec55f31fa34266ede9cdffb1186823cb43e39344a5eb