[INFO] updating cached repository ex0dus-0x/bookcli
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ex0dus-0x/bookcli
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ex0dus-0x/bookcli" "work/ex/clippy-test-run/sources/stable/gh/ex0dus-0x/bookcli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ex0dus-0x/bookcli'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ex0dus-0x/bookcli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ex0dus-0x/bookcli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ex0dus-0x/bookcli'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3f8641f1e5da608268f2f9e925c72b6c82a20fba
[INFO] sha for GitHub repo ex0dus-0x/bookcli: 3f8641f1e5da608268f2f9e925c72b6c82a20fba
[INFO] validating manifest of ex0dus-0x/bookcli on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ex0dus-0x/bookcli on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ex0dus-0x/bookcli
[INFO] finished frobbing ex0dus-0x/bookcli
[INFO] frobbed toml for ex0dus-0x/bookcli written to work/ex/clippy-test-run/sources/stable/gh/ex0dus-0x/bookcli/Cargo.toml
[INFO] started frobbing ex0dus-0x/bookcli
[INFO] finished frobbing ex0dus-0x/bookcli
[INFO] frobbed toml for ex0dus-0x/bookcli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ex0dus-0x/bookcli/Cargo.toml
[INFO] crate ex0dus-0x/bookcli has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ex0dus-0x/bookcli against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ex0dus-0x/bookcli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2cd1abcafa4e7b20a37f55c54f0e465cd3eb916383a02d10d50f09294ba14c50
[INFO] running `"docker" "start" "-a" "2cd1abcafa4e7b20a37f55c54f0e465cd3eb916383a02d10d50f09294ba14c50"`
[INFO] [stderr]    Compiling libsqlite3-sys v0.8.1
[INFO] [stderr]     Checking termion v1.5.1
[INFO] [stderr]     Checking csv v0.15.0
[INFO] [stderr]     Checking prettytable-rs v0.6.7
[INFO] [stderr]     Checking rusqlite v0.12.0
[INFO] [stderr]     Checking bookcli v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]    --> src/database.rs:7:1
[INFO] [stderr]     |
[INFO] [stderr] 7   | / pub mod database {
[INFO] [stderr] 8   | |     
[INFO] [stderr] 9   | |     use rusqlite::{Connection, Error};
[INFO] [stderr] 10  | |     use time::Timespec;
[INFO] [stderr] ...   |
[INFO] [stderr] 111 | |     }
[INFO] [stderr] 112 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:34:33
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 Err(error) => { return Err(error); }
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:43:33
[INFO] [stderr]    |
[INFO] [stderr] 43 |                 Err(error) => { return Err(error); }
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:29:55
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn prettyprint(conn: Connection, subconn: Connection) -> (){
[INFO] [stderr]    |                                                       ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:74:20
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let home_dir = env::home_dir().unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]    --> src/database.rs:7:1
[INFO] [stderr]     |
[INFO] [stderr] 7   | / pub mod database {
[INFO] [stderr] 8   | |     
[INFO] [stderr] 9   | |     use rusqlite::{Connection, Error};
[INFO] [stderr] 10  | |     use time::Timespec;
[INFO] [stderr] ...   |
[INFO] [stderr] 111 | |     }
[INFO] [stderr] 112 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:34:33
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 Err(error) => { return Err(error); }
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:43:33
[INFO] [stderr]    |
[INFO] [stderr] 43 |                 Err(error) => { return Err(error); }
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:29:55
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn prettyprint(conn: Connection, subconn: Connection) -> (){
[INFO] [stderr]    |                                                       ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:74:20
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let home_dir = env::home_dir().unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 | /     match OpenOptions::new().read(true).write(true).create(true).open(&path){
[INFO] [stderr] 84 | |         Err(e) => {
[INFO] [stderr] 85 | |             println!("[ERROR] Couldn't open {}. Reason: {}", display,
[INFO] [stderr] 86 | |             e.description());
[INFO] [stderr] ...  |
[INFO] [stderr] 89 | |         _ => {}
[INFO] [stderr] 90 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 83 |     if let Err(e) = OpenOptions::new().read(true).write(true).create(true).open(&path) {
[INFO] [stderr] 84 |     println!("[ERROR] Couldn't open {}. Reason: {}", display,
[INFO] [stderr] 85 |     e.description());
[INFO] [stderr] 86 |     process::exit(1);
[INFO] [stderr] 87 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/main.rs:148:16
[INFO] [stderr]     |
[INFO] [stderr] 148 |           if let Ok(_) = io::stdin().read_line(&mut accept){
[INFO] [stderr]     |  _________-      ^^^^^
[INFO] [stderr] 149 | |             match accept.trim() {
[INFO] [stderr] 150 | |                 "yes" | "y" => {
[INFO] [stderr] 151 | |                     println!("Deleting...");
[INFO] [stderr] ...   |
[INFO] [stderr] 163 | |             }
[INFO] [stderr] 164 | |         }
[INFO] [stderr]     | |_________- help: try this: `if io::stdin().read_line(&mut accept).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:152:21
[INFO] [stderr]     |
[INFO] [stderr] 152 | /                     if let &Ok(ref success) = &conn.delete_table(){
[INFO] [stderr] 153 | |                         println!("{}", success);
[INFO] [stderr] 154 | |                         process::exit(0);
[INFO] [stderr] 155 | |                     } else if let &Err(ref err) = &conn.delete_table(){
[INFO] [stderr] 156 | |                         panic!("{}", err);
[INFO] [stderr] 157 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 152 |                     if let Ok(ref success) = conn.delete_table(){
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:155:28
[INFO] [stderr]     |
[INFO] [stderr] 155 |                       } else if let &Err(ref err) = &conn.delete_table(){
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 156 | |                         panic!("{}", err);
[INFO] [stderr] 157 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 155 |                     } else if let Err(ref err) = conn.delete_table(){
[INFO] [stderr]     |                                   ^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/main.rs:171:42
[INFO] [stderr]     |
[INFO] [stderr] 171 |         if matches.is_present("name") && matches.is_present("url") == true{
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `matches.is_present("url")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 | /     match OpenOptions::new().read(true).write(true).create(true).open(&path){
[INFO] [stderr] 84 | |         Err(e) => {
[INFO] [stderr] 85 | |             println!("[ERROR] Couldn't open {}. Reason: {}", display,
[INFO] [stderr] 86 | |             e.description());
[INFO] [stderr] ...  |
[INFO] [stderr] 89 | |         _ => {}
[INFO] [stderr] 90 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 83 |     if let Err(e) = OpenOptions::new().read(true).write(true).create(true).open(&path) {
[INFO] [stderr] 84 |     println!("[ERROR] Couldn't open {}. Reason: {}", display,
[INFO] [stderr] 85 |     e.description());
[INFO] [stderr] 86 |     process::exit(1);
[INFO] [stderr] 87 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/main.rs:148:16
[INFO] [stderr]     |
[INFO] [stderr] 148 |           if let Ok(_) = io::stdin().read_line(&mut accept){
[INFO] [stderr]     |  _________-      ^^^^^
[INFO] [stderr] 149 | |             match accept.trim() {
[INFO] [stderr] 150 | |                 "yes" | "y" => {
[INFO] [stderr] 151 | |                     println!("Deleting...");
[INFO] [stderr] ...   |
[INFO] [stderr] 163 | |             }
[INFO] [stderr] 164 | |         }
[INFO] [stderr]     | |_________- help: try this: `if io::stdin().read_line(&mut accept).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:152:21
[INFO] [stderr]     |
[INFO] [stderr] 152 | /                     if let &Ok(ref success) = &conn.delete_table(){
[INFO] [stderr] 153 | |                         println!("{}", success);
[INFO] [stderr] 154 | |                         process::exit(0);
[INFO] [stderr] 155 | |                     } else if let &Err(ref err) = &conn.delete_table(){
[INFO] [stderr] 156 | |                         panic!("{}", err);
[INFO] [stderr] 157 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 152 |                     if let Ok(ref success) = conn.delete_table(){
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:155:28
[INFO] [stderr]     |
[INFO] [stderr] 155 |                       } else if let &Err(ref err) = &conn.delete_table(){
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 156 | |                         panic!("{}", err);
[INFO] [stderr] 157 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 155 |                     } else if let Err(ref err) = conn.delete_table(){
[INFO] [stderr]     |                                   ^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/main.rs:171:42
[INFO] [stderr]     |
[INFO] [stderr] 171 |         if matches.is_present("name") && matches.is_present("url") == true{
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `matches.is_present("url")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.78s
[INFO] running `"docker" "inspect" "2cd1abcafa4e7b20a37f55c54f0e465cd3eb916383a02d10d50f09294ba14c50"`
[INFO] running `"docker" "rm" "-f" "2cd1abcafa4e7b20a37f55c54f0e465cd3eb916383a02d10d50f09294ba14c50"`
[INFO] [stdout] 2cd1abcafa4e7b20a37f55c54f0e465cd3eb916383a02d10d50f09294ba14c50