[INFO] updating cached repository evernym/cargo-test-xunit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/evernym/cargo-test-xunit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/evernym/cargo-test-xunit" "work/ex/clippy-test-run/sources/stable/gh/evernym/cargo-test-xunit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/evernym/cargo-test-xunit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/evernym/cargo-test-xunit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evernym/cargo-test-xunit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evernym/cargo-test-xunit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f05e52087024d93770a5581c8f66c1ee9b5e87de [INFO] sha for GitHub repo evernym/cargo-test-xunit: f05e52087024d93770a5581c8f66c1ee9b5e87de [INFO] validating manifest of evernym/cargo-test-xunit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of evernym/cargo-test-xunit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing evernym/cargo-test-xunit [INFO] finished frobbing evernym/cargo-test-xunit [INFO] frobbed toml for evernym/cargo-test-xunit written to work/ex/clippy-test-run/sources/stable/gh/evernym/cargo-test-xunit/Cargo.toml [INFO] started frobbing evernym/cargo-test-xunit [INFO] finished frobbing evernym/cargo-test-xunit [INFO] frobbed toml for evernym/cargo-test-xunit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evernym/cargo-test-xunit/Cargo.toml [INFO] crate evernym/cargo-test-xunit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting evernym/cargo-test-xunit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/evernym/cargo-test-xunit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 57dda6031d05a5a696266447e9f353ddfa280c6cd792153ad05b857e26bfcbb6 [INFO] running `"docker" "start" "-a" "57dda6031d05a5a696266447e9f353ddfa280c6cd792153ad05b857e26bfcbb6"` [INFO] [stderr] Checking peresil v0.3.0 [INFO] [stderr] Checking typed-arena v1.2.0 [INFO] [stderr] Checking sxd-document v0.2.0 [INFO] [stderr] Checking cargo-test-xunit v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | failed: failed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `failed` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | failed: failed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `failed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | test_results: test_results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `test_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | test_results: test_results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `test_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/element.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn build_xunit_report <'a>(package : &'a Package, report: TestReport) -> Document<'a> { [INFO] [stderr] 33 | | [INFO] [stderr] 34 | | let dom = package.as_document(); [INFO] [stderr] 35 | | [INFO] [stderr] ... | [INFO] [stderr] 64 | | dom [INFO] [stderr] 65 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / format_document(&document, &mut f) [INFO] [stderr] 41 | | .ok() [INFO] [stderr] 42 | | .expect("unable to output XML"); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/element.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn build_xunit_report <'a>(package : &'a Package, report: TestReport) -> Document<'a> { [INFO] [stderr] 33 | | [INFO] [stderr] 34 | | let dom = package.as_document(); [INFO] [stderr] 35 | | [INFO] [stderr] ... | [INFO] [stderr] 64 | | dom [INFO] [stderr] 65 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / format_document(&document, &mut f) [INFO] [stderr] 41 | | .ok() [INFO] [stderr] 42 | | .expect("unable to output XML"); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.51s [INFO] running `"docker" "inspect" "57dda6031d05a5a696266447e9f353ddfa280c6cd792153ad05b857e26bfcbb6"` [INFO] running `"docker" "rm" "-f" "57dda6031d05a5a696266447e9f353ddfa280c6cd792153ad05b857e26bfcbb6"` [INFO] [stdout] 57dda6031d05a5a696266447e9f353ddfa280c6cd792153ad05b857e26bfcbb6