[INFO] updating cached repository evanhackett/CS_410P_chip8
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/evanhackett/CS_410P_chip8
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/evanhackett/CS_410P_chip8" "work/ex/clippy-test-run/sources/stable/gh/evanhackett/CS_410P_chip8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/evanhackett/CS_410P_chip8'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/evanhackett/CS_410P_chip8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evanhackett/CS_410P_chip8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evanhackett/CS_410P_chip8'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ad4e01683ba88773d7ca6b0020e4aa5fd4156d6e
[INFO] sha for GitHub repo evanhackett/CS_410P_chip8: ad4e01683ba88773d7ca6b0020e4aa5fd4156d6e
[INFO] validating manifest of evanhackett/CS_410P_chip8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of evanhackett/CS_410P_chip8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing evanhackett/CS_410P_chip8
[INFO] finished frobbing evanhackett/CS_410P_chip8
[INFO] frobbed toml for evanhackett/CS_410P_chip8 written to work/ex/clippy-test-run/sources/stable/gh/evanhackett/CS_410P_chip8/Cargo.toml
[INFO] started frobbing evanhackett/CS_410P_chip8
[INFO] finished frobbing evanhackett/CS_410P_chip8
[INFO] frobbed toml for evanhackett/CS_410P_chip8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evanhackett/CS_410P_chip8/Cargo.toml
[INFO] crate evanhackett/CS_410P_chip8 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting evanhackett/CS_410P_chip8 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/evanhackett/CS_410P_chip8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6aec91a5e713c5d3e3b51c5669a502e0aac0ca6486488de3131d65fc6394b104
[INFO] running `"docker" "start" "-a" "6aec91a5e713c5d3e3b51c5669a502e0aac0ca6486488de3131d65fc6394b104"`
[INFO] [stderr]    Compiling x11-dl v2.14.0
[INFO] [stderr]    Compiling minifb v0.10.6
[INFO] [stderr]     Checking chip8 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:84:30
[INFO] [stderr]    |
[INFO] [stderr] 84 |                         1 => 0xffffff,
[INFO] [stderr]    |                              ^^^^^^^^ help: consider: `0x00ff_ffff`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:84:30
[INFO] [stderr]    |
[INFO] [stderr] 84 |                         1 => 0xffffff,
[INFO] [stderr]    |                              ^^^^^^^^ help: consider: `0x00ff_ffff`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/chip8.rs:36:37
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn load_rom(&mut self, rom: &Vec<u8>) {
[INFO] [stderr]    |                                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `rom`
[INFO] [stderr]   --> src/chip8.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for i in 0..rom.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for (i, <item>) in rom.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/chip8.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for i in 0..rom.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[512..(rom.len() + 512)].clone_from_slice(&rom[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8.rs:68:43
[INFO] [stderr]    |
[INFO] [stderr] 68 |             let b = self.memory[(self.i + sprite_y as u16) as usize];
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8.rs:84:21
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let byte1 = self.memory[self.pc as usize] as u16;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc as usize])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8.rs:85:21
[INFO] [stderr]    |
[INFO] [stderr] 85 |         let byte2 = self.memory[(self.pc + 1) as usize] as u16;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[(self.pc + 1) as usize])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     file.read_to_end(&mut rom_data);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:93:13
[INFO] [stderr]    |
[INFO] [stderr] 93 |             window.update_with_buffer(&buffer);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/chip8.rs:36:37
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn load_rom(&mut self, rom: &Vec<u8>) {
[INFO] [stderr]    |                                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `rom`
[INFO] [stderr]   --> src/chip8.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for i in 0..rom.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for (i, <item>) in rom.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/chip8.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for i in 0..rom.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[512..(rom.len() + 512)].clone_from_slice(&rom[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8.rs:68:43
[INFO] [stderr]    |
[INFO] [stderr] 68 |             let b = self.memory[(self.i + sprite_y as u16) as usize];
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8.rs:84:21
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let byte1 = self.memory[self.pc as usize] as u16;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[self.pc as usize])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8.rs:85:21
[INFO] [stderr]    |
[INFO] [stderr] 85 |         let byte2 = self.memory[(self.pc + 1) as usize] as u16;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.memory[(self.pc + 1) as usize])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     file.read_to_end(&mut rom_data);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:93:13
[INFO] [stderr]    |
[INFO] [stderr] 93 |             window.update_with_buffer(&buffer);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.22s
[INFO] running `"docker" "inspect" "6aec91a5e713c5d3e3b51c5669a502e0aac0ca6486488de3131d65fc6394b104"`
[INFO] running `"docker" "rm" "-f" "6aec91a5e713c5d3e3b51c5669a502e0aac0ca6486488de3131d65fc6394b104"`
[INFO] [stdout] 6aec91a5e713c5d3e3b51c5669a502e0aac0ca6486488de3131d65fc6394b104