[INFO] updating cached repository evanbowman/Oxide [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/evanbowman/Oxide [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/evanbowman/Oxide" "work/ex/clippy-test-run/sources/stable/gh/evanbowman/Oxide"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/evanbowman/Oxide'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/evanbowman/Oxide" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evanbowman/Oxide"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evanbowman/Oxide'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d3d3706c6f046a238c1c3d60b95069d1e673908 [INFO] sha for GitHub repo evanbowman/Oxide: 2d3d3706c6f046a238c1c3d60b95069d1e673908 [INFO] validating manifest of evanbowman/Oxide on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of evanbowman/Oxide on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing evanbowman/Oxide [INFO] finished frobbing evanbowman/Oxide [INFO] frobbed toml for evanbowman/Oxide written to work/ex/clippy-test-run/sources/stable/gh/evanbowman/Oxide/Cargo.toml [INFO] started frobbing evanbowman/Oxide [INFO] finished frobbing evanbowman/Oxide [INFO] frobbed toml for evanbowman/Oxide written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evanbowman/Oxide/Cargo.toml [INFO] crate evanbowman/Oxide has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting evanbowman/Oxide against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/evanbowman/Oxide:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c7e45930d6918f244e4872e58540cde81e081bf9e3b2f9e9978840a7685b1579 [INFO] running `"docker" "start" "-a" "c7e45930d6918f244e4872e58540cde81e081bf9e3b2f9e9978840a7685b1579"` [INFO] [stderr] Checking regex-syntax v0.3.4 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking num_cpus v1.0.0 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking thread_local v0.2.6 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking aho-corasick v0.5.2 [INFO] [stderr] Checking regex v0.1.73 [INFO] [stderr] Checking ox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dir.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | None => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dir.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/dir.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 33 | | if check_extension(&path) { [INFO] [stderr] 34 | | entries.push(entry); [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | } else if check_extension(&path) { [INFO] [stderr] 33 | entries.push(entry); [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dir.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / if !path.is_dir() { [INFO] [stderr] 48 | | if check_extension(&path) { [INFO] [stderr] 49 | | entries.push(entry); [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | if !path.is_dir() && check_extension(&path) { [INFO] [stderr] 48 | entries.push(entry); [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return idx; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | return idx; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dir.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | None => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dir.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/dir.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 33 | | if check_extension(&path) { [INFO] [stderr] 34 | | entries.push(entry); [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | } else if check_extension(&path) { [INFO] [stderr] 33 | entries.push(entry); [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dir.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / if !path.is_dir() { [INFO] [stderr] 48 | | if check_extension(&path) { [INFO] [stderr] 49 | | entries.push(entry); [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | if !path.is_dir() && check_extension(&path) { [INFO] [stderr] 48 | entries.push(entry); [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return idx; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | return idx; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn get_entries(root: &String, recur: bool) -> io::Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/dir.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match recur { [INFO] [stderr] 9 | | true => try!(walk(path, &mut entries)), [INFO] [stderr] 10 | | false => try!(explore(path, &mut entries)), [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if recur { try!(walk(path, &mut entries)) } else { try!(explore(path, &mut entries)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/search.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | let mutex = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/search.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / match res { [INFO] [stderr] 44 | | Err(e) => { [INFO] [stderr] 45 | | println!("Error: thread panicked with error code {:?}", e); [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | _ => {} [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Err(e) = res { [INFO] [stderr] 44 | println!("Error: thread panicked with error code {:?}", e); [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/search.rs:62:34 [INFO] [stderr] | [INFO] [stderr] 62 | fn search_rangeof_files(pattern: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/search.rs:63:34 [INFO] [stderr] | [INFO] [stderr] 63 | entries: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `entries`. [INFO] [stderr] --> src/search.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | for idx in range.0..range.1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for in entries.iter().take(range.1).skip(range.0) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/search.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | if matches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/search.rs:172:26 [INFO] [stderr] | [INFO] [stderr] 172 | if bytes[idx] == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn get_entries(root: &String, recur: bool) -> io::Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/dir.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match recur { [INFO] [stderr] 9 | | true => try!(walk(path, &mut entries)), [INFO] [stderr] 10 | | false => try!(explore(path, &mut entries)), [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if recur { try!(walk(path, &mut entries)) } else { try!(explore(path, &mut entries)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/search.rs:184:26 [INFO] [stderr] | [INFO] [stderr] 184 | if bytes[idx] == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/search.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | let mutex = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/search.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / match res { [INFO] [stderr] 44 | | Err(e) => { [INFO] [stderr] 45 | | println!("Error: thread panicked with error code {:?}", e); [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | _ => {} [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Err(e) = res { [INFO] [stderr] 44 | println!("Error: thread panicked with error code {:?}", e); [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/search.rs:62:34 [INFO] [stderr] | [INFO] [stderr] 62 | fn search_rangeof_files(pattern: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/search.rs:63:34 [INFO] [stderr] | [INFO] [stderr] 63 | entries: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `entries`. [INFO] [stderr] --> src/search.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | for idx in range.0..range.1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for in entries.iter().take(range.1).skip(range.0) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/search.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | if matches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/search.rs:172:26 [INFO] [stderr] | [INFO] [stderr] 172 | if bytes[idx] == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/search.rs:184:26 [INFO] [stderr] | [INFO] [stderr] 184 | if bytes[idx] == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.99s [INFO] running `"docker" "inspect" "c7e45930d6918f244e4872e58540cde81e081bf9e3b2f9e9978840a7685b1579"` [INFO] running `"docker" "rm" "-f" "c7e45930d6918f244e4872e58540cde81e081bf9e3b2f9e9978840a7685b1579"` [INFO] [stdout] c7e45930d6918f244e4872e58540cde81e081bf9e3b2f9e9978840a7685b1579